From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 6B49BA0C3F
for <public@inbox.dpdk.org>; Mon, 10 May 2021 17:32:06 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5F56240F35;
Mon, 10 May 2021 17:32:06 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id BC4094003E;
Mon, 10 May 2021 17:32:03 +0200 (CEST)
IronPort-SDR: V2oZ7vwePnxhbI6r1TBqx3J8Zp1Nmvqw70cq5y9BYbZR+xhO1ovqciM1oOdSAuRjs4uezHHg7/
4BRJGUJ4LB5A==
X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="220168458"
X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="220168458"
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 May 2021 08:32:02 -0700
IronPort-SDR: Xt81DjfgEgMARILgw5xmpT1Hi3C+Yqr3Y9zvrM8tN/rNpfPlHR/ikNNhdAuWE3XuoVtGh1FLcB
8XS4m+CgADfg==
X-IronPort-AV: E=Sophos;i="5.82,287,1613462400"; d="scan'208";a="536457528"
Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.213.241.243])
([10.213.241.243])
by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 May 2021 08:32:01 -0700
To: Thomas Monjalon <thomas@monjalon.net>,
Lance Richardson <lance.richardson@broadcom.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>, dev@dpdk.org, stable@dpdk.org
References: <20210507181025.84012-1-lance.richardson@broadcom.com>
<20210508142753.114343-1-lance.richardson@broadcom.com>
<2003089.4ItjxMFgZf@thomas>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com>
Date: Mon, 10 May 2021 16:31:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <2003089.4ItjxMFgZf@thomas>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eal: fix memory mapping for
32-bit targets
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>
On 10-May-21 1:42 PM, Thomas Monjalon wrote:
> +Cc Anatoly
>
> 08/05/2021 16:27, Lance Richardson:
>> For 32-bit targets, size_t is normally a 32-bit type and
>> does not have sufficient range to represent 64-bit offsets
>> that can are needed when mapping PCI addresses. Use uint64_t
>> instead.
>>
>> Found when attempting to run 32-bit Linux dpdk-testpmd
>> using VFIO driver:
>>
>> EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \
>> 0x200000, 0x20000000000): Invalid argument ((nil))
>>
>> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
>> Cc: stable@dpdk.org
>> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
>> ---
LGTM, although the Fixes: tag is probably wrong because IIRC previous
versions did have the same issue.
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly