From: "Xueming(Steven) Li" <xuemingl@nvidia.com>
To: "tudor.cornea@gmail.com" <tudor.cornea@gmail.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [PATCH 20.11] net/ixgbe: fix port initialization if MTU config fails
Date: Sat, 27 Nov 2021 14:29:33 +0000 [thread overview]
Message-ID: <7e307e0b521d29fce9101cd712d52113cbe880ef.camel@nvidia.com> (raw)
In-Reply-To: <1636621924-54546-1-git-send-email-tudor.cornea@gmail.com>
On Thu, 2021-11-11 at 11:12 +0200, Tudor Cornea wrote:
> [ upstream commit 2108930be123ab83c837e7dd6eb3078ec3482ad4 ]
>
> On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't
> seem to initialize anymore, while running testpmd.
>
> Configuring Port 0 (socket 0)
> ixgbevf_dev_rx_init(): Set max packet length to 1518 failed.
> ixgbevf_dev_start(): Unable to initialize RX hardware (-22)
> Fail to start port 0: Invalid argument
> Configuring Port 1 (socket 0)
> ixgbevf_dev_rx_init(): Set max packet length to 1518 failed.
> ixgbevf_dev_start(): Unable to initialize RX hardware (-22)
> Fail to start port 1: Invalid argument
> Please stop the ports first
>
> If the call to ixgbevf_rlpml_set_vf fails and we return prematurely,
> we will not be able to initialize the ports correctly.
>
> Fixes: c77866a16904 ("net/ixgbe: detect failed VF MTU set")
>
> We can make this particular use case work correctly if we don't
> return an error, which seems to be consistent with the overall
> kernel ixgbevf implementation.
>
> [1]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c?h=v5.14#n2015
>
> Signed-off-by: Tudor Cornea <tudor.cornea@gmail.com>
> ---
Applied to 20.11.4 list, thanks!
prev parent reply other threads:[~2021-11-27 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 9:12 Tudor Cornea
2021-11-27 14:29 ` Xueming(Steven) Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e307e0b521d29fce9101cd712d52113cbe880ef.camel@nvidia.com \
--to=xuemingl@nvidia.com \
--cc=stable@dpdk.org \
--cc=tudor.cornea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).