From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D7DCA0C52 for ; Mon, 18 Oct 2021 23:35:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1160E4111A; Mon, 18 Oct 2021 23:35:51 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0B850410EA; Mon, 18 Oct 2021 23:35:46 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10141"; a="209163232" X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="209163232" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Oct 2021 14:35:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,382,1624345200"; d="scan'208";a="573632541" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga002.fm.intel.com with ESMTP; 18 Oct 2021 14:35:46 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 18 Oct 2021 14:35:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 18 Oct 2021 14:35:45 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 18 Oct 2021 14:35:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHS8GMaXwLfSdCuTT4zDZB1wdJfMslWu65/GQk6/2eHZRi7D9lurzPn+lBIlt6DrGSMnL6cqWqAO9oLDwBUWP3gArCslzBhTwXNXS06eZmEIQqkM5Wmd/uHnaKjZxkgl9plKaKYOPaqI3WB/MEL1W+8qE6zVD9iV7kcT1Sy89wrkUlpWFWyfeaQx4nUD68RQjdjjAdw+tYVTpJqUm3kOzUXWHmRIlJYopDNMTGC+vogIND/+jVvfE6rInMQF8ZDSZjAuzDApLHqTghlzLMxvdyn+W0mNUizaH5JDA/IN6KXFIyNu3tGdLQz+uRDDX9K1StIgC9KCYL36jOcSsArhMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X1A7IEylBkWw+ESNIVQuJPFoFIRzu9aHTZ7o6jaYPZs=; b=F6KILj7GDDV1qKLYF+CKhdu8EmT1jzijxJcAWwxr0X1MP2uKdSEDS9DCZP6uMLxGFeLlWcNfp3Iu1l+8K4Bsc5F2AuSBZ7AQn5o3L9O/0gF5T5PSm6F3kCRa8R+IYywl9aekG2xwRuO+SPguE3hxo8CTJIeRXfe/AWjCtZZGCtMQErrygT+k+1UxTGFQnc0fDlCv3Ka5+3EImuhwvscEOsbr1+LSUdATz0gWBP8RsDaPBnJ7hxIeRBpc6i/rNWdQm+6bMr8EtW1NwSeFyIyVzN4Daxwa1xCz37+oR29Ao/PMEQAf2edn9Xn5ZCBdOSY7gxYuEm/FcNzFUXsIUTY8Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1A7IEylBkWw+ESNIVQuJPFoFIRzu9aHTZ7o6jaYPZs=; b=s7P/AcN9Mcw5xiQYFJAivQWmtsUwEI5wJAeVKan5XwVXYj1/EXaE1VDDprNfasIu2W2YZdt8gNSYgr2BjlVmLiBVjS4h9WubTELdk6DoYExPnlqrzeKZX7fRJ+bNX+m5Ko/wypoHPWdjViPwAcz/bEqgOq7aiBYIJFz+0gsURt8= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4917.namprd11.prod.outlook.com (2603:10b6:510:32::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Mon, 18 Oct 2021 21:35:41 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.018; Mon, 18 Oct 2021 21:35:41 +0000 Message-ID: <7f11c4fb-f235-c2d9-236b-838282b1b54a@intel.com> Date: Mon, 18 Oct 2021 22:35:34 +0100 Content-Language: en-US To: Leyi Rong , , CC: , , References: <20210929121309.11766-1-leyi.rong@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20210929121309.11766-1-leyi.rong@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:10:110::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB8PR04CA0002.eurprd04.prod.outlook.com (2603:10a6:10:110::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18 via Frontend Transport; Mon, 18 Oct 2021 21:35:39 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 59b9020d-5880-4b7c-8e63-08d9927f3b83 X-MS-TrafficTypeDiagnostic: PH0PR11MB4917: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K8Uj3yxI72OBnfaXcG2AKtweEgVexSVL/uuaHbuZT3grH+pdeEoSn9GGoNCSHhHtZWWZ4HxG54Bwt2FHVnc2PmjiO0h9d/DYs0Dlso1c45dZWIGTVcINla1CxFDkPqfNqXnDvcTjgc0uCyOE+1bYl65m60AOYOW6KCqOQqAWDp67HMSQWUj0sGGKM+s0mcU4Sh3wbUgoiFCS9XKte3epsqhJbKyhI45gBynu9ONDpDpq9TaC2cbzM2Lac5tILP9rAsJmvVG2f9HG7T1n5Mt/ABBz7T7OsElyEVOfKNEYjLLuhn5dc+MOAw8s2izafDXa5om/f2uJZajBZYt0LWGHC57NrfUzuyFHjLCEiUOzqkm3AWsrt2sGLJYFyWojAn9j3MYT4M46uhFnn17DYQvXQ2mqx0N9pXZ+49W7Zdel2ehEWqBQvi1XVl1npD8tqfafr2IVhdFql9xVKJb9xGb6jNt45WF4s/Mbhv8k3QlEYUTeyDpNWdxZb7SYCeDXskpeMtyNwZgrHc4VciKVNamFgo1i1U9Nhl48abEnXId8kapJrQmn88sV2Kx6S9vuDqk0af45FM3U97sRiYMP24LRTMnTZkx/HpJozbcr90vmZNfDudQTGyWdYbhIlG9tr3Yfnj+M2Yz/CgYw2wKvFMBcNQ7u8NizaZJb3UexIVcfomPNjoFZBq9p9MVuAzBzxnNnTsEVnbzcSoUR409ouMEiTXWifFC/qeykZ2qh74uQ6MI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(31696002)(8676002)(66476007)(82960400001)(66946007)(2616005)(956004)(53546011)(66556008)(38100700002)(6486002)(4326008)(316002)(44832011)(36756003)(6636002)(86362001)(2906002)(8936002)(508600001)(31686004)(6666004)(16576012)(450100002)(5660300002)(186003)(26005)(41533002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UlhVZktvSVYrWWgwWDdiaWdyZ2N4Q002Q3l4SjRRUXIzZ211QnA1ZzdHK1NR?= =?utf-8?B?MGRjQU5qVzVTQkNRTERjZWdLYW1qd2ZwM05KUWQwNytkUUxNYmsxZ3dTRmRl?= =?utf-8?B?b2h3UzFObm5ZNUJBdEp0UkhSSDJ1Q1ZBOStxaVFPUExKM3RZRkJUYU5HZDA1?= =?utf-8?B?RGNGL0hod1lFY0Q5UVhIci90d2ZyLzJlRkxicWlDZTdtaTZ3UEhmVURENFRo?= =?utf-8?B?VUdtTEtGZHh6VmFHSFM4bHVDYmplUmgrZlZUNHorWlI4SnVsdGxsam5mdFJr?= =?utf-8?B?dlllcVV4a1R6UCtYckxvdHJuSmFERnU3dEtqUWJHdERPZ0ppNFpUeVhGNUZI?= =?utf-8?B?eExXNThMUGFqS3A2dnQzVGZldXdCL2h2VGRYRFlqOU1yU285WXlMYlN3eGp2?= =?utf-8?B?WHh1NUJMSjkzMFVUUFUyOUZWNE9LTmR2cExnZGRPMTJVTG0wbHZYNEw0cUVj?= =?utf-8?B?Nm96dDRnOUJwSER4bFMwS3k1dWdqaTExN09URjJZd3lBVStxNUx1b005dEdG?= =?utf-8?B?OWt4T1hIUHI2RFFnK2F4VUhoMllWejN3VFVwSHNnUmlzeXJiRktwcStzUk9u?= =?utf-8?B?WjZBQlhrZkpkbzFJeVZ0QUtsTWJkWmw1ZHlPNWdEUTFsUjJTNEFrTldScWRa?= =?utf-8?B?eldDeUVNQW43L0dTSkVhUnBTOStuZW5udks0NGxWOC85WkE3Z04zSmlIblJZ?= =?utf-8?B?cUVkbitNdEptRG1MOTYzZHhjU1Rkby9NbW52dVlPRlRCY2tRVDhIalgxKzUz?= =?utf-8?B?Q3J6TGpJRXBaTUYxWDBFUzVBSEdmaStLYmNJUkFJcXp2bzhQN2wzUUN0UzZZ?= =?utf-8?B?Uk1mRUxQa3lvYmR4Nk9oTzBKVDNxd0djMlZNaE9BZG1KN01sUGtvbG43VGwz?= =?utf-8?B?dDIzL2RUV0ExNnhKTlRYRHB5TXpBdVoyWFRLN2E5WnF2SjhqL3haYVIwdlk3?= =?utf-8?B?RExhcis3Q2ZEVnhXa29tYzVibUt5TjNhT1loOFArVkNwNThVK2l2MXVJSUIz?= =?utf-8?B?ZkVZRUJFT1JVTVFGU0t3aFBjMjJBREY4d09PY3pBcDliRkZiTDR0ZFoybUli?= =?utf-8?B?TEZrZzBXWUtxaU1wVnV5ZzJOczVnS2h1WTNkWjE2Szc5bkNpeHdIN1NwWFBG?= =?utf-8?B?RGR5emdSMEg0SkdBVERBRGhvRldJcDZrdDA0TkFIcmd1SE1KYW9jd28xU1JZ?= =?utf-8?B?QlByY1NpY0ZVRTA2N3h3VHNsSzVnSk05aHdiUHNENnU3Mi9DTVE4U0VOSUp2?= =?utf-8?B?dHF0QnFUOVpBL0VVMzI3WnJJSUtXODFtTEQ1RTUzRHUyYmNYMEJpOUUzZ0c5?= =?utf-8?B?eFpCVDF4aFZxNU4wSi9lNjlZS1hvZWNFbUp3emVmQThvdXhZejBMWkVyRUpH?= =?utf-8?B?V2NOWXdFMm5xZFRCZ3Y4NnNGem1GRmNBRU0yb1lacTEyWlFMVVkzREhiQjMy?= =?utf-8?B?cSsxQ1RTTExiQnIwL1F3UU9Lbm51VFRUdGlDZWhGWXJsc043M0JRV1dtdGcr?= =?utf-8?B?S1F5S3hHU0xJWWpmMWN6cWUvdmJTdnJYZGI0K1d5bll3ODlLbkR6QWxWb3hU?= =?utf-8?B?WWVHMVpydUoreXdaclNkdjR4a28remhCdEk4cWdDVDkrT0lsclF5L1o2QXh6?= =?utf-8?B?NmxtYkdjS1lTSXR1SUpEZ3BXUjFjTmRrWlh5Q0djWmZQZE1EOUIzS3FYUUJh?= =?utf-8?B?NlN6UVA2VVhibW5aaUp1MWdFT1FxNGg0K0VDOHpUYWdvYXRjWDR6emgveVg1?= =?utf-8?Q?9s96MMdyr18ax6eZcJDywZBshLBOGrQ3IQprjan?= X-MS-Exchange-CrossTenant-Network-Message-Id: 59b9020d-5880-4b7c-8e63-08d9927f3b83 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2021 21:35:40.9353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q7V+l1Mh8q80iBaLovpIhrBYOynBaCpWek9pwi+3+zuYfJ3nhQLRW/KY36QOhQjXVBanaRRy4qxoL97lEXYqaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4917 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [PATCH 1/2] net/i40e: fix generic build on FreeBSD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/29/2021 1:13 PM, Leyi Rong wrote: > The common header file for vectorization is included in multiple files, > and so must use macros for the current compilation unit, rather than the > compiler-capability flag set for the whole driver. With the current, > incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up > SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT" > to the compiler-defined "__AVX*__" macros fixes this issue. In addition, > splitting AVX-specific code into the new i40e_rxtx_common_avx.h header > file to avoid such bugs. > > Bugzilla ID: 788 > Fixes: 0604b1f2208f ("net/i40e: fix crash in AVX512") > Cc: wenzhuo.lu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Leyi Rong > Signed-off-by: Bruce Richardson <...> > diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h > index f52ed98d62..798d6a3e4a 100644 > --- a/drivers/net/i40e/i40e_rxtx_vec_common.h > +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h > @@ -15,6 +15,10 @@ > #pragma GCC diagnostic ignored "-Wcast-qual" > #endif > > +#ifdef __AVX2__ > +#include "i40e_rxtx_common_avx.h" > +#endif > + The 'i40e_rxtx_common_avx.h' header is not required by 'i40e_rxtx_vec_common.h', why not include 'i40e_rxtx_common_avx.h' directly from related .c files: i40e_rxtx_vec_avx2.c i40e_rxtx_vec_avx512.c So "#ifdef __AVX2__" won't be needed. Same for ice.