* [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings
@ 2025-10-29 9:55 Gregory Etelson
2025-10-29 9:55 ` [PATCH 2/2] net/mlx5: " Gregory Etelson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Gregory Etelson @ 2025-10-29 9:55 UTC (permalink / raw)
To: dev
Cc: getelson, mkashani, rasland, stable, Matan Azrad,
Viacheslav Ovsiienko, Moti Haimovsky
The patch fixes compilation warnings produced by clang -Wcomma option.
Bugzilla ID: 1810
Fixes: ba576975a89b ("net/mlx4: support hardware TSO")
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
drivers/net/mlx4/mlx4_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c
index 947cae491c..a4df6f7bcb 100644
--- a/drivers/net/mlx4/mlx4_rxtx.c
+++ b/drivers/net/mlx4/mlx4_rxtx.c
@@ -638,7 +638,7 @@ mlx4_tx_burst_fill_tso_hdr(struct rte_mbuf *buf,
thdr.vto = sq->buf;
/* New TXBB, stash the first 32bits for later use. */
pv[*pv_counter].dst = (volatile uint32_t *)thdr.to;
- pv[(*pv_counter)++].val = *(uint32_t *)from,
+ pv[(*pv_counter)++].val = *(uint32_t *)from;
from += sizeof(uint32_t);
thdr.to += sizeof(uint32_t);
remain_size -= txbb_avail_space + sizeof(uint32_t);
--
2.51.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] net/mlx5: fix unnecessary comma compilation warnings 2025-10-29 9:55 [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings Gregory Etelson @ 2025-10-29 9:55 ` Gregory Etelson 2025-10-29 13:29 ` Dariusz Sosnowski 2025-10-29 13:25 ` [PATCH 1/2] net/mlx4: " Dariusz Sosnowski 2025-11-02 7:31 ` Raslan Darawsheh 2 siblings, 1 reply; 5+ messages in thread From: Gregory Etelson @ 2025-10-29 9:55 UTC (permalink / raw) To: dev Cc: getelson, mkashani, rasland, stable, Dariusz Sosnowski, Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Rongwei Liu, Michael Baum, Li Zhang The patch fixes compilation warnings produced by clang -Wcomma option. Bugzilla ID: 1810 Fixes: 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field") Fixes: 86d259cec852 ("net/mlx5: separate Tx queue object creations") Fixes: bc1d90a3cf6f ("net/mlx5: fix build with Direct Verbs disabled") Fixes: 444320186393 ("net/mlx5: support meter creation with policy") Fixes: 821a6a5cc495 ("net/mlx5: add metadata split for compatibility") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson <getelson@nvidia.com> --- drivers/net/mlx5/linux/mlx5_os.c | 4 ++-- drivers/net/mlx5/linux/mlx5_verbs.c | 2 +- drivers/net/mlx5/mlx5_flow.c | 12 ++++++------ drivers/net/mlx5/mlx5_flow_dv.c | 2 +- drivers/net/mlx5/mlx5_nta_split.c | 4 ++-- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 8d11b1ac3a..c742e0f282 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -431,8 +431,8 @@ __mlx5_discovery_misc5_cap(struct mlx5_priv *priv) DRV_LOG(INFO, "No SW steering support"); return; } - dv_attr.type = IBV_FLOW_ATTR_NORMAL, - dv_attr.match_mask = (void *)&matcher_mask, + dv_attr.type = IBV_FLOW_ATTR_NORMAL; + dv_attr.match_mask = (void *)&matcher_mask; dv_attr.match_criteria_enable = (1 << MLX5_MATCH_CRITERIA_ENABLE_OUTER_BIT) | (1 << MLX5_MATCH_CRITERIA_ENABLE_MISC5_BIT); diff --git a/drivers/net/mlx5/linux/mlx5_verbs.c b/drivers/net/mlx5/linux/mlx5_verbs.c index 9011319a3e..01d3d6ae5d 100644 --- a/drivers/net/mlx5/linux/mlx5_verbs.c +++ b/drivers/net/mlx5/linux/mlx5_verbs.c @@ -883,7 +883,7 @@ mlx5_txq_ibv_qp_create(struct rte_eth_dev *dev, uint16_t idx) * dev_cap.max_sge limit and will still work properly. */ qp_attr.cap.max_send_sge = 1; - qp_attr.qp_type = IBV_QPT_RAW_PACKET, + qp_attr.qp_type = IBV_QPT_RAW_PACKET; /* Do *NOT* enable this, completions events are managed per Tx burst. */ qp_attr.sq_sig_all = 0; qp_attr.pd = priv->sh->cdev->pd; diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 1de398982a..f354008a60 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -11132,12 +11132,12 @@ flow_tunnel_add_default_miss(struct rte_eth_dev *dev, (error, ENOMEM, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "invalid default miss RSS"); - ctx->action_rss.func = RTE_ETH_HASH_FUNCTION_DEFAULT, - ctx->action_rss.level = 0, - ctx->action_rss.types = priv->rss_conf.rss_hf, - ctx->action_rss.key_len = priv->rss_conf.rss_key_len, - ctx->action_rss.queue_num = priv->reta_idx_n, - ctx->action_rss.key = priv->rss_conf.rss_key, + ctx->action_rss.func = RTE_ETH_HASH_FUNCTION_DEFAULT; + ctx->action_rss.level = 0; + ctx->action_rss.types = priv->rss_conf.rss_hf; + ctx->action_rss.key_len = priv->rss_conf.rss_key_len; + ctx->action_rss.queue_num = priv->reta_idx_n; + ctx->action_rss.key = priv->rss_conf.rss_key; ctx->action_rss.queue = ctx->queue; if (!priv->reta_idx_n || !priv->rxqs_n) return rte_flow_error_set diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index bcce1597e2..1564bd7cbe 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -18903,7 +18903,7 @@ flow_dv_create_mtr_tbls(struct rte_eth_dev *dev, } } /* Create default matcher in drop table. */ - matcher.tbl = mtrmng->drop_tbl[domain], + matcher.tbl = mtrmng->drop_tbl[domain]; tbl_data = container_of(mtrmng->drop_tbl[domain], struct mlx5_flow_tbl_data_entry, tbl); if (!mtrmng->def_matcher[domain]) { diff --git a/drivers/net/mlx5/mlx5_nta_split.c b/drivers/net/mlx5/mlx5_nta_split.c index 6a85ab7fd1..c95da56d72 100644 --- a/drivers/net/mlx5/mlx5_nta_split.c +++ b/drivers/net/mlx5/mlx5_nta_split.c @@ -345,8 +345,8 @@ flow_nta_mreg_create_cb(void *tool_ctx, void *cb_ctx) /* (match REG 'tag') or all. */ items[1].type = RTE_FLOW_ITEM_TYPE_END; /* (Mark) or void + copy to Rx meta + jump to the MREG_ACT_TABLE_GROUP. */ - actions[1].type = RTE_FLOW_ACTION_TYPE_MODIFY_FIELD, - actions[1].conf = &rx_meta, + actions[1].type = RTE_FLOW_ACTION_TYPE_MODIFY_FIELD; + actions[1].conf = &rx_meta; actions[2].type = RTE_FLOW_ACTION_TYPE_JUMP; actions[2].conf = &jump; actions[3].type = RTE_FLOW_ACTION_TYPE_END; -- 2.51.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] net/mlx5: fix unnecessary comma compilation warnings 2025-10-29 9:55 ` [PATCH 2/2] net/mlx5: " Gregory Etelson @ 2025-10-29 13:29 ` Dariusz Sosnowski 0 siblings, 0 replies; 5+ messages in thread From: Dariusz Sosnowski @ 2025-10-29 13:29 UTC (permalink / raw) To: Gregory Etelson Cc: dev, mkashani, rasland, stable, Viacheslav Ovsiienko, Bing Zhao, Ori Kam, Suanming Mou, Matan Azrad, Rongwei Liu, Michael Baum, Li Zhang On Wed, Oct 29, 2025 at 11:55:04AM +0200, Gregory Etelson wrote: > The patch fixes compilation warnings produced by clang -Wcomma option. > > Bugzilla ID: 1810 > Fixes: 630a587bfb37 ("net/mlx5: support matching on VXLAN reserved field") > Fixes: 86d259cec852 ("net/mlx5: separate Tx queue object creations") > Fixes: bc1d90a3cf6f ("net/mlx5: fix build with Direct Verbs disabled") > Fixes: 444320186393 ("net/mlx5: support meter creation with policy") > Fixes: 821a6a5cc495 ("net/mlx5: add metadata split for compatibility") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings 2025-10-29 9:55 [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings Gregory Etelson 2025-10-29 9:55 ` [PATCH 2/2] net/mlx5: " Gregory Etelson @ 2025-10-29 13:25 ` Dariusz Sosnowski 2025-11-02 7:31 ` Raslan Darawsheh 2 siblings, 0 replies; 5+ messages in thread From: Dariusz Sosnowski @ 2025-10-29 13:25 UTC (permalink / raw) To: Gregory Etelson Cc: dev, mkashani, rasland, stable, Matan Azrad, Viacheslav Ovsiienko, Moti Haimovsky On Wed, Oct 29, 2025 at 11:55:03AM +0200, Gregory Etelson wrote: > The patch fixes compilation warnings produced by clang -Wcomma option. > > Bugzilla ID: 1810 > Fixes: ba576975a89b ("net/mlx4: support hardware TSO") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings 2025-10-29 9:55 [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings Gregory Etelson 2025-10-29 9:55 ` [PATCH 2/2] net/mlx5: " Gregory Etelson 2025-10-29 13:25 ` [PATCH 1/2] net/mlx4: " Dariusz Sosnowski @ 2025-11-02 7:31 ` Raslan Darawsheh 2 siblings, 0 replies; 5+ messages in thread From: Raslan Darawsheh @ 2025-11-02 7:31 UTC (permalink / raw) To: Gregory Etelson, dev Cc: mkashani, stable, Matan Azrad, Viacheslav Ovsiienko, Moti Haimovsky Hi On 29/10/2025 11:55 AM, Gregory Etelson wrote: > The patch fixes compilation warnings produced by clang -Wcomma option. > > Bugzilla ID: 1810 > Fixes: ba576975a89b ("net/mlx4: support hardware TSO") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> Series applied to next-net-mlx, Kindest regards Raslan Darawsheh ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-11-02 7:31 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2025-10-29 9:55 [PATCH 1/2] net/mlx4: fix unnecessary comma compilation warnings Gregory Etelson 2025-10-29 9:55 ` [PATCH 2/2] net/mlx5: " Gregory Etelson 2025-10-29 13:29 ` Dariusz Sosnowski 2025-10-29 13:25 ` [PATCH 1/2] net/mlx4: " Dariusz Sosnowski 2025-11-02 7:31 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).