From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Xia, Chenbo" <chenbo.xia@intel.com>,
Adrian Moreno <amorenoz@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Ye, Xiaolong" <xiaolong.ye@intel.com>,
"shahafs@mellanox.com" <shahafs@mellanox.com>,
"matan@mellanox.com" <matan@mellanox.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>
Cc: "jasowang@redhat.com" <jasowang@redhat.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v3 1/8] vhost: fix virtio ready flag check
Date: Wed, 8 Jul 2020 15:22:44 +0100 [thread overview]
Message-ID: <7f88eebd-b74d-f994-e378-3f60a28b5613@intel.com> (raw)
In-Reply-To: <MN2PR11MB4063FA5A4410447665B658269C660@MN2PR11MB4063.namprd11.prod.outlook.com>
On 7/7/2020 4:21 AM, Xia, Chenbo wrote:
>
>> -----Original Message-----
>> From: Adrian Moreno <amorenoz@redhat.com>
>> Sent: Monday, July 6, 2020 7:25 PM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Ye, Xiaolong
>> <xiaolong.ye@intel.com>; shahafs@mellanox.com; matan@mellanox.com;
>> maxime.coquelin@redhat.com; Wang, Xiao W <xiao.w.wang@intel.com>;
>> viacheslavo@mellanox.com
>> Cc: jasowang@redhat.com; lulu@redhat.com; stable@dpdk.org
>> Subject: [PATCH v3 1/8] vhost: fix virtio ready flag check
>>
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> Before checking whether the device is ready is done a check on whether the
>> RUNNING flag is set. Then the READY flag is set if virtio_is_ready() returns true.
>>
>> While it seems to not cause any issue, it makes more sense to check whether the
>> READY flag is set and not the RUNNING one.
>>
>> Fixes: c0674b1bc898 ("vhost: move the device ready check at proper place")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> lib/librte_vhost/vhost_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index
>> 6039a8fdb..5750dde6d 100644
>> --- a/lib/librte_vhost/vhost_user.c
>> +++ b/lib/librte_vhost/vhost_user.c
>> @@ -2825,7 +2825,7 @@ vhost_user_msg_handler(int vid, int fd)
>> }
>>
>>
>> - if (!(dev->flags & VIRTIO_DEV_RUNNING) && virtio_is_ready(dev)) {
>> + if (!(dev->flags & VIRTIO_DEV_READY) && virtio_is_ready(dev)) {
>> dev->flags |= VIRTIO_DEV_READY;
>>
>> if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
>> --
>> 2.26.2
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-07-08 14:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200706112452.1474533-1-amorenoz@redhat.com>
2020-07-06 11:24 ` Adrian Moreno
2020-07-07 3:21 ` Xia, Chenbo
2020-07-08 14:22 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f88eebd-b74d-f994-e378-3f60a28b5613@intel.com \
--to=ferruh.yigit@intel.com \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jasowang@redhat.com \
--cc=lulu@redhat.com \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
--cc=xiao.w.wang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).