From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AD95A0540 for ; Mon, 3 Oct 2022 17:00:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30CD4410FB; Mon, 3 Oct 2022 17:00:12 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by mails.dpdk.org (Postfix) with ESMTP id D8D5740695; Mon, 3 Oct 2022 17:00:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmGQT8ZKp7T99XHsPszhSrRpVgrYrOeF0SyrIxvqEBhfz4BSWihbWyd059exhwdXnjdUrdwpPhEq7z8xhsKi6DJpPSHqj3ncKL8Q8bU0C8DohI2oSlw4zdI8lvA0631McUm3lprxFvP/Ygz4uoH6m8M6iJXzoCMS/GZG8GdmB0IQQ927cF8Cq0mV24u5rKEWZQOz5UicOfFZ7cRDuVsCO16iFEtDo97/Y5dkqmv4F36OQeF+3t+b1xMEq0136499ja2GBWRnP7i9epzjveQEZkbEHSqN/hJ9bF7fQhrZkdyChRkkHpaCQU2sQK60yXeVN2cdl/1NC0A9YsHj2Qhu0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0qVg0O5/I1BEeKhCF63XpU68o2l3052Gxpby/QWrHU=; b=O6XfDO1k7dMLulkhLEFz/tQiooAU6fylIcBItVbSuCwUC1jt8pPjLX07xdqzUHpoNnrNjvwavBVGTKEbDhMlWM8ujWJRaziKRz0uYhsQlhz3isQRjd3hdCto+/mZCyzC0DXyv01HdpMLOh8BXO4GfBOcQHhQo3A9LoXx2njYJbNpr3TFjjFgeM1P+UcSJE7p6/Yiddj/k62NwmjIuhh/rkQrDU997Fg1G/VddGQ5/Z6anYVIYQYkU0KjGhhOwEXTgvnn+KLf9Qx3GyeiXNrinLgG8kTHlBVLehBZCy+h4ArouO7m6s8+31m8RILOzMY9m3L1eUl+5qOGdFbz1ejzIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=fail (p=quarantine sp=quarantine pct=100) action=quarantine header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0qVg0O5/I1BEeKhCF63XpU68o2l3052Gxpby/QWrHU=; b=h/4uUT28R4ibFgLjYpjpiR+eywQczrpNodaw0sur7+fHOCU+sBt39rcheUsdIYsc93YZkRrMPs1f0LyNCg9hgstvBPuqHJg4QOJtzG/ROKh03MNDqKMLDqsmE+Ki0+DAHrBSmsDCjIbmE24ptm1TGQRKMx052KefBTIn7UwXyYE= Received: from DM6PR05CA0053.namprd05.prod.outlook.com (2603:10b6:5:335::22) by BL3PR02MB8066.namprd02.prod.outlook.com (2603:10b6:208:359::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.24; Mon, 3 Oct 2022 15:00:07 +0000 Received: from DM3NAM02FT055.eop-nam02.prod.protection.outlook.com (2603:10b6:5:335:cafe::84) by DM6PR05CA0053.outlook.office365.com (2603:10b6:5:335::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.3 via Frontend Transport; Mon, 3 Oct 2022 15:00:07 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 149.199.80.198) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=fail action=quarantine header.from=amd.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning amd.com discourages use of 149.199.80.198 as permitted sender) Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT055.mail.protection.outlook.com (10.13.5.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5676.17 via Frontend Transport; Mon, 3 Oct 2022 15:00:07 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 3 Oct 2022 16:00:06 +0100 Received: from smtp.xilinx.com (172.21.105.198) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Mon, 3 Oct 2022 16:00:05 +0100 Envelope-to: yidingx.zhou@intel.com, stephen@networkplumber.org, qi.z.zhang@intel.com, dev@dpdk.org, anatoly.burakov@intel.com, xingguang.he@intel.com, stable@dpdk.org Received: from [10.71.194.74] (port=64548) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1ofMvN-0000Dt-TB; Mon, 03 Oct 2022 16:00:05 +0100 Message-ID: <7f8a555b-c53d-2393-878c-0b388492284b@amd.com> Date: Mon, 3 Oct 2022 16:00:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] net/pcap: fix timeout of stopping device Content-Language: en-US To: "Zhou, YidingX" , Stephen Hemminger , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Burakov, Anatoly" , "He, Xingguang" , "stable@dpdk.org" References: <20220825072041.10768-1-yidingx.zhou@intel.com> <20220906080511.46088-1-yidingx.zhou@intel.com> <20220906075737.2fb429a5@hermes.local> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM3NAM02FT055:EE_|BL3PR02MB8066:EE_ X-MS-Office365-Filtering-Correlation-Id: 0748c565-7add-4b59-2956-08daa54ff600 X-MS-Exchange-SenderADCheck: 2 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2HPp/a0jOP2mBN3UAV7y5rseZasddysstWEmckLm3zeKRlj3fvvCKUHmkBPKpyxT9dLQPIsaKLLZtmhwZdhMd4PgXGu4i//+h/YqLtTLP+lOQ60V9m5t3ymgKvexAsb1DRg6EI+4QOh2/7nR9CTRxzAZbsM3skr+cYixZcpuIJgshEBCiPiFE40A4sfBlF8gj39OFykZVyLAd59ghVTnzlmQiH3k7qoIGeEJAx613Bq+eYIi825SS9D2uVX0346YZTLKX0vDtZgfNLzwoqY67BAE3ny7fAK/rOnELtN4O76omYsNn+B+e4V3+O9nAn03qToX3msSVHw8ZbN4/3dcwDULLKd4GL5KIRYIWXPhiqR2gowROI4abXkisGECpfKY1WcySTQv9Blya2qL5ObYlP6MqQik3uKGEYjgBpfu7gdN523nSufMuN6Ra4ERvOy7hQ/yJNVLBZxXK1wpmUvCIi/2lGyAXY9IxX75Zlh2ZcnzBHG5IHsz12u09umYuc0e2eAbvUvDn4hRNkL6ccccXXcUC3ul4yiYND5Aa7qoJuktlxl5Av/1jnGfJ7f9IPpXFlhgR2TTZzsf2wnRn+PIgbAQJcQ/CCzSkvjfs1N+syak3AuslhnNBAwcspzxGDoGbvRMZMRNTQ+tq32SxZ9Ru3KHGVjgX+/hfUqWFI1dbxaWhjcR0ns8+Ff2qRGgripkHWg2C/04VbROzQe0u7Fj/BipdIMU2WRI4XlTzjE3oYVb+t/gY+7kVSz8DwPM37bNAW256IG0G7b0Sbt0xpQqmUKY5jHONBqbDOtkUzL6MFDdngFDsvLnyxetA/Hc1Ssevb9g/e2aiGA8xYsuE4ayNA== X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230022)(4636009)(396003)(39860400002)(376002)(346002)(136003)(451199015)(46966006)(40470700004)(31696002)(82310400005)(36756003)(110136005)(44832011)(498600001)(70586007)(8676002)(86362001)(70206006)(41300700001)(8936002)(54906003)(5660300002)(9786002)(4326008)(40480700001)(35950700001)(356005)(82740400003)(53546011)(40460700003)(316002)(7636003)(2616005)(336012)(2906002)(83380400001)(47076005)(26005)(31686004)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2022 15:00:07.2051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0748c565-7add-4b59-2956-08daa54ff600 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT055.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR02MB8066 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 9/21/2022 8:14 AM, Zhou, YidingX wrote: > > >> -----Original Message----- >> From: Stephen Hemminger >> Sent: Tuesday, September 6, 2022 10:58 PM >> To: Zhou, YidingX >> Cc: dev@dpdk.org; Zhang, Qi Z ; Burakov, Anatoly >> ; He, Xingguang ; >> stable@dpdk.org >> Subject: Re: [PATCH v2] net/pcap: fix timeout of stopping device >> >> On Tue, 6 Sep 2022 16:05:11 +0800 >> Yiding Zhou wrote: >> >>> The pcap file will be synchronized to the disk when stopping the device. >>> It takes a long time if the file is large that would cause the 'detach >>> sync request' timeout when the device is closed under multi-process >>> scenario. >>> >>> This commit fixes the issue by using alarm handler to release dumper. >>> >>> Fixes: 0ecfb6c04d54 ("net/pcap: move handler to process private") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Yiding Zhou >> >> >> I think you need to redesign the handshake if this the case. >> Forcing 30 second delay at the end of all uses of pcap is not acceptable. > > @Zhang, Qi Z Do we need to redesign the handshake to fix this? Hi Yiding, Your approach works, but Stephen's comment is to not add this delay by default, because this delay is not always required. Can you please provide more details on multi-process communication and call trace, to help us think about a solution to address this issue in a more generic way (not just for pcap but for any case device close takes more than multi-process timeout)?