From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83659A055A for ; Thu, 27 Feb 2020 11:26:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FAC33B5; Thu, 27 Feb 2020 11:26:35 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id A12733B5 for ; Thu, 27 Feb 2020 11:26:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582799193; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QdfjJPESUWoE88DoejriqbqdBV7lCQ6AVOAPmLn2n2g=; b=WLr24gqGvR5LN/ffFyToz4P3Zk1AY30EhqQGLFGY7A5VkV77rCoA1gLko8s+nGyx9M1u6f Mp6uGejpEtAkhdNlzC8V72+waXDnzjBnF7GtbkTw6WXAoWXpusGAKgzVkD3JoqVpLNbBzJ il10hfctZ+IpUL45ey15sayoukKgtIM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-WQg910W4NoeEYKrkAMy0NA-1; Thu, 27 Feb 2020 05:26:28 -0500 X-MC-Unique: WQg910W4NoeEYKrkAMy0NA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 148C0107ACC9; Thu, 27 Feb 2020 10:26:27 +0000 (UTC) Received: from [10.33.36.123] (unknown [10.33.36.123]) by smtp.corp.redhat.com (Postfix) with ESMTP id D6404194B2; Thu, 27 Feb 2020 10:26:22 +0000 (UTC) To: luca.boccassi@gmail.com Cc: dpdk stable References: <20200217174546.25334-54-luca.boccassi@gmail.com> <20200227093402.17690-1-luca.boccassi@gmail.com> <20200227093402.17690-42-luca.boccassi@gmail.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <7fe4e9ef-5102-0469-dfe5-5fef70dc9250@redhat.com> Date: Thu, 27 Feb 2020 10:26:20 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200227093402.17690-42-luca.boccassi@gmail.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] patch 'devtools: add fixes flag to commit listing' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 27/02/2020 09:34, luca.boccassi@gmail.com wrote: > Hi, >=20 > FYI, your patch has been queued to stable release 19.11.1 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 02/29/20. So please > shout if anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for reba= sing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Thanks. >=20 > Luca Boccassi >=20 Hi Luca, I don't think there's a need to backport this. It won't do any harm, but not sure anyone would be running git-log-fixes on the stable branch, considering the fix tags reference master and stable tags will have been removed. No objection though, if you have a case and want to take it. thanks, Kevin. > --- > From 13c926a42ad9634ac46aa7b6eec1d5bd7c72e71b Mon Sep 17 00:00:00 2001 > From: Kevin Traynor > Date: Mon, 3 Feb 2020 15:59:55 +0000 > Subject: [PATCH] devtools: add fixes flag to commit listing >=20 > [ upstream commit 8070d8fecb4ec263ce875d34e8093b973f250170 ] >=20 > During backporting, if the fixes or stable tag are missing, > it usually requires some investigation by stable maintainer > as to why. >=20 > The presence of a fixes tag may be known from whether the > originating release of the issue is printed at the end of the > line but with variable line lengths and nested partial fixes > it doesn't catch the eye. >=20 > When there are a large amount of commits, adding an aligned column > indicating the presence of a fixes tag beside the stable one makes > it easier to quickly see the patches requiring further investigation. >=20 > e.g. > 20.02 8f33cbcfa S F net/i40e/base: fix buffer address (16.04) > 20.02 4b3da9415 S F net/i40e/base: fix error message (1.7.0) > 20.02 1da546c39 - F net/i40e/base: fix missing link modes (17.08) > 20.02 79bfe7808 S F net/i40e/base: fix Tx descriptors number (1.7.0) > 20.02 50126939c - F net/i40e/base: fix retrying logic (18.02) > 20.02 dcd05da0a S F app/testpmd: fix GENEVE flow item (18.02) > 20.02 b0b9fdad2 S - net/bnx2x: support secondary process (N/A) > 20.02 f8279f47d S F net/netvsc: fix crash in secondary process (18.08) >=20 > Signed-off-by: Kevin Traynor > --- > devtools/git-log-fixes.sh | 16 ++++++++++++++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/devtools/git-log-fixes.sh b/devtools/git-log-fixes.sh > index e37ee22600..6d468d6731 100755 > --- a/devtools/git-log-fixes.sh > +++ b/devtools/git-log-fixes.sh > @@ -94,11 +94,23 @@ stable_tag () # > =09fi > } > =20 > +# print a marker for fixes tag presence > +fixes_tag () # > +{ > + if git log --format=3D'%b' -1 $1 | grep -qi '^Fixes: *' ; then > + echo 'F' > + else > + echo '-' > + fi > +} > + > git log --oneline --reverse $range | > while read id headline ; do > =09origins=3D$(origin_filter $id) > =09stable=3D$(stable_tag $id) > -=09[ "$stable" =3D "S" ] || [ -n "$origins" ] || echo "$headline" | grep= -q fix || continue > +=09fixes=3D$(fixes_tag $id) > +=09[ "$stable" =3D "S" ] || [ "$fixes" =3D "F" ] || [ -n "$origins" ] ||= \ > +=09=09echo "$headline" | grep -q fix || continue > =09version=3D$(commit_version $id) > =09if [ -n "$origins" ] ; then > =09=09origver=3D"$(origin_version $origins)" > @@ -108,5 +120,5 @@ while read id headline ; do > =09else > =09=09origver=3D'N/A' > =09fi > -=09printf '%s %7s %s %s (%s)\n' $version $id $stable "$headline" "$origv= er" > +=09printf '%s %7s %s %s %s (%s)\n' $version $id $stable $fixes "$headlin= e" "$origver" > done >=20