Re: [dpdk-stable] [PATCH v4 3/6] power: rename public structs

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 1/21/2021 5:21 PM, David Hunt wrote:
> From: Bruce Richardson <bruce.richardson@intel.com>
> 
> rename the public structs to have an rte_power_ prefix and
> add them to version.map in experimental section.
> 
> Fixes: 210c383e247b ("power: packet format for vm power management")
> Fixes: cd0d5547e873 ("power: vm communication channels in guest")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> 

<...>

> diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map
> index 69ca9af61..13f0af3b2 100644
> --- a/lib/librte_power/version.map
> +++ b/lib/librte_power/version.map
> @@ -34,4 +34,8 @@ EXPERIMENTAL {
>   	rte_power_guest_channel_receive_msg;
>   	rte_power_poll_stat_fetch;
>   	rte_power_poll_stat_update;
> +
> +	# added in 21.02
> +	rte_power_guest_channel_receive_msg;
> +	rte_power_guest_channel_send_msg;
>   };

These two new symbols are already in the .map file, which is causing a build 
error [1], need to remove the duplicate.

And one of the above symbols is already in the non-experimental section, I guess 
that was a mistake but just to double check, we are not downgrading an existing 
mature API to experimental API, right?



[1]
https://travis-ci.com/github/ovsrobot/dpdk/jobs/484119344