From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77DE9A0471 for ; Mon, 12 Aug 2019 20:49:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3EF641D7; Mon, 12 Aug 2019 20:49:56 +0200 (CEST) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50076.outbound.protection.outlook.com [40.107.5.76]) by dpdk.org (Postfix) with ESMTP id E34EC1D7 for ; Mon, 12 Aug 2019 20:49:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVgl0CqQuWoOk0nmXfic9IelyrOkfdum9Ho7ZG5C9q23YMVSo11U3WpfuPcuQErkFgKIfYOeO2gCXUfCfY5RTmYYf0ydePGsIyG7z2wgMAjDe144sAahLTF2Ydyq9LTK5Gfu6K87ZxBaCpFFb63nMlcqC8MYlUwExt05WiIoYKwFMMqZy/hnkerBdc9pKhLl+mMsHV66kMtY9H+FgAOXQxGz0WeQVoCfTVzTQ7BsjXIL9M4K1bSO+4dgs5SYF6pJMfI611NHvl3h+PLeBHGRmV93jCMDMj7KXa66pJspum6wnjKVxpxPdam6d+1HCW3cR73eAkAP6T9kSmfi3M7JWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iSWjGTe0oFDe0aaNqJ4KW9jadxizt8A0smxpwdCUDPA=; b=TywvEPK/J0J2WHskKA1aDJe/4paTFxuzeze91QVugRuHsPQdpiaR3VmAGyRXYRi8vB/iTD9X8cXoov7dQkqSY5uZcMnEh1KGymYv75xq2F492zTXy447LVpFmecmlZq0087WWxXSiui3uFPPwDYjYPUt42HFsdBx//WkEIvPVrRms+AO8/xSDFE3zjEFVIizXyY/UaXBCnRfHgwHGJYrYQvNrn3mMoCsyLW6p1RL4nejlh57jUxZG+uaAWG0Np+BwmKbj7bVE/QpHiB/aXWSxsJq6jxLxK9BChjNWns6n0yKQ2rW8hyVbaXVHnkOpKWE5xsYGHdgdAL4fJ6cwVw+Yw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iSWjGTe0oFDe0aaNqJ4KW9jadxizt8A0smxpwdCUDPA=; b=XWGzTF5Hz/C4capqQP+2L+hjHPWR2UKD4Obt3EcNVngoVbMBUTAgDuShER5CI+sXomPiVfXZ9gxZ+4RE7uQteD6o8BqfjL2kTa+NOktAaiVCKMzNMI/Gc4V5s76Amc8EPQ7FU6tMU2XsCL3W+9lIedIddF/ZFY8GJBQT9lxeClQ= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB4011.eurprd05.prod.outlook.com (52.134.68.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.14; Mon, 12 Aug 2019 18:49:52 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::589a:a9d4:5426:d194]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::589a:a9d4:5426:d194%6]) with mapi id 15.20.2157.022; Mon, 12 Aug 2019 18:49:52 +0000 From: Yongseok Koh To: Tiwei Bie CC: "stable@dpdk.org" , "maxime.coquelin@redhat.com" , "zhihong.wang@intel.com" Thread-Topic: [PATCH 17.11] net/virtio: add barrier in interrupt enable Thread-Index: AQHVTqM4DqF0qg9jGkefFbMT1+3CNab34CwA Date: Mon, 12 Aug 2019 18:49:52 +0000 Message-ID: <80CEC349-D88C-4481-87DD-CD2C1F0F7052@mellanox.com> References: <20190809110904.31669-1-tiwei.bie@intel.com> In-Reply-To: <20190809110904.31669-1-tiwei.bie@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6db1fe06-9ab8-400d-cfe8-08d71f55dc8c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4011; x-ms-traffictypediagnostic: DB3PR0502MB4011: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:151; x-forefront-prvs: 012792EC17 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39860400002)(366004)(136003)(346002)(376002)(199004)(189003)(4326008)(6246003)(446003)(478600001)(8676002)(2616005)(81166006)(11346002)(6486002)(66066001)(229853002)(5660300002)(81156014)(316002)(2906002)(14454004)(54906003)(486006)(6436002)(8936002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(91956017)(476003)(36756003)(6512007)(6506007)(256004)(102836004)(3846002)(6116002)(86362001)(53546011)(25786009)(99286004)(186003)(53936002)(6916009)(71190400001)(71200400001)(76176011)(33656002)(7736002)(26005)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4011; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: DCbg/zL6GNXTZmhgTjGS6yjfNQpPdKmNLAsAy5fi1nmJU/uv+hqJnX+0owfp+mgRn4UMUAa1U7yB6zCm75eiv/fdcLIsSCLvXtTWPDu6ygsmVk7uE0v285fWLqKJaMx0eVnTUbqlOEX+0yM3EAvDGRlV5cCQW64E+koXRJSb62wIAF+pLryp/6GsbK+3ldOwiVOnD2nC7ZtK3C/RYaPfei4f5TBDvKI1EHe8BTMLqPjS/w+Xg1+nAdQkXVWEGhe2NdENODDmg/E3vrWIP2ceTvt/yl8Osq3b1csaJuTaZ4ITzMXs18oTs7WQpkiJAJZ4b9dSKnRgqMAcsn0CATS6JkT93rP8EcHbxStSlNIR8zYo5urIxGDN4RXbbyC4V4ZyEaFLkqlLQNS5IQbOUKL/vv9oAyeSr/uI3SR6nhhzoqg= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <4AF380DF2E59B1419D1A48B0ED4CCE61@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6db1fe06-9ab8-400d-cfe8-08d71f55dc8c X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2019 18:49:52.7032 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zgWz9E5i74UWYVRVqK4vyq92ERt/APpzQhKQGwHSwuLdm2qFtVLtX2Kp3ybP7EJGlEfQEU7QwQurOx6CH9vFQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4011 Subject: Re: [dpdk-stable] [PATCH 17.11] net/virtio: add barrier in interrupt enable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > On Aug 9, 2019, at 4:09 AM, Tiwei Bie wrote: >=20 > [ backported from upstream commit 8f66bc4ac3c0d4a11252d860f495abd806aa871= f ] >=20 > Typically, after enabling Rx interrupt, a check should be done > to make sure that there is no new incoming packets before going > to sleep. So a barrier is needed to make sure that any following > check won't happen before the interrupt is actually enabled. >=20 > Fixes: c056be239db5 ("net/virtio: add Rx interrupt enable/disable functio= ns") >=20 > Signed-off-by: Tiwei Bie > Reviewed-by: Maxime Coquelin > --- applied to stable/17.11 thanks, Yongseok > drivers/net/virtio/virtio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt= io_ethdev.c > index b3e55ff3b..1bdf37e4b 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -739,6 +739,7 @@ virtio_dev_rx_queue_intr_enable(struct rte_eth_dev *d= ev, uint16_t queue_id) > struct virtqueue *vq =3D rxvq->vq; >=20 > virtqueue_enable_intr(vq); > + virtio_mb(); > return 0; > } >=20 > --=20 > 2.17.1 >=20