* [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option [not found] ` <20210323101928.2403-1-david.marchand@redhat.com> @ 2021-03-23 10:19 ` David Marchand 2021-03-23 15:54 ` Thomas Monjalon 0 siblings, 1 reply; 5+ messages in thread From: David Marchand @ 2021-03-23 10:19 UTC (permalink / raw) To: dev Cc: arybchenko, l.wojciechow, stable, Bruce Richardson, Dmitry Kozlyuk, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Keith Wiles, Ranjit Menon --log-level option is handled early, no need to reevaluate it later in EAL init. Before: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info After: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info Fixes: 6c7216eefd63 ("eal: fix log level of early messages") Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> --- lib/librte_eal/freebsd/eal.c | 4 ++++ lib/librte_eal/linux/eal.c | 4 ++++ lib/librte_eal/windows/eal.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c index 62320d610f..817961d8d6 100644 --- a/lib/librte_eal/freebsd/eal.c +++ b/lib/librte_eal/freebsd/eal.c @@ -521,6 +521,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c index 9ffb4b3314..8070e0f632 100644 --- a/lib/librte_eal/linux/eal.c +++ b/lib/librte_eal/linux/eal.c @@ -704,6 +704,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 2fc3d6141c..e3b6a6ea61 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -149,6 +149,10 @@ eal_parse_args(int argc, char **argv) return -1; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { -- 2.23.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option 2021-03-23 10:19 ` [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option David Marchand @ 2021-03-23 15:54 ` Thomas Monjalon 2021-03-24 9:45 ` Lukasz Wojciechowski 0 siblings, 1 reply; 5+ messages in thread From: Thomas Monjalon @ 2021-03-23 15:54 UTC (permalink / raw) To: David Marchand Cc: dev, stable, arybchenko, l.wojciechow, Bruce Richardson, Dmitry Kozlyuk, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Keith Wiles, Ranjit Menon 23/03/2021 11:19, David Marchand: > --log-level option is handled early, no need to reevaluate it later in > EAL init. > > Before: > $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ > --log-level=lib.eal:debug \ > --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ > |& grep -i logtype.level > > EAL: lib.eal logtype level changed from info to debug > EAL: lib.ethdev logtype level changed from info to debug > EAL: lib.ethdev logtype level changed from debug to info > EAL: lib.ethdev logtype level changed from info to debug > EAL: lib.ethdev logtype level changed from debug to info > > After: > $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ > --log-level=lib.eal:debug \ > --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ > |& grep -i logtype.level > > EAL: lib.eal logtype level changed from info to debug > EAL: lib.ethdev logtype level changed from info to debug > EAL: lib.ethdev logtype level changed from debug to info > > Fixes: 6c7216eefd63 ("eal: fix log level of early messages") > Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option 2021-03-23 15:54 ` Thomas Monjalon @ 2021-03-24 9:45 ` Lukasz Wojciechowski 0 siblings, 0 replies; 5+ messages in thread From: Lukasz Wojciechowski @ 2021-03-24 9:45 UTC (permalink / raw) To: Thomas Monjalon, David Marchand Cc: dev, stable, arybchenko, Bruce Richardson, Dmitry Kozlyuk, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Keith Wiles, Ranjit Menon W dniu 23.03.2021 o 16:54, Thomas Monjalon pisze: > 23/03/2021 11:19, David Marchand: >> --log-level option is handled early, no need to reevaluate it later in >> EAL init. >> >> Before: >> $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ >> --log-level=lib.eal:debug \ >> --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ >> |& grep -i logtype.level >> >> EAL: lib.eal logtype level changed from info to debug >> EAL: lib.ethdev logtype level changed from info to debug >> EAL: lib.ethdev logtype level changed from debug to info >> EAL: lib.ethdev logtype level changed from info to debug >> EAL: lib.ethdev logtype level changed from debug to info >> >> After: >> $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ >> --log-level=lib.eal:debug \ >> --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ >> |& grep -i logtype.level >> >> EAL: lib.eal logtype level changed from info to debug >> EAL: lib.ethdev logtype level changed from info to debug >> EAL: lib.ethdev logtype level changed from debug to info >> >> Fixes: 6c7216eefd63 ("eal: fix log level of early messages") >> Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing") >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand <david.marchand@redhat.com> > Acked-by: Thomas Monjalon <thomas@monjalon.net> > > Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20210324103213.29922-1-david.marchand@redhat.com>]
* [dpdk-stable] [PATCH v2 3/3] eal: fix evaluation of log level option [not found] ` <20210324103213.29922-1-david.marchand@redhat.com> @ 2021-03-24 10:32 ` David Marchand 0 siblings, 0 replies; 5+ messages in thread From: David Marchand @ 2021-03-24 10:32 UTC (permalink / raw) To: dev Cc: arybchenko, l.wojciechow, stable, Thomas Monjalon, Bruce Richardson, Dmitry Kozlyuk, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Keith Wiles, Ranjit Menon --log-level option is handled early, no need to reevaluate it later in EAL init. Before: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info After: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info Fixes: 6c7216eefd63 ("eal: fix log level of early messages") Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> --- lib/librte_eal/freebsd/eal.c | 4 ++++ lib/librte_eal/linux/eal.c | 4 ++++ lib/librte_eal/windows/eal.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c index 62320d610f..817961d8d6 100644 --- a/lib/librte_eal/freebsd/eal.c +++ b/lib/librte_eal/freebsd/eal.c @@ -521,6 +521,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c index 9ffb4b3314..8070e0f632 100644 --- a/lib/librte_eal/linux/eal.c +++ b/lib/librte_eal/linux/eal.c @@ -704,6 +704,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 2fc3d6141c..e3b6a6ea61 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -149,6 +149,10 @@ eal_parse_args(int argc, char **argv) return -1; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { -- 2.23.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20210409110453.20078-1-david.marchand@redhat.com>]
* [dpdk-stable] [PATCH v3 3/3] eal: fix evaluation of log level option [not found] ` <20210409110453.20078-1-david.marchand@redhat.com> @ 2021-04-09 11:04 ` David Marchand 0 siblings, 0 replies; 5+ messages in thread From: David Marchand @ 2021-04-09 11:04 UTC (permalink / raw) To: dev Cc: arybchenko, l.wojciechow, thomas, stable, Bruce Richardson, Dmitry Kozlyuk, Narcisa Ana Maria Vasile, Dmitry Malloy, Pallavi Kadam, Keith Wiles, Ranjit Menon --log-level option is handled early, no need to reevaluate it later in EAL init. Before: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info After: $ echo quit | ./build/app/test/dpdk-test --no-huge -m 512 \ --log-level=lib.eal:debug \ --log-level=lib.ethdev:debug --log-level=lib.ethdev:info \ |& grep -i logtype.level EAL: lib.eal logtype level changed from info to debug EAL: lib.ethdev logtype level changed from info to debug EAL: lib.ethdev logtype level changed from debug to info Fixes: 6c7216eefd63 ("eal: fix log level of early messages") Fixes: 1c806ae5c3ac ("eal/windows: support command line options parsing") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Tested-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> --- lib/librte_eal/freebsd/eal.c | 4 ++++ lib/librte_eal/linux/eal.c | 4 ++++ lib/librte_eal/windows/eal.c | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte_eal/freebsd/eal.c index 5544701f20..f4d1676754 100644 --- a/lib/librte_eal/freebsd/eal.c +++ b/lib/librte_eal/freebsd/eal.c @@ -521,6 +521,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c index baeead3301..ba19fc6347 100644 --- a/lib/librte_eal/linux/eal.c +++ b/lib/librte_eal/linux/eal.c @@ -705,6 +705,10 @@ eal_parse_args(int argc, char **argv) goto out; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { diff --git a/lib/librte_eal/windows/eal.c b/lib/librte_eal/windows/eal.c index 68a1fd1d21..41be20d89f 100644 --- a/lib/librte_eal/windows/eal.c +++ b/lib/librte_eal/windows/eal.c @@ -150,6 +150,10 @@ eal_parse_args(int argc, char **argv) return -1; } + /* eal_log_level_parse() already handled this option */ + if (opt == OPT_LOG_LEVEL_NUM) + continue; + ret = eal_parse_common_option(opt, optarg, internal_conf); /* common parser is not happy */ if (ret < 0) { -- 2.23.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-09 11:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200626114751.22523-1-david.marchand@redhat.com>
[not found] ` <20210323101928.2403-1-david.marchand@redhat.com>
2021-03-23 10:19 ` [dpdk-stable] [PATCH 3/3] eal: fix evaluation of log level option David Marchand
2021-03-23 15:54 ` Thomas Monjalon
2021-03-24 9:45 ` Lukasz Wojciechowski
[not found] ` <20210324103213.29922-1-david.marchand@redhat.com>
2021-03-24 10:32 ` [dpdk-stable] [PATCH v2 " David Marchand
[not found] ` <20210409110453.20078-1-david.marchand@redhat.com>
2021-04-09 11:04 ` [dpdk-stable] [PATCH v3 " David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).