From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>, Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: fix ignore return value Coverity issue
Date: Fri, 13 Nov 2020 15:29:02 +0100 [thread overview]
Message-ID: <8175137.iOmTMfLZip@thomas> (raw)
In-Reply-To: <20201105135837.GW1898@platinum>
05/11/2020 14:58, Olivier Matz:
> On Thu, Nov 05, 2020 at 01:51:14PM +0000, David Hunt wrote:
> > Coverity flags that rte_mempool_ops_dequeue_bulk() is called without
> > checking the return value.
> >
> > This ignoring is intentional, so this patch gets the return code, then
> > uses RTE_SET_USED so that Coverity will be happy.
> >
> > Coverity issue: 363744
> > Fixes: 449c49b93a6b ("mempool: support handler operations")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Hunt <david.hunt@intel.com>
>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
>
> Thanks David!
This patch is doing nothing else than shutting up Coverity.
Is there any value adding this comment in the code?
Would it be cleaner to mark it as false positive in Coverity itself?
prev parent reply other threads:[~2020-11-13 14:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 13:51 [dpdk-stable] " David Hunt
2020-11-05 13:58 ` Olivier Matz
2020-11-13 14:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8175137.iOmTMfLZip@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).