From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC76A034D for ; Thu, 10 Feb 2022 12:14:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBD9F41C3C; Thu, 10 Feb 2022 12:14:40 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id B41744013F; Thu, 10 Feb 2022 12:14:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644491678; x=1676027678; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=r+sKpztHoGAru8neYBjQp52TNX/m3JX7eEIzJawp8HA=; b=SPORNyZAxQ4H1FKvTxa7DxS33pnPXGDLoPQ4U9mkjAsv6t79DJIJSuTK 3gQN2HY8s+whN1U9CNtO0ueFmivesHts0Nbl+T81wbO0MCer6MA/0ItLg 3zLbHrkz14DCnrIw9a1pK3MqIq8ceT7Lun7pvy72lXrj/VyFXcOOG/BkL h19MGyWG84NDokDDU+RMLJWCTcWvWxyusKyMqlRvoCn9RvSKuiaz/R8rG 3ywms+jy6p6eb6UK0sSEPM/43CLfoJPFtSG+2xfQW/BuNSLqryHJDgke5 kEdhJQcPfAUmLe/1ciyRz+HDXECARwhEyrzEDE6kbBAPXojJCuvxzFxOx g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="335883958" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="335883958" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 03:14:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="482730528" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 10 Feb 2022 03:14:36 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 03:14:35 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 03:14:35 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 03:14:35 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.45) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 03:14:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GVWo9ExTizgSV4GburSayI039rf3wZGtHBsr/N3d9BXeYLuLXddwl0IW43RyZkQ3gm3OzUeEcS71AUczH9aS97D/VwHC2k8XU5I7aXiu6Wsg2iD+Q/taWhDqicSPzm+8HarGLz29Pup28O7qFLD/9HJaWBGr4H+N2G0sZyKdWHPOtpBAmn0eVDSNuluv7+g4QZej4Ulfl3UsVZ6jN2tmbGhZBGqMqkMkxqYnGwD3Q+LvLkv3LrZiDwr6ezA2/QoLtyMU9Gc4dpv7ZfCOUsCvw0Y/NL2BCvIdLQE8DHEqokoZzob0Hr+2IQF/MgI05VH1Tl0ssGasggEzC/lyOHAneg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhEOXgYLzw1y68UFT0TbH37QI5DkVZvvTuPFQCdzBB4=; b=l0XHlQ2mpPL/RykkiVs839Oua7OwPBuxEyGfW/1aVuz4kHbHoYsvpKXwLbnBjl960wLu907JRijeKN6YvdsSyApe+bLAc3bWZA8CzPzP+L4HBG9B48IS8cPSfMFmyqfM+RO+9Z01hqDrigP9H6AES3XmCFM/BkUVnuYeZLValIST+rxjJ2heioMAKWYvvobhE/T4Tu1Q60/ZW64L+kYLS8IOohpXy/h+CuRgRcqpWYiqOGDtWJGsuE8wR0kEqhUSiS02ZLHvEGTxGzdBFWZugbE5OYvm6OvSSbLuZoDBb5IjyvI+jtm4A8TFMOt6jXIRWBVIv98qyMsr18tf1lEAyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3299.namprd11.prod.outlook.com (2603:10b6:208:6f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.17; Thu, 10 Feb 2022 11:14:28 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 11:14:28 +0000 Message-ID: <81951260-ed5e-cfc4-c163-26e026c5fb8a@intel.com> Date: Thu, 10 Feb 2022 11:14:21 +0000 Subject: Re: [dpdk-dev] [PATCH] ethdev: remove unnecessary NULL check Content-Language: en-US To: Stephen Hemminger , Yunjian Wang CC: , , , , , References: <86e8c92e29214673983f4387dfc6a24338eae714.1644409051.git.wangyunjian@huawei.com> <20220209073246.1dae32be@hermes.local> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220209073246.1dae32be@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0079.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7cdd9b15-8b51-4287-c281-08d9ec8680b3 X-MS-TrafficTypeDiagnostic: BL0PR11MB3299:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2331; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uZ1sD1rxymoHymznXKTqOabE3W5hVTIEZ++uNxMfQcQUQGQ2r7fTGXWp5To2ouEZIRkchYx7eEsHW+Y/dqTtvllEVsTCT2EAI4hY6qdYG4NbYtpVH1sQDsDtu79wTXCdHzbEFHwzDK1eVVRx5K6XaIGZD0JGRG3Y5XrdbAoS1A1RTXElqQCLjT8RTgWaqFtR3d8buW5pJ4VELmrSH8wKK9nrc5o8izVv3gXThqhIVEPQaE4wDOqwtDOGY85b9y872bPrm7ZTPv8HyqAAHcJuIjhrsd2AFo54D5bUF/4e9A07SymzdhIki5aoMxMgBWOmCkJEaq10C2P36LBWyq7U6Uu+Z9MHRVhHN1+BgsShn+kWh0oftTsgokq2nrRudq/zqspg0aZSLdi/dm3Ulx+yI48cA5gtigIs6bfBYLZth2k5aWc/fTsfPp1ladYAqGueqmRHUEoelwzQnEyhJvB4AMqxnwedc0Iaqrhk8RHO34DEhvA7r/WVVk/YEYst7sA//7c1Iqf8L/Q46lHIi+j/OrELxYtxU0f5gWV8HhIXjIj3MpFHOVjhe45CMxyTJJviQNsycUDimwlMUNSCjoLdcZGajawIBho+JSv5Ga4h4MlvpKZekAPbw23ADHNDiWyGwXfeACQiH9Ar+dkGrylp/xdHYv9yaO7N0mXmOP0GaGg69j8gEF7Xc0sElDtS5rhts4iLpOr38BC4BcYtmU/1XQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(44832011)(53546011)(66946007)(2906002)(31696002)(86362001)(110136005)(26005)(55236004)(186003)(6512007)(6506007)(82960400001)(31686004)(4744005)(36756003)(6666004)(8676002)(6486002)(4326008)(2616005)(38100700002)(508600001)(66556008)(66476007)(8936002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzdKV3NiK2tiZElJVnREanNGNEozVGZkL0tjYXdIcTJjVjgyZlMyaHRmZTBE?= =?utf-8?B?OHA5aUQ5KzE0UnYxdExZdHByZ2VVVWdPU05WQ3d4aVc1bkpnRWZPK0ZaMDJZ?= =?utf-8?B?cmJuZ0RRa1d5MU1ibDl0bmsya2lsL0NFdFhkaDdUZS9odU14aUIwdVczSEZM?= =?utf-8?B?VGhhUllhcUVFbXBFN3crVDQxRVU0eDNyQ2M2V1lyU2s3WUJqS2hSTzZ4U3R5?= =?utf-8?B?UDlENmpaTmFFcThmdjhYNmZ4MWZlaHltZkF6WDZMcmt0S0pHcklqUmZqNDNX?= =?utf-8?B?Y1dkdXA5dnAzVkJoTWhWZnN0VU1PRWZseDY0dTZLMUFLN0J0VUhOYVZpeUVr?= =?utf-8?B?UnNyMENWK0hIMkR5YTlYOEt4eVJ3Y2FTTFNZUUJiZWtheUZIckZ0SVpOdWU2?= =?utf-8?B?YTRNeDArckFDbmNRMEVKL1BETGFFRTNuNVptcENUYW1ZWlhROHRmeVFSNHZE?= =?utf-8?B?YkROUllkN0xQRS95UGFLQVlzcENFUGhkNXFxZ1JVSnBQcnFyKytQNGpXVkxV?= =?utf-8?B?cCtQUWZsWFpJTnZYaC9WUkdoUmkrT2RzU2tONVo1eUEvZzlsQnp0M3hBUjhZ?= =?utf-8?B?d1JjSmFQVWZTb2JMZTQxZGdNeXQ5WnBackxZdkpORlprR3NxeGNSVlU2b3dj?= =?utf-8?B?NW95c1BhdGY2bWlnTVoyU2EyeVRLSzl5YjdLdkZ4OHZjYUxXanZjWnBCdHJt?= =?utf-8?B?cjRCUVJqMWFhdEtHVEo2T2NBV2Y4dE1Kb3RjZDJVUFkrVENqN1E2ZDhyd09O?= =?utf-8?B?VzRETUdGbi9lLzRwaW9SYTYzRTZyTGJIaFNSOU1hNHp1TkhLUzhHU1JZelY3?= =?utf-8?B?Z0EramFhczEvNThWcUY5V1c1aG1sbDRyNFZVWWk3VU96N2hzUWxQa2E4dWZV?= =?utf-8?B?QTVKdTNJR2xtK0VZZndYVzR0VWc0cHdmUzZhdmpzRStLU3J3M0ZaNzIyOEVW?= =?utf-8?B?QkppanFycE9JSU94NUJsRlgyTDdROE5KclllQ2dlQkVWQ01lZ2Rqd3k2NDJr?= =?utf-8?B?dC9lYkdrY0RCN3RtYk5UTnloSzBVTXBiQWltRkxYYzBQSWR6ZUxmWlZRaW45?= =?utf-8?B?N0R3c1RJLytLZ1d1V2w0VUlhYmEvcm9BdlBUQmdXYitNMUdwSEEyWmk5aUdX?= =?utf-8?B?TVdmbXVQaUloYkdYN1VBbWxMNU9qRnludDlwZ3FHYTMwMnBXcE1zSVIyTTJa?= =?utf-8?B?a0ZNdENMNlQvWDlRdUh1VmtkWFJScVFFTkZqTFRFZjR5M3l4VjhxNnYyb1ZV?= =?utf-8?B?cEdKYk56UzNHWXlaYTVSaEFNeTBOSW92MlhxT2JJMVp4anJ0aDU4dVkwRXJn?= =?utf-8?B?cmxVVVZDeHQ1Yjk2Z0tHUXFvSjc5VG16Ry8vQllsOUN4OWhrMGRVV2szZXdC?= =?utf-8?B?QWxJYXI4ay9keUViT2FtN3h1eEpyVGZVcFVTMVd6ZEMrVHE1WEtFMUNQcUtj?= =?utf-8?B?ZnE5b3V2M3VBZ2pZM21WNzVxUjBpQ1l0VTR6NSswMnRYeHRGRlZuUk42SHAy?= =?utf-8?B?bXErYVZwRDZQNy9qRzI0bm5wWUE3MGk0bDhWZ3o2YzUxcXUwODRTd052ZUpu?= =?utf-8?B?TWJ4cXRybjFpZDlqSWlFMXVYMTRCeWY4NHVaNEpIYXllTjVhWEkzdCtXNUtX?= =?utf-8?B?RUF4NWZKa1g4VkU3eWRtT3RldzFxbDNTWTJGckpkMms5bUxyazhydjhGQjh5?= =?utf-8?B?K0xSRTZxTVNKb2NEdVRuaGJobVRwbWxFMVVFTW1IREV5akl3akVza3c0b3Zi?= =?utf-8?B?WkQ3RHN4eUpBQWw1VGs1UzBic25wS1Bwa0JicXJKekJWVkgxbWY3WWNtbWcv?= =?utf-8?B?aTJDeDZXZzQrSStCSGE2aFpONjZlOTI0R3JrZXFaaEVCejdUQkk5R0VkQkRW?= =?utf-8?B?cE1vVW43d0p2UzB4Tzl0VWdNSWlGSEpFTkZGNTN1dDJ1UU1wd1F5THJMRXQ1?= =?utf-8?B?SWN2cEhjOXFKQ1dwZ1RrVkZGTG5DVzNNUjliTlQrcWxlc0lDTVBYUnJ0V3Zu?= =?utf-8?B?aWtTSUJnZmNycjBBeThHYmthQkFrdWoxSThwOWVNa0tieGw4eDJjSDJWeUJo?= =?utf-8?B?NjQ0cVF0Q0xseDRSR2d5L0VVamF2dWlNVTZPRG9nZFh4L2N5VUtYWHV0Sjg0?= =?utf-8?B?VExyZGlaVXhrOThNclhOeHlCUEcvbVJoYThXQTlsVFVzbTlrcmoyWnRFN1E3?= =?utf-8?Q?tFi9n2sxdQ4Moa1BVCcd3XM=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7cdd9b15-8b51-4287-c281-08d9ec8680b3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 11:14:28.2266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hGmiz+WOlFyf8RTCQWNBWVPHrYbnDvShNSV+PYASaX0DIaQf+NMeSry95eQD0+eUwfFNX3kLdhoMMkECb0kRng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3299 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/9/2022 3:32 PM, Stephen Hemminger wrote: > On Wed, 9 Feb 2022 20:24:10 +0800 > Yunjian Wang wrote: > >> This NULL check is unnecessary, 'eth_dev' is never NULL. >> >> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") >> Cc: stable@dpdk.org >> >> Signed-off-by: Yunjian Wang > > > Acked-by: Stephen Hemminger Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.