From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9D15A0553 for ; Mon, 13 Jun 2022 14:25:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9998A410DD; Mon, 13 Jun 2022 14:25:05 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id E466D400EF; Mon, 13 Jun 2022 14:25:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1655123103; x=1686659103; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=XffeEnjU7DSHkUmzpZG5T8owxj+wFtKd9HYCA5/XBsQ=; b=M3acVM7Ufsxnj2gvtMDxslhSGQqA6iQ4dFUD1HmAmpaEjjvhEFKoblGV AnL0Jd+HU79Jj2bG38XnF9nrAApb3Z/cok1YxBOtGl9MNLFlvLOTpSfEa yVGAsSdY4td/xb7Xr36Oh4Q7Fy6B6245EfXcvlbfZAUlSzdGrp6ewChlr HgtiNx6I1gjkMkATaGqTrhQNFftSeNrRQyqdK+Q+LOb6AcCVCh1WbCdpe xBH1Abbk8rp4ZQid0GyWCNjd6mD64cfT6f9o1ihxCFCpMms8Hf/NX2fBc xvCSNXefO0Buax0jVlnLjhu6+yqBJfT6PJroLhR/junkGJm6f+4cedMrS A==; X-IronPort-AV: E=McAfee;i="6400,9594,10376"; a="339935729" X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="339935729" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2022 05:25:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,297,1647327600"; d="scan'208";a="617469413" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 13 Jun 2022 05:25:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 13 Jun 2022 05:25:00 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 13 Jun 2022 05:25:00 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 13 Jun 2022 05:25:00 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 13 Jun 2022 05:25:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJQWikDyBPWRM0mkdGawCouDAdX6b1pv/kPN+VfJPJkN1YxDL08tlV7gesSg0PwZVAKtpklmnIAt8qDBECX7h9qykW3TAsbJUvhEfsGYUGzeRaKiz0k1QewsrlOU1GBHm2sUXyTS7oL++IBJURPuENkN7bOyJJQEbTE0G+zpt97lmY7hUs0ZUq3larCPXdRtF4XmvW9agrWxUK/ecu/i6eLYY9SGn3ZzRBg3yz8WNaB8LFGgCDrxishGRT3j4cIWKSW1eXZPWa6r8T0LVt10aO6OEakXW1hwB/gtXrG1xiMfQ5g8BD0b8kS+CoHaJS/ZHZnU39qnsdjKqpuPyaPkTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rkimz3SKd896ElV0+TWS4eCBdLkHMq5WNAMJq0zRmnE=; b=ZOg/6Podj8m8fGYcUvoBJUJKQd86ETGyhi3zOg6iKm5aYQqs3kHd3hcciFtImSvidCuvCddRkb8HjK8yZ+IBV7Ojm+xse6DR1ag9FnuFSRo24axGp6pj5dsDV7D+f125OUhgwaVaPbiVRpi20lqIfeZCeci/TIRUP6GNB19J/R8YcUdgC10PlThJCktiPrqkGIB5x/U7mhgjABrssQhAtJgjR1OYPQjrh6HuFMM83xQQ9SnFcjr0B1qLP2GT7YpZb96UNNJKPp/pkKuhEGZBF6BB4nkvyGLOUvCYo86ZXvsKhIUQCZNN6fk3bNDDkkOuFoSkNxvRhMTObutHbwyntQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by CO1PR11MB4945.namprd11.prod.outlook.com (2603:10b6:303:9c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Mon, 13 Jun 2022 12:24:58 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::28de:cb68:fa21:3225]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::28de:cb68:fa21:3225%6]) with mapi id 15.20.5332.019; Mon, 13 Jun 2022 12:24:57 +0000 Message-ID: <81ca6e19-969a-18ad-8ef4-65c331cc8564@intel.com> Date: Mon, 13 Jun 2022 17:54:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding" Content-Language: en-US To: Maxime Coquelin , , , , , , , CC: References: <20220608124946.102623-1-maxime.coquelin@redhat.com> <20220608124946.102623-2-maxime.coquelin@redhat.com> From: "Singh, Aman Deep" In-Reply-To: <20220608124946.102623-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0106.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::21) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62534f8c-c007-4513-30e1-08da4d37ba12 X-MS-TrafficTypeDiagnostic: CO1PR11MB4945:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m69663kuJhJZurCWP+rgYZtFOlhNQ2LbbaTUW45DqHSY390IdvHjrepHUzYhevYHTNp0iusolxwVP4Uv4dY29UFThbZ6Siq+yL2YaUjTTM8V4IQporD2RV5DDjqewAeEqJxsAM8uNaISReXhYwfpVDrs5fWW+HcJYONoF76D/vTfiqypOrqjv/4cmvKzXJnIYoKJ2bQH1YmL68uUaaBxTmvs4hACDqQiTXRbKz2IQgdj4sNAjovgMFKaZQGD/VZVi6902jd7eEV26l6BKpvyrGsEezjAF35cX5N1SBbLJPNVEnDUZ3mTEG5nzIwUVkN7KLZ5BBneqZnBPuopGZabZnBPumB3JNuJM5vKCkTTHALP4l4ljeLWEshPt0LFa0bdZE+mg5mxVKTDrUdPyXinojjID1Yf1j1Ntuzg09Byq/fbTZcsLrvKg8m9HuxLSAgtRA/uzGEl/86l3J1ILK6Pq0XbkrNoGjKnZ1ZGyCy4wBvUd4FVuLOxWDTqGsQPbz/0RHavRyt+t8TZMsWJO5fxOLnZYORxAqQqRA01Yr7pNE9vpmXbqtOlU0MeC+nFaXDTsftKh8omjMXFoVf2QAZJuDRV4QAdGLGH2K4XrryRV65H1Ye45vYBfwd8Tv7ytrACrayTwMwZUZobZ1kh+kvqsWGLH87xTzc2yiZ2Cv9azPqeri6qbL/QL27+stbHPgoh07XV/XDkR9sM8DfCTwSQqjJw6WPZgL5J/QLM99s+PTA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(316002)(36756003)(82960400001)(6636002)(2616005)(83380400001)(38100700002)(186003)(31686004)(8936002)(6486002)(8676002)(4326008)(66556008)(6666004)(66946007)(66476007)(508600001)(5660300002)(53546011)(31696002)(26005)(6506007)(6512007)(2906002)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sll4dFFVZFpLalB3cElrczlrMlQydnBhZ1ExeXUwWTJQQlFNelVncHdNT1Jo?= =?utf-8?B?RXFHUXNJaGIzTmdYTEl2RDFtaGp6ZzZmKzh2UUgzTVBaanduNUJ6cnRqYVd6?= =?utf-8?B?MWNYMGpaL05aQ3BpbVZyRGJLeUEwOVYzM2VGOHEvN09OSmZqSXBhVy9YeFNK?= =?utf-8?B?SDdtUERJelpRTmtvYzdxZ1VYU3Z2N1ZFTVJkeFdVdGlNbHZRRXFhS0NDTVhi?= =?utf-8?B?eDFGWVZnN3Q4aEFQVTFIdGFuUmJxU0dJVnB2T0xtY2paQkNzTk1TVENpa1Vy?= =?utf-8?B?M0I2Y2Z1REVEWnBNZnlXUk43blQ1dldDQmVRN2R5OWRwcEpVaXFzdVNQbVl2?= =?utf-8?B?UVRoYXJCbjN6WTZ3N1R0VjlCaWVnZ3psU1Q1K2d0TGpTM2h5NFdNZnA2V0ZV?= =?utf-8?B?ZitVOXdad0I4cEJnSzNaMDhpcmkzNVA2dDg2Y1d2dlJpVW13NzNoTmJXVDdm?= =?utf-8?B?OC94cUVXZDV5bms4TnlZS1RYZEs5S0o3M1FhTjFMbXlKSnJiUUdWRDVseklF?= =?utf-8?B?MHcrbTd6bG1GTDhJUXFzM1FTcVlpZitQNDRNZDJWUnBZaEJQNFBLS1dCTmx4?= =?utf-8?B?WkF4d2xyakFPNEtyMzRwb0JkcDRmZ1VFQXhrTHAwL1NxSlRWQ0VqUjZmZDN4?= =?utf-8?B?R2ZnNWNmSW45RUEvOGFmek80TVRxUStWQ1BhWUwvZmk1dEZ0NUZrZWh2bXow?= =?utf-8?B?UlZZUzc1RmhDQ1dzUVRiNEpaS0tWUGtzRVlyZWNXbHh0eitRY2ZWM2tRR3h6?= =?utf-8?B?KzRuR3lHRWxTQWZBNk9xNHJOOHU1RDR2TkRoT3RSQmdvdFRLa2llbTNZSHpk?= =?utf-8?B?TVFyRzE5M1JmSHQ3V2pHTFFyTDV6OS9TNURlU0RwT0Q5UzhhV2QwU0NTSEoz?= =?utf-8?B?L0YrQ0hCL3NjMDE5ZFl1RUp0Z2xMMTRhVkVoRk9UVm9MR2w3VWhlRVBreDdr?= =?utf-8?B?ZGpIc2pHZTBOWTJXZ2UxeWJJTXBVSXQ4TXVOK3UrY3p3RDJuU1pwU2YrK3hj?= =?utf-8?B?RndUUk81bWlOWGJZeWUvcHFGMkRwTE5sVlhoTUVmNDE0NXZmM1MyYzBkVXph?= =?utf-8?B?YXlBVER3T1BGMTkyOWFnRFM2aWtFZm9memZpRWdxcityREpIVjdNVHlpYzRK?= =?utf-8?B?VkJ0UDZOOXQ2Z04xcFo0MitsTEZBbUxSeEk5V3IxRHRwTmxlSlY3blpRcmZS?= =?utf-8?B?SkhDY2c2dnlMdlpxOFMwK1F5aEZLOXRSMXd5d05RZFE2dG4rUG84Y2lIdG9z?= =?utf-8?B?OEd4aWZXMG1iQVBDcXFlQTljeE1sdTd6MzAxSnFiSUpEVDRlaFVMOCswOGpU?= =?utf-8?B?ZE0weUxyTFRRK0hZVytrUDgwbmhGUHFrT3VDeDdQUmxXWGx3Ky9XYnNhMnhU?= =?utf-8?B?RUN0THRaU0grSGg3bzRmUTkxbEhHeG1GSno4OFE5RndidzN5UmZxUDR6a0Z1?= =?utf-8?B?em1hREswMlViVytvRmoySjFxSnhvWGJ5Ymt5d2pKNFZVa055RE1jaGxQOEY2?= =?utf-8?B?dEx3c2pnelhWTjhDK2hubEtsempSLzBsT3d3TjIrZTNUN1hiWk5GbzA0bTRP?= =?utf-8?B?c2QvYlpkNzhvR3pNcXJ0UjRyM1lyQzVsZ0psUUpwRWgwQVRqRmhrczk3WmN4?= =?utf-8?B?TkgvWjRmSTBWUEkwQ3prZmFQRFlMYW9sNFZRY0hoK0hRM295Q3JXaEZ3UHZl?= =?utf-8?B?VlcyN3pjYUx2bXhtc2ZUT3BjV25RMFJ2L2xzVFowcjFmeUhHZ3RaODk1Nmg0?= =?utf-8?B?d2JXckIzVDZwME1GaTZ4Nmp2bm82UjJrbHpaT1hIM2NLSVBoUExaYnQwZFIw?= =?utf-8?B?K3JYU3QyNHFWZGUxalg2MFVGdTZkS2xoZ2tOSjludGFYSG9KclRpZGNXVXFE?= =?utf-8?B?UDEzV3FVUzk5WkhiSEQySzAzUkV1VUtVcS90QWdQbkJrU2dBcU52bW1UL2Fi?= =?utf-8?B?S1NIMnNaRDhyT0lKL3dGYW9Ra1lxNnVVUThKMCtjK3p4cHRvZ1lGcWdNcVBk?= =?utf-8?B?Nm1zYzhHa0JFNFluVG1McDJCVFJ1SVR1VmpKRExXaWQrdnBCTEtGQU00V2JG?= =?utf-8?B?cHBzd3ZxYXgwWXN4Skd6bGh2YWdTcmtoOVl3ZXNyYkpqOW1BajNCUnMvZFpu?= =?utf-8?B?SnkvZEEwUzUySGNqSXIvbDByekM0dWtpYllabzY1cFMvbm14aGc2SFdaNklu?= =?utf-8?B?MXZUZmROWjJlcUFoNDJzTWxKK1hLbnlOME1jdkNzUTN6OExnNERxZ3p6ZFd6?= =?utf-8?B?YkpibGZjbGF0Q1RLTzAxcFhBMkNtZnRibHl6MFBvTmpzM2VkQWdSRFMwYnFZ?= =?utf-8?B?SzJpenQzN3NDT0ltaVgzOHZsaklYditYalV4SHBFSTV4WXJWdktkL0h5enp2?= =?utf-8?Q?OB2UrO1xSCS7lrqc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 62534f8c-c007-4513-30e1-08da4d37ba12 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 12:24:57.7265 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TApQDq3uFIMucYmA52/OtyQoNHW3rFmyTrL3+um6S098rORgeMnIaxUCmcKCyk8Wo0BVB5IA6S61SCpCtGGpmF72X3+AzK2BmCLng3R6o3Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4945 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Maxime, On 6/8/2022 6:19 PM, Maxime Coquelin wrote: > This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), > as the checksum forwarding is expected to only perform > checksum and not also overwrites the source and destination > MAC addresses. > > Doing so, we can test checksum offloading with real traffic > without breaking broadcast packets. > > Fixes: 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > Acked-by: Chenbo Xia Acked-by: Aman Singh > --- > app/test-pmd/csumonly.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c > index 7df201e047..1a3fd9ce8a 100644 > --- a/app/test-pmd/csumonly.c > +++ b/app/test-pmd/csumonly.c > @@ -916,10 +916,6 @@ pkt_burst_checksum_forward(struct fwd_stream *fs) > * and inner headers */ > > eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *); > - rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr], > - ð_hdr->dst_addr); > - rte_ether_addr_copy(&ports[fs->tx_port].eth_addr, > - ð_hdr->src_addr); > parse_ethernet(eth_hdr, &info); > l3_hdr = (char *)eth_hdr + info.l2_len; > LGTM, In principle csum mode should not modify the mac addresses. This code has been there from start, so might break some TC's.