Re: [EXTERNAL] [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst

[fengchengwen <fengchengwen@huawei.com>]

Hi Sivaprasad,

Are you going to send v3 (add log) version?

There is another patch about adjust burst size [1], if this patch
don't continue, maybe we should restart that one.

[1] https://patchwork.dpdk.org/project/dpdk/patch/20241204020622.977156-1-haijie1@huawei.com/

Thanks

On 10/9/2025 10:32 AM, Tummala, Sivaprasad wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Pavan,
> 
> Please find my response inline.
> 
> ________________________________
> From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Sent: Tuesday, June 10, 2025 7:59 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>; david.hunt@intel.com <david.hunt@intel.com>; anatoly.burakov@intel.com <anatoly.burakov@intel.com>; Jerin Jacob <jerinj@marvell.com>; radu.nicolau@intel.com <radu.nicolau@intel.com>; Akhil Goyal <gakhil@marvell.com>; cristian.dumitrescu@intel.com <cristian.dumitrescu@intel.com>; Yigit, Ferruh <Ferruh.Yigit@amd.com>; konstantin.ananyev@huawei.com <konstantin.ananyev@huawei.com>; mb@smartsharesystems.com <mb@smartsharesystems.com>
> Cc: dev@dpdk.org <dev@dpdk.org>; haijie1@huawei.com <haijie1@huawei.com>; stable@dpdk.org <stable@dpdk.org>; Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>; Dengdui Huang <huangdengdui@huawei.com>
> Subject: Re: [EXTERNAL] [PATCH v2] examples/l3fwd: adjust Tx burst size based on Rx burst
> 
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>>> Previously, the TX burst size was fixed at 256, leading to performance
>>> degradation in certain scenarios.
>>>
>>> This patch introduces logic to set the TX burst size to match the
>>> configured RX burst size (--burst option, default 32, max 512)
>>> for better efficiency.
>>>
>>> Fixes: d5c4897ecfb2 ("examples/l3fwd: add option to set Rx burst size")
>>> Cc: haijie1@huawei.com
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
>>> Tested-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
>>> Tested-by: Dengdui Huang <huangdengdui@huawei.com>
> 
>> It would be good if the selected burst sizes of Rx and Tx are logged.
> ACK
> 
>> On CN10K platform we see upto 5% improvement, and upto 30% improvement on CN9K.
> 
>> Tested-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
>> ---
>> examples/l3fwd/l3fwd.h        |  8 ++------
>> examples/l3fwd/l3fwd_common.h | 11 +++++++----
>> examples/l3fwd/main.c         |  2 ++
>> 3 files changed, 11 insertions(+), 10 deletions(-)
> 
>