From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, "Laatz, Kevin" <kevin.laatz@intel.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix incorrect stat name to id mapping
Date: Tue, 02 Apr 2019 02:34:15 +0200 [thread overview]
Message-ID: <8225282.udm7ztb7Ro@xps> (raw)
In-Reply-To: <efabdc25-c38f-2931-b1b1-805d1c97d74a@intel.com>
01/04/2019 19:17, Laatz, Kevin:
> On 28/03/2019 15:30, Bruce Richardson wrote:
> > If we have two NIC ports which have a different set of NIC stats we can
> > end up having two different stats registered with xstats with the same
> > name. [Since the stats are updated in bulk as a contiguous set, the
> > second driver re-using the registration of the first is not possible.]
> >
> > This causes issues with the invalid stat for one driver being found due to
> > a lookup by name which is unnecessary. Instead of getting stat names
> > involved do the lookup by ID instead.
> >
> > CC: stable@dpdk.org
> > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages")
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
>
> Looks good to me! Thanks.
>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks
prev parent reply other threads:[~2019-04-02 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 15:30 [dpdk-stable] " Bruce Richardson
2019-04-01 17:17 ` Laatz, Kevin
2019-04-02 0:34 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8225282.udm7ztb7Ro@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).