From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CEA3D42D04 for ; Tue, 20 Jun 2023 19:53:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C20A642BC9; Tue, 20 Jun 2023 19:53:11 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2040.outbound.protection.outlook.com [40.107.237.40]) by mails.dpdk.org (Postfix) with ESMTP id EA383410D7; Tue, 20 Jun 2023 19:53:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I5P2gbVVulDB3PsxVjwaUe2fcLlECki0NZycihuYTjLg4p/Jfv68hXpPPkkasG7ZkaaEuv/Q+4DlboC0FPY3w3QFGZCtnJyB0NyPhyk+uZdIvPKvmvRYDqT5qaEWiLEDkBwv0124IBbXElZr+60poQAgXQOZ74Z/e00PgOq1ztJ/NBY/Xeru4cgXx0/3OQj6leYuxyFrmnuR+v6GsBgJUblkr/Bj2oWDRTBcmU5BQxC5HtwqsOHDDXIdMBVuvEpEVrJByVVq/JCyCfVnJ0a3M1+ntteawz2gI6QLW7TfhzNrkc271dtgt3VTQmS+pgMi54BH3TZbafWApezH0WIkDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DVNVgwCL6Wzo4hvRsrGWvBDo1U4hB6Chdo77mjM7QcQ=; b=esclZ4ChH5oN5KoN8fzOXCj65nPSQysOg79gnYDzvlKHlGm/cV/Pccom6m8xZK3XM60xSWPdwjvrml4Wf8m+kMv1tuzoc+4C6ovy5Bo7EEgRnpn3MsPcUXWMHdnIuXgyemRpqA89QV/jxDDJRdvuvXZPKW6oDmdJ6LNOUguQDpR91L7zdon4dvTxNK6Wn+4+cFzESsNs8UIRMN0mJXKKVm5o4M5S1Rk4DGb30E0RSSMxzaD/Mznh30DFxW+sgguMjDMo60464m4J2wPtZWCQkFiOd5GjWsbxlRLQ4pL6apZDeH4dAHU9MWCzzyO+nKJAx5WnVGSVZp4HdqzSw2p7MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DVNVgwCL6Wzo4hvRsrGWvBDo1U4hB6Chdo77mjM7QcQ=; b=SxEPTcz4I5hwakzx8bZ3qn0SLIXvpLn2701zYJs9DvHGS5gHrvkxELhA6DZp1j93DJPDt0c+Y9LZJzv0zA60wus0diMIU8+fffDeBVSSxSZZtx/2rK76ctZlII7Y5l8s9k/WQj5ct66OecemErwpeT6nnlWhtzZjwORN8PPCYjI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8436.namprd12.prod.outlook.com (2603:10b6:806:2e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.35; Tue, 20 Jun 2023 17:53:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 17:53:06 +0000 Message-ID: <823d32e9-d9ad-45fc-7f52-8d338488a7be@amd.com> Date: Tue, 20 Jun 2023 18:53:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] net/nfp: fix add redundant read configure operations Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, Qin Ke , stable@dpdk.org, Peng Zhang References: <20230614055116.784145-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230614055116.784145-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0169.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:312::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8436:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a5b665e-d0bf-43e7-fa42-08db71b733d0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oOUE9vDWm5tw7gYfbsJDONUkngMK2Y17AYekFTHJb/VO1Y2Jwe94pk6OeobPpjC8105D6OUN12dVndb84e+A70W4kip314DXPxonZvknV5w6zJ7s9a1JPaUZeUw44IKbq+53g/SvDPX9RGjP5c+3YrdU5giht15l+95ArCkyz/pBWqnrFPE5xBa8ef12oF338OIMxU5ypl0QYrNKX7K7IgpeZwkoRbo49nhndXoWQMk0xDOu7wVfyFjSOaT4AoZrddVlZV4tdLfrEGzPjKGBkTLoXhcYsp2A1pb3IwtraYi1pOZrv1VuePmOzZP2DUtTEiaEPiaK9Dx6h61OHDKiNGGUCHxetdcs5LuVDue/oDeBz0LAmHv3oPCwvPpwML4z9RLnl8WU6c4dZHBKm15zH5QoWMkN269aSwcQJZ9T+q1igFlj6IYwf76yA3RgAEMkPU+p0eaApkjv7A81Qnhy1HCtLPu8va7K3CdNAq6g7jnjOXzp8xtSlOdHpiirVPtw5WK6mv0w3lPUYVq2ULZNHzDFp3SjXM+9+2uZhs/yjuOb8VPCr0YU2oHDbrfyt7pev3QFyUotYNEBQbJFMOhKA9H01xQjaukPHMOpxhfHK/oyUoqIZ7tQogav5MA1ApVS6bTQ6t9OwH/YivA284VL4w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(451199021)(38100700002)(36756003)(31696002)(86362001)(6666004)(6486002)(53546011)(6512007)(26005)(186003)(8936002)(8676002)(6506007)(44832011)(5660300002)(478600001)(54906003)(31686004)(316002)(41300700001)(66946007)(4326008)(66476007)(2906002)(66556008)(2616005)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qy92QXM0RE1IZlZLd2xIdHhIbW9JUHBTK1BJWndxclhjZWRYa2o4cTQ1RExD?= =?utf-8?B?RmpTOUk2d09uUStnWTF4NVhHVTJ5ZDFMbnh2V040MldKdi9nMThzSFprdlhn?= =?utf-8?B?NmNOWEtLY3VIUUczNzdHdjNIY0taV05rRUsrQnlMMFZEV1VWQXFXOXNreDFR?= =?utf-8?B?MTJVWGFqeW5MUDA2U3VHNjJlZjVlNUhBSExmTUJ4UC9IeGd2Sm5UZ2E3ZzRq?= =?utf-8?B?Vi84SVBEVnFOL09xSUw1cTBsNGFVVkd2S3VnSEUvYi9aWThodGtsRXhERGRk?= =?utf-8?B?UGE5WXNybmh0RVdkUHpYdEFZTmRpU1h5RVE1R2NjeHlUdndEZUljWEtRaHBV?= =?utf-8?B?TFpOK2loVDhabm4zZllXdVdpRHYyZmxBUFI4cXVERjZ4TWFiR2ozSEpwVUpt?= =?utf-8?B?RkN0RmYwVXJnYU1WMDJuYnNmbHB3RCthd1UydnlYSEl4SDlvS0VPMmwwelhm?= =?utf-8?B?RE1CK3d2VEM1OG1rc2FCWDFBRjdwQXJHeHpNcVMzV2JRK2UyQ2lYNDhSU0Z0?= =?utf-8?B?MTRyVFVVODRNTW1ycGVuTkR6Vzh5aW10NzQrTjhRRjlOeXZMUExjbEkzZ082?= =?utf-8?B?MWQ0WTF1cHVhQ0pSU25PcFEwZWt0bW9iNDVyR243bklrbHYveHFYUlpwQUVU?= =?utf-8?B?M1lOeWE3NGZEdXlyTWc2aTgxeXM1b3B5ZUFobU9YSnNtYWNSakhZcEZWcml5?= =?utf-8?B?TnFOU1FLMlpvZXNRaDBEQ1hkdFAzRG9PaUd2eVRteDd3aU1yRkVzZ3RNdm41?= =?utf-8?B?NTkrVDJRZVE3ditwOERFRXdHYjdnRG9YRFlyOEp4bEF3cElSTHRKdjdJbkhC?= =?utf-8?B?RGk0SVZKMmp1Nkl5UDlBYXM4RUpYMVFmdjJsNU04RGRjUFZxTjZERTRQY1hR?= =?utf-8?B?RjZBVTdOMFdzTTdUbGtvVlhwSHV2djVBekhLQzNyM1YvRGVvbWRtYmh4anZN?= =?utf-8?B?Qko5aUllRTkvaER0TmxxLy9yTzNXVVJST1N0SG5lazJYV0RFYzBDL3J3UStH?= =?utf-8?B?T3ZGZG0yelExWm5NN2tUVVVGWjcxRmEzNVM4RGdFQmpsMERHRVc3Z3pMclA1?= =?utf-8?B?d3RWOEwrNC9HVEJoTEdmeHRZUmt6WkdwVUQzaGVYWGJObVJkWld0RDNCdUU1?= =?utf-8?B?MWRmUUVwZmlJTHFoaDFENTBGa01XMG5VMFdhbmI4K1pDclhlcVFabjNJSDBE?= =?utf-8?B?SWszdkg3RVplNzJDUkhNNkZheFdoNHl3K3NqMkNkMVFqQWJ2VURianFpNkls?= =?utf-8?B?a1QzTGd4bUxiWDZ6ajkrb2dOdzgzVUFDVFB4TndvNFBncW5Bcy9xOTJZSGV3?= =?utf-8?B?dkplUzFUMnBjTktkaEMyTTJ3WVArVVQ5amNRWG9ubnZhNHBsVFVTTVJFbmxU?= =?utf-8?B?Zjl2VVpIU1dFa3VycHN5OUdQRDlidk5Mc3N0MDY5ZlJvbU1Xam5LdmtaZHZH?= =?utf-8?B?WCtBd1liWVZidEF2UEFDWS9PTXQwb3plWEZhWHBjaFMvQ2lIRjdiMFh6bGsx?= =?utf-8?B?dzBuejJpTHMrcWZMVkN5Y1RZTkl3VmM0bjRURCs2eG5WbHVsSEZYeU5vaE1l?= =?utf-8?B?TlZqVmdkZzdBWENxUHFrcldFUCs3aURZNUhWVFRsS1hIWWhTVEJCeHlDRjE0?= =?utf-8?B?TFROMVcvMWZBRlF5RURLMi90VlZHTU1QV0dtUm56NDdRM0dWQzlFSWF6bDJB?= =?utf-8?B?VkRsTVRXbmZEeEl0Qkd0OFFvV3A5ZmtVZ0ZqY3IzN2NCSldUMXBNck9Hb1NG?= =?utf-8?B?TDRnYk94eHRXUk5qSXgwTm54Qll0bk9mbWo3NDc5ZE54azFhK0xqemtDSkJ2?= =?utf-8?B?Tk56VkkwTlV3ejVNMzZXQS9RRFMrM3FtZVQyMzV4UnVNSzZyL09JeDlOK1R5?= =?utf-8?B?RW9LdHdBdVNsVVBwZ2dIQTltaUgwR2RjNEpEMWhuT0RReklocjFma1dwNVBX?= =?utf-8?B?QndUenBaZ2RTWWpQckw4TDN2bUpFbmY2NkptemlkeGRxbEwwMFlZMzdpYzZD?= =?utf-8?B?RFJOWFNueVRWYUdFNmpLTzlRUkg4M3MwYW1DZHozWWpNdjdEZ0dIWG1PQTBp?= =?utf-8?B?OGNncTRJeGJPUUFTMXBTUEd3N0NLY21UYURqNkllM2pZRzFJakc0VUMwZU93?= =?utf-8?Q?S2Pyj2pzTTY1xQZ33rP6OhDrj?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a5b665e-d0bf-43e7-fa42-08db71b733d0 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 17:53:06.8457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zr7e9OpHwPgw309Zad7jBJnUdcE6W78UGhdV/deqJDS+l2TwJY01ZRk4PpjqjZSs X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8436 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/14/2023 6:51 AM, Chaoyong He wrote: > From: Qin Ke > > Performance is reduced because of adding redundant read configure > operations in nfp_net_parse_ptype() called by nfp_net_recv_pkts(), > which cause every received packet to spend more time. > > Fix the performance issue by deleting the redundant code directly. > > Fixes: 2e7c36128be ("net/nfp: report packet type by Rx descriptor") > Cc: stable@dpdk.org > > Signed-off-by: Qin Ke > Reviewed-by: Niklas Söderlund > Reviewed-by: Chaoyong He > Reviewed-by: Peng Zhang Applied to dpdk-next-net/main, thanks. <...> > diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c > index 9867db4388..297864450b 100644 > --- a/drivers/net/nfp/nfp_rxtx.c > +++ b/drivers/net/nfp/nfp_rxtx.c > @@ -317,7 +317,8 @@ nfp_net_parse_meta(struct nfp_net_rx_desc *rxds, > * Mbuf to set the packet type. > */ > static void > -nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, struct rte_mbuf *mb) > +nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, > + struct rte_mbuf *mb) Above unrelated modification dropped while merging.