From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 117E841FCC for ; Wed, 30 Aug 2023 13:41:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2EAC40281; Wed, 30 Aug 2023 13:41:50 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id DC25340277 for ; Wed, 30 Aug 2023 13:41:49 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7BFD65C0156; Wed, 30 Aug 2023 07:41:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 30 Aug 2023 07:41:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1693395709; x=1693482109; bh=yqyDbghU19DT9fVZLMRroowO4tfU6BQz/5u mxekkdys=; b=Cpf0ic1j4dK2qJod8IO1+yBe7yb1TeBNSS1+F+uP+opHkxYjf6N AEJZ9vAqF36AhTFfalVPAT7TwUCbZU4pDsv6fb/yrqqoKJRKJ1vQCXQegOFCpwCG C25TOuSXbstmv8ad45+CBXv3sZlhzYx2NLsL6OAqH0LQgT8faIg2sjh90Cz8OgS2 MVT+KkbwiLn5pTJ4lMttAGyBQM4SufZ0bti+21NCRuBr2Qi9mDuvvFygece1lwkW Yx2empliLUgjjLB2FCKNsn5b3XN6PqM5mABdQCtEp6s+i1sQCL52ZmcR9RH5CGzz wI72KQ0VbVaghd8iTf9Bo/MlXKM7kiz2iwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693395709; x=1693482109; bh=yqyDbghU19DT9fVZLMRroowO4tfU6BQz/5u mxekkdys=; b=k9plDuuL8Cu+86u0CHa9BYrbwEC8wm7bkhzVOukaAomprIMDRN1 zvZidQusVsYTTEL6A2Ov1b/paeD4N0mNS319Vgx3P4rZVV5hKeKiFKOeUFcKjZCH icztEPcKjnf+7PznQakYcUarhyhZuKutHWjuPWafedbHNKbX3J66/F8gttPLOGdc 8MvnjAkb7L3BP68HNU8pnEY9MDu4/ejHCxWvu5is0RuQDlnmAE/B/c7R2qhcB1hY qgj1Tq5sWm1woj6lIWsTGstvqhenJKnBt9EnJlPwI7p1zDGlZY/61oDbou4T3j/p glzzHuHVJaRa6a0337gVyU2P1mKbX/sQBFw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudefkedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Aug 2023 07:41:47 -0400 (EDT) From: Thomas Monjalon To: Jie Hai Cc: ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, reshma.pattan@intel.com, liudongdong3@huawei.com, haijie1@huawei.com, yisen.zhuang@huawei.com, stable@dpdk.org, orika@nvidia.com, jerinj@marvell.com, ajit.khaparde@broadcom.com Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying rss algorithm Date: Wed, 30 Aug 2023 13:41:44 +0200 Message-ID: <8262195.T7Z3S40VBb@thomas> In-Reply-To: <20230826070044.64120-2-haijie1@huawei.com> References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230826070044.64120-1-haijie1@huawei.com> <20230826070044.64120-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hello, Thanks for bringing a new capability. 26/08/2023 09:00, Jie Hai: > Currently, rte_eth_rss_conf supports configuring and querying > rss hash functions, rss key and it's length, but not rss hash > algorithm. > > The structure ``rte_eth_rss_conf`` is extended by adding a new > field "func". This represents the RSS algorithms to apply. The > following API is affected: > - rte_eth_dev_configure > - rte_eth_dev_rss_hash_update > - rte_eth_dev_rss_hash_conf_get So far, the RSS algorithm was used only in flow RSS API. > --- a/doc/guides/rel_notes/release_23_11.rst > +++ b/doc/guides/rel_notes/release_23_11.rst > @@ -123,6 +123,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > + * ethdev: Added "func" field to ``rte_eth_rss_conf`` structure for RSS hash > + algorithm. As written above, it should start at the margin. > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > +#include "rte_flow.h" It is strange to include rte_flow.h here. It would be better to move the enum. > + * The *func* field of the *rss_conf* structure indicates the hash algorithm > + * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DEFAULT allows > + * the PMD to use its best-effort algorithm rather than a specific one. I don't like commenting a field on top of the structure. By the way, the first sentence does not look helpful. RTE_ETH_HASH_FUNCTION_DEFAULT may be explained in the enum. > */ > struct rte_eth_rss_conf { > uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > uint8_t rss_key_len; /**< hash key length in bytes. */ > uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + enum rte_eth_hash_function func; /**< Hash algorithm to apply. */ You can drop "to apply".