From: Thomas Monjalon <thomas@monjalon.net>
To: Chenbo Xia <chenbo.xia@intel.com>, Yinan Wang <yinan.wang@intel.com>
Cc: dev@dpdk.org, ajit.khaparde@broadcom.com,
somnath.kotur@broadcom.com, kishore.padmanabha@broadcom.com,
venkatkumar.duvvuru@broadcom.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/bnxt: fix variable size of port id
Date: Wed, 05 Aug 2020 22:18:26 +0200 [thread overview]
Message-ID: <8291662.ihcAm4ep8e@thomas> (raw)
In-Reply-To: <20200804174147.64473-1-chenbo.xia@intel.com>
04/08/2020 19:41, Chenbo Xia:
> Currenly the variable size of ethdev port id is 8 bits. This
> patch standarizes it to 16 bits.
>
> Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy")
> Cc: stable@dpdk.org
>
> Reported-by: Yinan Wang <yinan.wang@intel.com>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> index 9fb1a028f..ff5aed3d7 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> @@ -397,7 +397,7 @@ void
> bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> {
> struct bnxt_ulp_df_rule_info *info;
> - uint8_t port_id;
> + uint16_t port_id;
There are more occurences in bnxt, introduced by the same patch.
In general, in other drivers, it would be good to make this clean-up.
git grep 'uint8_t port' | wc -l
297
next prev parent reply other threads:[~2020-08-05 20:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 17:41 [dpdk-stable] " Chenbo Xia
2020-08-04 16:22 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2020-08-05 20:18 ` Thomas Monjalon [this message]
2020-08-06 2:03 ` Xia, Chenbo
2020-08-06 7:57 ` Thomas Monjalon
2020-09-03 6:49 ` Xiao, QimaiX
2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 1/3] net: fix variable size of ethdev " Chenbo Xia
2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 2/3] app: " Chenbo Xia
2020-09-25 5:37 ` [dpdk-stable] [PATCH v2 3/3] doc: " Chenbo Xia
2020-09-29 18:51 ` [dpdk-stable] [PATCH v2 1/3] net: " Ed Czeck
2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 " Chenbo Xia
2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 2/3] app: " Chenbo Xia
2020-09-30 4:23 ` [dpdk-stable] [PATCH v3 3/3] doc: " Chenbo Xia
2020-09-30 13:40 ` [dpdk-stable] [PATCH v3 1/3] net: " Ajit Khaparde
2020-09-30 17:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8291662.ihcAm4ep8e@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=kishore.padmanabha@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
--cc=venkatkumar.duvvuru@broadcom.com \
--cc=yinan.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).