* [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation
@ 2020-12-02 14:38 Olivier Matz
2020-12-02 14:42 ` Kevin Traynor
2020-12-03 16:41 ` Kevin Traynor
0 siblings, 2 replies; 3+ messages in thread
From: Olivier Matz @ 2020-12-02 14:38 UTC (permalink / raw)
To: stable; +Cc: Bruce Richardson, Radu Nicolau, Kevin Traynor
Fix compilation of examples/multi_process:
> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error:
> implicit declaration of function ‘rte_ether_format_addr’;
> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration]
> rte_ether_format_addr(err_address,
> ^~~~~~~~~~~~~~~~~~~~~
This failure happens after the backport of
commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu
20.04"), which uses a function that does not exist in this branch. The
function was introduced by upstream commit 538da7a1cad2 ("net: add rte
prefix to ether functions"), and is just a renaming of an existing
function.
Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04")
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
examples/multi_process/client_server_mp/mp_server/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
index 1a5bf534ff..62abd62cf3 100644
--- a/examples/multi_process/client_server_mp/mp_server/main.c
+++ b/examples/multi_process/client_server_mp/mp_server/main.c
@@ -65,14 +65,14 @@ get_printable_mac_addr(uint16_t port)
if (unlikely(port >= RTE_MAX_ETHPORTS)) {
if (err_address[0] == '\0')
- rte_ether_format_addr(err_address,
+ ether_format_addr(err_address,
sizeof(err_address), &null_mac);
return err_address;
}
if (unlikely(addresses[port][0]=='\0')){
struct ether_addr mac;
rte_eth_macaddr_get(port, &mac);
- rte_ether_format_addr(addresses[port],
+ ether_format_addr(addresses[port],
sizeof(addresses[port]), &mac);
}
return addresses[port];
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation
2020-12-02 14:38 [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation Olivier Matz
@ 2020-12-02 14:42 ` Kevin Traynor
2020-12-03 16:41 ` Kevin Traynor
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Traynor @ 2020-12-02 14:42 UTC (permalink / raw)
To: Olivier Matz, stable; +Cc: Bruce Richardson, Radu Nicolau
On 02/12/2020 14:38, Olivier Matz wrote:
> Fix compilation of examples/multi_process:
>
>> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error:
>> implicit declaration of function ‘rte_ether_format_addr’;
>> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration]
>> rte_ether_format_addr(err_address,
>> ^~~~~~~~~~~~~~~~~~~~~
>
> This failure happens after the backport of
> commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu
> 20.04"), which uses a function that does not exist in this branch. The
> function was introduced by upstream commit 538da7a1cad2 ("net: add rte
> prefix to ether functions"), and is just a renaming of an existing
> function.
>
Thanks Olivier. I had noticed this too and fixed locally. I will take
your patch as you sent it upstream first.
> Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
> examples/multi_process/client_server_mp/mp_server/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/examples/multi_process/client_server_mp/mp_server/main.c b/examples/multi_process/client_server_mp/mp_server/main.c
> index 1a5bf534ff..62abd62cf3 100644
> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -65,14 +65,14 @@ get_printable_mac_addr(uint16_t port)
>
> if (unlikely(port >= RTE_MAX_ETHPORTS)) {
> if (err_address[0] == '\0')
> - rte_ether_format_addr(err_address,
> + ether_format_addr(err_address,
> sizeof(err_address), &null_mac);
> return err_address;
> }
> if (unlikely(addresses[port][0]=='\0')){
> struct ether_addr mac;
> rte_eth_macaddr_get(port, &mac);
> - rte_ether_format_addr(addresses[port],
> + ether_format_addr(addresses[port],
> sizeof(addresses[port]), &mac);
> }
> return addresses[port];
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation
2020-12-02 14:38 [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation Olivier Matz
2020-12-02 14:42 ` Kevin Traynor
@ 2020-12-03 16:41 ` Kevin Traynor
1 sibling, 0 replies; 3+ messages in thread
From: Kevin Traynor @ 2020-12-03 16:41 UTC (permalink / raw)
To: Olivier Matz, stable; +Cc: Bruce Richardson, Radu Nicolau
On 02/12/2020 14:38, Olivier Matz wrote:
> Fix compilation of examples/multi_process:
>
>> examples/multi_process/client_server_mp/mp_server/main.c:68:4: error:
>> implicit declaration of function ‘rte_ether_format_addr’;
>> did you mean ‘ether_format_addr’? [-Werror=implicit-function-declaration]
>> rte_ether_format_addr(err_address,
>> ^~~~~~~~~~~~~~~~~~~~~
>
> This failure happens after the backport of
> commit a7500412fc5c ("examples/multi_process: fix build on Ubuntu
> 20.04"), which uses a function that does not exist in this branch. The
> function was introduced by upstream commit 538da7a1cad2 ("net: add rte
> prefix to ether functions"), and is just a renaming of an existing
> function.
>
> Fixes: a7500412fc5c ("examples/multi_process: fix build on Ubuntu 20.04")
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-03 16:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 14:38 [dpdk-stable] [PATCH 18.11] examples/multi_process: fix compilation Olivier Matz
2020-12-02 14:42 ` Kevin Traynor
2020-12-03 16:41 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).