From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
David Marchand <david.marchand@redhat.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"lihuisong (C)" <lihuisong@huawei.com>
Cc: dev@dpdk.org, stable@dpdk.org, Joshua Washington <joshwash@google.com>
Subject: Re: [PATCH] app/testpmd: fix forwarding stats for Tx dropped
Date: Wed, 8 Feb 2023 02:07:40 +0000 [thread overview]
Message-ID: <83ed5136-cf48-8938-5174-f622b76d0552@amd.com> (raw)
In-Reply-To: <4c995d84-82f0-6c4c-b189-14da06f013ea@intel.com>
On 2/7/2023 10:10 AM, Singh, Aman Deep wrote:
>
> On 1/31/2023 5:26 PM, Ferruh Yigit wrote:
>> There is an inconsistency at displaying Tx dropped value for per port
>> forwarding stats and accumulated forwarding stats.
>>
>> While displaying per port TX-dropped value, it only takes
>> 'ports_stats[pt_id].tx_dropped' into account,
>> but for accumulated TX-dropped results it takes both
>> 'ports_stats[pt_id].tx_dropped' & 'stats.oerrors' into account.
>>
>> To fix, make both per port and accumulated stats display 'tx_dropped'
>> and 'stats.oerrors' (ports_stats[pt_id].tx_dropped + stats.oerrors).
>>
>> Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on
>> demand")
>> Cc: stable@dpdk.org
>>
>> Reported-by: Joshua Washington <joshwash@google.com>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>
> Acked-by: Huisong Li <lihuisong@huawei.com>
>
> Acked-by: Aman Singh <aman.deep.singh@intel.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-02-08 2:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 11:56 Ferruh Yigit
2023-02-01 1:14 ` lihuisong (C)
2023-02-07 10:10 ` Singh, Aman Deep
2023-02-08 2:07 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ed5136-cf48-8938-5174-f622b76d0552@amd.com \
--to=ferruh.yigit@amd.com \
--cc=aman.deep.singh@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=joshwash@google.com \
--cc=lihuisong@huawei.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).