From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1314A00C5 for ; Tue, 19 Jul 2022 13:14:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C510440A87; Tue, 19 Jul 2022 13:14:13 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 3A07B4069F for ; Tue, 19 Jul 2022 13:14:12 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4LnGMf1nZzzVgZM; Tue, 19 Jul 2022 19:10:22 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 19:14:07 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 19 Jul 2022 19:14:04 +0800 Message-ID: <842ba803-89a3-f3f3-0f85-eadca77857b3@huawei.com> Date: Tue, 19 Jul 2022 19:14:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: please help backporting some patches to stable release 19.11.13 To: Christian Ehrhardt CC: Aaron Conole , Adrien Mazarguil , Ajit Khaparde , Akhil Goyal , Akhil Goyal , Alejandro Lucero , Aman Singh , Anatoly Burakov , Andrew Rybchenko , Andy Gospodarek , Andy Pei , "Apeksha Gupta" , Ashish Jain , Beilei Xing , Bernard Iremonger , Bruce Richardson , Changchun Ouyang , Chaoyong He , "Chas Williams" , Chenbo Xia , Chengwen Feng , "Chen Jing D(Mark)" , Chunsong Feng , Ciara Power , Damodharam Ammepalli , David Christensen , David Christensen , David Marchand , Daxue Gao , Declan Doherty , Deepak Kumar Jain , Dmitry Kozlyuk , "Dmitry Kozlyuk" , Dmitry Malloy , Dongdong Liu , Duncan Bellamy , Evgeny Schemeilin , Fan Zhang , Ferruh Yigit , Ferruh Yigit , Fiona Trahe , "Gagandeep Singh" , Gregory Etelson , Haiyang Zhang , Hao Chen , Harry van Haaren , Helin Zhang , "Hemant Agrawal" , Herakliusz Lipiec , Huawei Xie , "Igor Chauskin" , Ivan Boule , "Jakub Poczatek" , Jan Viktorin , Jerin Jacob , Jerin Jacob , Jianfeng Tan , Jiayu Hu , Jingjing Wu , John McNamara , Kalesh AP , Kevin Laatz , Ke Zhang , "Kiran Kumar K" , Konstantin Ananyev , Konstantin Ananyev , Kumar Sanghvi , "Lijun Ou" , Long Li , Louis Peens , Marcin Baran , "dpdk stable" References: <20220707080743.209497-1-christian.ehrhardt@canonical.com> <54730341-5071-3f7d-f5bd-86854c75c8e7@huawei.com> From: "lihuisong (C)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 在 2022/7/19 16:46, Christian Ehrhardt 写道: > On Tue, Jul 19, 2022 at 3:46 AM lihuisong (C) wrote: >> Hi Christian, >> >> "ea6101a8e4 Min Hu (Connor) ethdev: fix port close in secondary process" >> The above patch is depend on following patch: >> febc855b358e ("ethdev: forbid closing started device") >> >> Do I need to backport this dependency patch? But it is not in this >> packporting list. > The patch list we work on is based on patches that had CC stable or > the word fix in it. > The mail that we maintainers then send is about those that didn't > cleanly (or with minimal churn) apply for any reason. > > That dependent patch febc855b358e ("ethdev: forbid closing started > device") was originally from v21.11. > I asked for a backport of that in "please help backporting some > patches to stable release 19.11.11" on Nov 30, 2021, 5:56 PM > It wasn't backported then and I have no insight on why. > > TL;DR: either we skip your patch as well, or you indeed would need to > backport both. This patch fixes the problem introduced by the patch febc855b358e. So let's skip this patch. Thanks. > > >> Best Regards, >> Huisong >> >> 在 2022/7/7 16:07, christian.ehrhardt@canonical.com 写道: >>> Hi commit authors (and maintainers), >>> >>> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh >>> I didn't apply following commits from DPDK main to 19.11 >>> stable branch, as conflicts or build errors occur. >>> >>> Can authors check your patches in the following list and either: >>> - Backport your patches to the 19.11 branch, or >>> - Indicate that the patch should not be backported >>> >>> Please do either of the above by 07/17/22. >>> >>> You can find the a temporary work-in-progress branch of the coming 19.11.13 >>> release at: >>> https://github.com/cpaelzer/dpdk-stable-queue >>> It is recommended to backport on top of that to minimize further conflicts or >>> misunderstandings. >>> >>> Some notes on stable backports: >>> >>> A backport should contain a reference to the DPDK main branch commit >>> in it's commit message in the following fashion: >>> [ upstream commit ] >>> >>> For example: >>> https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb >>> >>> When sending the backported patch, please indicate the target branch in the >>> subject line, as we have multiple branches, for example: >>> [PATCH 19.11] foo/bar: fix baz >>> >>> With git format-patch, this can be achieved by appending the parameter: >>> --subject-prefix='PATCH 19.11' >>> >>> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org". >>> >>> FYI, branch 19.11 is located at tree: >>> https://git.dpdk.org/dpdk-stable >>> >>> Thanks. >>> >>> Christian Ehrhardt >>> >>> --- >>> f940a2e333 Bruce Richardson test: validate test names in non interactive mode >>> 7d3cb76fba Chengwen Feng examples/dma: fix Tx drop statistics >>> a42ab1eb33 Damodharam Ammepalli net/bnxt: disallow MTU change when device is started >>> 5fc2eece8d David Marchand app/flow-perf: fix build with GCC 12 >>> 468f31eb71 David Marchand crypto/ipsec_mb: fix build with GCC 12 >>> 2f51bc9c27 David Marchand eal/freebsd: fix use of newer cpuset macros >>> 1e230b9be8 David Marchand eal/windows: add missing C++ include guards >>> 2449949584 David Marchand net/ena: fix build with GCC 12 >>> 7c3c0d0f29 David Marchand net/enetfec: fix build with GCC 12 >>> 3c4426db54 Dmitry Kozlyuk app/testpmd: do not poll stopped queues >>> e96d3d02d6 Dmitry Kozlyuk common/mlx5: fix non-expandable global MR cache >>> 979bb5d493 Dmitry Kozlyuk doc: add more instructions for running as non-root >>> 19ec0f421e Dmitry Kozlyuk doc: update running as non-root in mlx5 guide >>> 0615dd2aa1 Duncan Bellamy eal/ppc: fix compilation for musl >>> e3d264383b Gagandeep Singh crypto/dpaa2_sec: fix crypto operation pointer >>> 6a2b01a410 Gagandeep Singh crypto/dpaa2_sec: fix fle buffer leak >>> d05828ac58 Gagandeep Singh doc: add missing auth algo for IPsec example >>> 85bd316d08 Harry van Haaren doc: fix formatting and link in BPF library guide >>> c8a3ee49c9 Herakliusz Lipiec doc: fix readability in vhost guide >>> 3889a3220c Huisong Li app/testpmd: fix bonding slave devices not released >>> e46372d7b0 Huisong Li app/testpmd: fix port status of bonding slave device >>> 3c23ee6cdd Huisong Li app/testpmd: fix supported RSS offload display >>> f5e72e8e8d Huisong Li net/bonding: fix stopping non-active slaves >>> ea1ef0b937 Huisong Li net/hns3: fix an unreasonable memset >>> 8ba42ce98d Huisong Li net/hns3: fix crash from secondary process >>> a65342d9d5 Huisong Li net/hns3: fix MAC and queues HW statistics overflow >>> 07f64b5f57 Huisong Li net/hns3: fix rollback on RSS hash update >>> 75ccc3f3d7 Huisong Li net/hns3: fix RSS disable >>> 7b29666261 Huisong Li net/hns3: fix statistics locking >>> bfd0b54dc8 Huisong Li net/hns3: remove redundant RSS tuple field >>> ec16914942 Huisong Li net/hns3: remove unnecessary RSS switch >>> 7fe84b0de2 Jakub Poczatek doc: fix grammar and parameters in l2fwd-crypto guide >>> 47a956a8fe Kalesh AP net/bnxt: fix device capability reporting >>> 7b6eba8856 Kalesh AP net/bnxt: fix link status when port is stopped >>> 0a90c56eac Kalesh AP net/bnxt: fix Rx configuration >>> c0278f6e52 Kalesh AP net/bnxt: fix tunnel stateless offloads >>> 9c1410bed3 Kalesh AP net/bnxt: force PHY update on certain configurations >>> 68629be3a6 Ke Zhang app/testpmd: fix multicast address pool leak >>> fced83c122 Ke Zhang net/iavf: fix mbuf release in multi-process >>> a08f9cb698 Ke Zhang net/iavf: fix Rx queue interrupt setting >>> 559a1f2eea Long Li net/netvsc: fix calculation of checksums based on mbuf flag >>> 7b1a614dcb Long Li net/netvsc: fix vmbus device reference in multi-process >>> a213b86821 Michael Baum net/mlx5: fix LRO validation in Rx setup >>> 87063aaff3 Mike Pattrick net/i40e: populate error in flow director parser >>> ea6101a8e4 Min Hu (Connor) ethdev: fix port close in secondary process >>> 7988cdca98 Peng Zhang net/nfp: fix disabling VLAN stripping >>> 417be15e5f Peng Zhang net/nfp: make sure MTU is never larger than mbuf size >>> 151e828f64 Rahul Lakkireddy net/cxgbe: fix Tx queue stuck with mbuf chain coalescing >>> 773a7de21a Raja Zidane net/mlx5: fix Rx/Tx stats concurrency >>> 5ddb903824 Raja Zidane net/mlx5: reject negative integrity item configuration >>> 1b27f8245e Somnath Kotur net/bnxt: fix ring group on Rx restart >>> f75dd6d3b1 Stanislaw Kardach config: fix C++ cross compiler for Arm and PPC >>> 0b5da8cc52 Tianli Lai net/dpaa2: fix dpdmux default interface >>> 2ddf4b110c Tomasz Duszynski common/cnxk: allow changing PTP mode on CN10K >>> ae835aba40 Wei Huang raw/ifpga: remove virtual devices on close >>> 2545683564 Wei Huang raw/ifpga: unregister interrupt on close >>> 1945c64674 Wenwu Ma app/testpmd: perform SW IP checksum for GRO/GSO packets >>> 3e87e12dc8 Wenxuan Wu net/ice/base: fix build with GCC 12 >>> 1907ce4bae Yuan Wang examples/vhost: fix retry logic on Rx path >>> 41f9a1757f Yuan Wang net/virtio-user: fix socket non-blocking mode >>> . > > > -- > Christian Ehrhardt > Senior Staff Engineer, Ubuntu Server > Canonical Ltd > .