From: Thomas Monjalon <thomas@monjalon.net>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
Cc: stable@dpdk.org, "Wang, Dong1" <dong1.wang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-stable] [PATCH v2] example/ipv4_multicast: fix app hanging when using clone
Date: Sun, 18 Nov 2018 22:56:41 +0100 [thread overview]
Message-ID: <8430826.3j7pgKI0Cq@xps> (raw)
In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F7505D@SHSMSX103.ccr.corp.intel.com>
> > The ipv4_multicast sample application was dropping packets when using
> > mbuf clone. When creating an L2 header and copying metadata from the
> > source packet, the ol_flags were also copied along with all the other
> > metadata. Because the cloned packet had IND_ATTACHED_MBUF flag set in
> > its ol_flags, this caused the packets to never be freed when using
> > rte_pktmbuf_free.
> > Since copying ol_flags from the cloned packet is not necessary in the
> > first place, just don't do it.
> >
> > Fixes: af75078fece3 ("first public release")
> > CC: stable@dpdk.org
> >
> > Reported-by: Wang Dong <dong1.wang@intel.com>
> > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Acked-by: Wang Dong <dong1.wang@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-11-18 21:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181112204650.7175-1-herakliusz.lipiec@intel.com>
2018-11-13 11:49 ` Herakliusz Lipiec
2018-11-13 11:51 ` Ananyev, Konstantin
2018-11-14 11:33 ` Wang, Dong1
2018-11-18 21:56 ` Thomas Monjalon [this message]
2018-11-14 2:28 ` Wang, Dong1
2018-11-14 9:02 ` Ananyev, Konstantin
2018-11-14 10:09 ` Wang, Dong1
2018-11-14 10:17 ` Ananyev, Konstantin
2018-11-14 11:06 ` Wang, Dong1
2018-11-14 11:19 ` Ananyev, Konstantin
2018-11-14 11:32 ` Wang, Dong1
2018-11-20 5:40 ` Zhao1, Wei
2018-11-20 9:52 ` Ananyev, Konstantin
2018-11-14 10:21 ` Lipiec, Herakliusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8430826.3j7pgKI0Cq@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=dong1.wang@intel.com \
--cc=herakliusz.lipiec@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).