* [dpdk-stable] [PATCH] eal/option: fix option register duplicate detection
@ 2018-12-17 9:25 Gaetan Rivet
2018-12-17 9:35 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-12-17 10:19 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Gaetan Rivet @ 2018-12-17 9:25 UTC (permalink / raw)
To: dev; +Cc: Gaetan Rivet, stable
Missing brackets around the if means that the loop will end at its first
iteration.
Cc: stable@dpdk.org
Fixes: 2395332798d0 ("eal: add option register infrastructure")
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
lib/librte_eal/common/rte_option.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
index 02d59a869..eefb8b923 100644
--- a/lib/librte_eal/common/rte_option.c
+++ b/lib/librte_eal/common/rte_option.c
@@ -35,10 +35,11 @@ void __rte_experimental
rte_option_register(struct rte_option *opt)
{
TAILQ_FOREACH(option, &rte_option_list, next) {
- if (strcmp(opt->opt_str, option->opt_str) == 0)
+ if (strcmp(opt->opt_str, option->opt_str) == 0) {
RTE_LOG(INFO, EAL, "Option %s has already been registered.",
opt->opt_str);
return;
+ }
}
TAILQ_INSERT_HEAD(&rte_option_list, opt, next);
--
2.19.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection
2018-12-17 9:25 [dpdk-stable] [PATCH] eal/option: fix option register duplicate detection Gaetan Rivet
@ 2018-12-17 9:35 ` Burakov, Anatoly
2018-12-17 10:19 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: Burakov, Anatoly @ 2018-12-17 9:35 UTC (permalink / raw)
To: Gaetan Rivet, dev; +Cc: stable
On 17-Dec-18 9:25 AM, Gaetan Rivet wrote:
> Missing brackets around the if means that the loop will end at its first
> iteration.
>
> Cc: stable@dpdk.org
>
> Fixes: 2395332798d0 ("eal: add option register infrastructure")
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_eal/common/rte_option.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c
> index 02d59a869..eefb8b923 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -35,10 +35,11 @@ void __rte_experimental
> rte_option_register(struct rte_option *opt)
> {
> TAILQ_FOREACH(option, &rte_option_list, next) {
> - if (strcmp(opt->opt_str, option->opt_str) == 0)
> + if (strcmp(opt->opt_str, option->opt_str) == 0) {
> RTE_LOG(INFO, EAL, "Option %s has already been registered.",
> opt->opt_str);
> return;
> + }
> }
>
> TAILQ_INSERT_HEAD(&rte_option_list, opt, next);
>
This is why i don't like the "no brackets on single-statement if clause"
rule in our coding style guide - it makes mistakes like these easier to
do. This wouldn't have happened if we mandated to have brackets always,
for everything.
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection
2018-12-17 9:25 [dpdk-stable] [PATCH] eal/option: fix option register duplicate detection Gaetan Rivet
2018-12-17 9:35 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
@ 2018-12-17 10:19 ` David Marchand
2018-12-19 22:59 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2018-12-17 10:19 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, stable
On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet <gaetan.rivet@6wind.com>
wrote:
> Missing brackets around the if means that the loop will end at its first
> iteration.
>
> Cc: stable@dpdk.org
>
> Fixes: 2395332798d0 ("eal: add option register infrastructure")
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_eal/common/rte_option.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/common/rte_option.c
> b/lib/librte_eal/common/rte_option.c
> index 02d59a869..eefb8b923 100644
> --- a/lib/librte_eal/common/rte_option.c
> +++ b/lib/librte_eal/common/rte_option.c
> @@ -35,10 +35,11 @@ void __rte_experimental
> rte_option_register(struct rte_option *opt)
> {
> TAILQ_FOREACH(option, &rte_option_list, next) {
> - if (strcmp(opt->opt_str, option->opt_str) == 0)
> + if (strcmp(opt->opt_str, option->opt_str) == 0) {
> RTE_LOG(INFO, EAL, "Option %s has already been
> registered.",
> opt->opt_str);
> return;
> + }
> }
>
> TAILQ_INSERT_HEAD(&rte_option_list, opt, next);
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
Different topic but having a return code would be better than a simple log.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] eal/option: fix option register duplicate detection
2018-12-17 10:19 ` David Marchand
@ 2018-12-19 22:59 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-12-19 22:59 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, David Marchand, stable
17/12/2018 11:19, David Marchand:
> On Mon, Dec 17, 2018 at 10:26 AM Gaetan Rivet <gaetan.rivet@6wind.com>
> wrote:
>
> > Missing brackets around the if means that the loop will end at its first
> > iteration.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: 2395332798d0 ("eal: add option register infrastructure")
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > ---
> > rte_option_register(struct rte_option *opt)
> > {
> > TAILQ_FOREACH(option, &rte_option_list, next) {
> > - if (strcmp(opt->opt_str, option->opt_str) == 0)
> > + if (strcmp(opt->opt_str, option->opt_str) == 0) {
> > RTE_LOG(INFO, EAL, "Option %s has already been
> > registered.",
> > opt->opt_str);
> > return;
> > + }
> > }
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
Applied, thanks
> Different topic but having a return code would be better than a simple log.
+1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-19 22:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-17 9:25 [dpdk-stable] [PATCH] eal/option: fix option register duplicate detection Gaetan Rivet
2018-12-17 9:35 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-12-17 10:19 ` David Marchand
2018-12-19 22:59 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).