[PATCH] net/bnxt: fix newline character in speed display

[PATCH] net/bnxt: fix newline character in speed display

[Damodharam Ammepalli]

Mistakenly "\n" sneaked into bnxt_print_link_info which
prints the speed and lanes information of Broadcom Thor2 NIC.
This patch removes this newline character.

Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
Cc: stable@dpdk.org
Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index c6ad764813..18eba0c770 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1383,7 +1383,7 @@ void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
 			    eth_dev->data->port_id,
 			    (uint32_t)link->link_speed,
 			    (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
-			    ("full-duplex") : ("half-duplex\n"),
+			    ("full-duplex") : ("half-duplex"),
 			    (uint16_t)bp->link_info->active_lanes);
 	else
 		PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
-- 
2.43.5


-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

Re: [PATCH] net/bnxt: fix newline character in speed display

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]

On Fri, Oct 4, 2024 at 1:53 PM Damodharam Ammepalli
<damodharam.ammepalli@broadcom.com> wrote:
>
> Mistakenly "\n" sneaked into bnxt_print_link_info which
> prints the speed and lanes information of Broadcom Thor2 NIC.
> This patch removes this newline character.
>
> Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
> Cc: stable@dpdk.org
> Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index c6ad764813..18eba0c770 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1383,7 +1383,7 @@ void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
>                             eth_dev->data->port_id,
>                             (uint32_t)link->link_speed,
>                             (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
> -                           ("full-duplex") : ("half-duplex\n"),
> +                           ("full-duplex") : ("half-duplex"),
>                             (uint16_t)bp->link_info->active_lanes);
>         else
>                 PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
> --
> 2.43.5
>
>
> --
> This electronic communication and the information and any files transmitted
> with it, or attached to it, are confidential and are intended solely for
> the use of the individual or entity to whom it is addressed and may contain
> information that is confidential, legally privileged, protected by privacy
> laws, or otherwise restricted from disclosure to anyone else. If you are
> not the intended recipient or the person responsible for delivering the
> e-mail to the intended recipient, you are hereby notified that any use,
> copying, distributing, dissemination, forwarding, printing, or copying of
> this e-mail is strictly prohibited. If you received this e-mail in error,
> please return the e-mail to the sender, delete it from your computer, and
> destroy any printed copy of it.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]

Re: [PATCH] net/bnxt: fix newline character in speed display

[Ferruh Yigit]

On 10/4/2024 9:55 PM, Ajit Khaparde wrote:
> On Fri, Oct 4, 2024 at 1:53 PM Damodharam Ammepalli
> <damodharam.ammepalli@broadcom.com> wrote:
>>
>> Mistakenly "\n" sneaked into bnxt_print_link_info which
>> prints the speed and lanes information of Broadcom Thor2 NIC.
>> This patch removes this newline character.
>>
>> Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification")
>> Cc: stable@dpdk.org
>> Signed-off-by: Damodharam Ammepalli <damodharam.ammepalli@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 

This fixed in the original commit while merging to main repo.

>> ---
>>  drivers/net/bnxt/bnxt_ethdev.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
>> index c6ad764813..18eba0c770 100644
>> --- a/drivers/net/bnxt/bnxt_ethdev.c
>> +++ b/drivers/net/bnxt/bnxt_ethdev.c
>> @@ -1383,7 +1383,7 @@ void bnxt_print_link_info(struct rte_eth_dev *eth_dev)
>>                             eth_dev->data->port_id,
>>                             (uint32_t)link->link_speed,
>>                             (link->link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?
>> -                           ("full-duplex") : ("half-duplex\n"),
>> +                           ("full-duplex") : ("half-duplex"),
>>                             (uint16_t)bp->link_info->active_lanes);
>>         else
>>                 PMD_DRV_LOG(INFO, "Port %d Link Down\n", eth_dev->data->port_id);
>> --
>> 2.43.5
>>
>>
>> --
>> This electronic communication and the information and any files transmitted
>> with it, or attached to it, are confidential and are intended solely for
>> the use of the individual or entity to whom it is addressed and may contain
>> information that is confidential, legally privileged, protected by privacy
>> laws, or otherwise restricted from disclosure to anyone else. If you are
>> not the intended recipient or the person responsible for delivering the
>> e-mail to the intended recipient, you are hereby notified that any use,
>> copying, distributing, dissemination, forwarding, printing, or copying of
>> this e-mail is strictly prohibited. If you received this e-mail in error,
>> please return the e-mail to the sender, delete it from your computer, and
>> destroy any printed copy of it.