patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Chaoyong He <chaoyong.he@corigine.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "oss-drivers@corigine.com" <oss-drivers@corigine.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Long Wu <long.wu@corigine.com>,
	"Peng Zhang" <peng.zhang@corigine.com>
Subject: RE: [PATCH] app/testpmd: fix help string of BPF load command
Date: Mon, 24 Jun 2024 15:45:47 +0000	[thread overview]
Message-ID: <85c474a3ee084be7a91624b3b444290f@huawei.com> (raw)
In-Reply-To: <20240624015852.3712910-1-chaoyong.he@corigine.com>


> Based on the logic of 'bpf_parse_flags()' and the 'bpf-load' section of
> 'testpmd_funcs.rst' document, the 'B' flag in the help string of
> bpf-load command should be '-'.
> 
> Fixes: e977e4199a8d ("app/testpmd: add commands to load/unload BPF filters")
> Cc: konstantin.ananyev@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> ---
>  app/test-pmd/bpf_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/bpf_cmd.c b/app/test-pmd/bpf_cmd.c
> index 46f6b7d6d2..24d34f983e 100644
> --- a/app/test-pmd/bpf_cmd.c
> +++ b/app/test-pmd/bpf_cmd.c
> @@ -139,7 +139,7 @@ static cmdline_parse_token_string_t cmd_load_bpf_prm =
>  cmdline_parse_inst_t cmd_operate_bpf_ld_parse = {
>  	.f = cmd_operate_bpf_ld_parsed,
>  	.data = NULL,
> -	.help_str = "bpf-load rx|tx <port> <queue> <J|M|B> <file_name>",
> +	.help_str = "bpf-load rx|tx <port> <queue> <J|M|-> <file_name>",
>  	.tokens = {
>  		(void *)&cmd_load_bpf_start,
>  		(void *)&cmd_load_bpf_dir,
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com> 

> 2.39.1
> 


  reply	other threads:[~2024-06-24 15:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-24  1:58 Chaoyong He
2024-06-24 15:45 ` Konstantin Ananyev [this message]
2024-07-09 12:22   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85c474a3ee084be7a91624b3b444290f@huawei.com \
    --to=konstantin.ananyev@huawei.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=long.wu@corigine.com \
    --cc=oss-drivers@corigine.com \
    --cc=peng.zhang@corigine.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).