From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5543A0548 for ; Wed, 1 Jun 2022 09:55:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAA5540689; Wed, 1 Jun 2022 09:55:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C796D4113F for ; Wed, 1 Jun 2022 09:55:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654070109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IjY6QoRSEyP8G07jxblILBM20KMWOik+XmkQI3+8tFU=; b=Xo/cRZP+MqrMNj0WBGaH6UaJUn/Lk1/bgwO2R6rmT1emBAjR1VDzwf6mQCbCcdMCy8Vs8X uVo8Kd7eX8wzBEG7FANd5CTWRg9Fr/y5bE7oBl3yn2rm++9Eb7diOyQaC0+PlXVrWJ7CSV 9tgMsWd18l38MhR0FtF/eq8P5D7rXoI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-203-RUv1mVZZOT-BVle1fzl8Ww-1; Wed, 01 Jun 2022 03:55:05 -0400 X-MC-Unique: RUv1mVZZOT-BVle1fzl8Ww-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7CD9A811E75; Wed, 1 Jun 2022 07:55:04 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E224940CF8EB; Wed, 1 Jun 2022 07:55:01 +0000 (UTC) Message-ID: <85d52a01-116f-832e-7e5a-2f5d03cabe51@redhat.com> Date: Wed, 1 Jun 2022 09:55:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2] vdpa/mlx5: workaround var offset within page To: Yajun Wu , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com, stable@dpdk.org References: <20220314014414.251869-1-yajunw@nvidia.com> <20220315024733.507162-1-yajunw@nvidia.com> From: Maxime Coquelin In-Reply-To: <20220315024733.507162-1-yajunw@nvidia.com> X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi Yajun, On 3/15/22 03:47, Yajun Wu wrote: > vDPA driver first uses kernel driver to allocate doorbell(VAR) area for > each device. Then uses var->mmap_off and var->length to mmap uverbs device > file as doorbell userspace virtual address. > > Current kernel driver provides var->mmap_off equal to page start of VAR. > It's fine with x86 4K page server, because VAR physical address is only 4K > aligned thus locate in 4K page start. > > But with aarch64 64K page server, the actual VAR physical address has > offset within page(not locate in 64K page start). So vDPA driver need add > this within page offset(caps.doorbell_bar_offset) to get right VAR virtual > address. > > Fixes: 62c813706e4 ("vdpa/mlx5: map doorbell") > Cc: stable@dpdk.org > > Signed-off-by: Yajun Wu > Acked-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime