From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45294A0613 for ; Thu, 26 Sep 2019 15:19:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 049D7343C; Thu, 26 Sep 2019 15:19:07 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4FC94343C for ; Thu, 26 Sep 2019 15:19:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB6A13082138; Thu, 26 Sep 2019 13:19:05 +0000 (UTC) Received: from [10.36.117.187] (ovpn-117-187.ams2.redhat.com [10.36.117.187]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CA4A60C44; Thu, 26 Sep 2019 13:19:00 +0000 (UTC) To: stable@dpdk.org, marcinx.smoczynski@intel.com, konstantin.ananyev@intel.com, ferruh.yigit@intel.com, salehals@mellanox.com Cc: bluca@debian.org, bruce.richardson@intel.com References: <20190925171242.8005-1-ktraynor@redhat.com> From: Kevin Traynor Message-ID: <85d9116b-821c-2f1e-eddf-02b5eabb6a85@redhat.com> Date: Thu, 26 Sep 2019 14:19:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190925171242.8005-1-ktraynor@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Thu, 26 Sep 2019 13:19:05 +0000 (UTC) Subject: Re: [dpdk-stable] [PATCH 18.11 0/1] Enable __BSD_VISIBLE X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 25/09/2019 18:12, Kevin Traynor wrote: > This backport is needed for 18.11 as the below commit > [Fixes: 54e4657b2385 ("net: define IPv4 IHL and VHL")] > requires that __BSD_VISIBLE is defined for > in FreeBSD. >=20 Thanks Luca and Bruce. Re-tested on FreeBSD12 with clang and gcc. s/CONFIG_RTE_EXEC_ENV_FREEBSD/CONFIG_RTE_EXEC_ENV_BSDAPP/ and pushed to 18.11 branch. > Otherwise, there is a build error on FreeBSD similar to the one > originally reported here > http://inbox.dpdk.org/stable/3d694042-dbe9-7560-5912-d865da048c7c@intel= =2Ecom/ >=20 > The other option is to revert the following commits from branch 18.11. >=20 > commit d8084ac1f9c74ce9fe61b26c9d4198d872d5fc7e > Author: Saleh Alsouqi > Date: Thu Jul 4 07:33:22 2019 +0000 >=20 > app/testpmd: fix MPLS IPv4 encapsulation fields > =20 > [ upstream commit a97ec9ba45d4357c172df71be3fcf601dfdb8147 ] > =20 > Having version and ihl set to 0 would result in a > corrupted/incorrect encapsulating packet for MPLS, > this commit sets these fields to 4 and 5 respectively > as defined in librte_net/rte_ip.h. > =20 > Fixes: 3e77031be855 ("app/testpmd: add MPLSoGRE encapsulation") > Fixes: a1191d39cb57 ("app/testpmd: add MPLSoUDP encapsulation") > =20 > Signed-off-by: Saleh Alsouqi > Reviewed-by: Ferruh Yigit >=20 > commit 54e4657b238593c633367a2dda48ecf4e04249bb > Author: Saleh Alsouqi > Date: Thu Jul 4 07:33:19 2019 +0000 >=20 > net: define IPv4 IHL and VHL > =20 > [ upstream commit 2318d8d5456532e8022d324937a77a416b701d2b ] > =20 > Define IPv4 Minimum IHL and VHL according to rfc791 (see [1]) > =20 > "The Version field indicates the format of the > internet header." > =20 > "Internet Header Length (ihl) is the length of the > internet header in 32 bit words, and thus points > to the beginning of the data. Note that > the minimum value for a correct header is 5." > =20 > [1] https://tools.ietf.org/html/rfc791 > =20 > Signed-off-by: Saleh Alsouqi > Reviewed-by: Ferruh Yigit >=20 > Marcin Smoczynski (1): > build: enable BSD features visibility for FreeBSD >=20 > app/meson.build | 3 --- > config/meson.build | 8 ++++++++ > drivers/meson.build | 3 --- > examples/meson.build | 3 --- > lib/meson.build | 3 --- > meson.build | 6 +++++- > mk/target/generic/rte.vars.mk | 5 +++++ > 7 files changed, 18 insertions(+), 13 deletions(-) >=20