From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84D90A04B5 for ; Wed, 4 Dec 2019 14:51:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4BE211BF6F; Wed, 4 Dec 2019 14:51:16 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 352374C99; Wed, 4 Dec 2019 14:51:13 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id p17so8009517wma.1; Wed, 04 Dec 2019 05:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=HGWLaqYHTf2/kX0L9uDxhXgvgb1sLDQr2QqIzKw2g0k=; b=Po1h/DRIe/cCVLAtT0lqKQXlSkNxUSBIwgHvnC1V9ltk9/bwfqP79hccGx6XtXn8/U VMzl8o9aVUpmO2AAiIRdNJ8dIyMIVdcwp/QSL8cnnUr5qbLKSBnLdnpq/3OA/pBU6H4Z F9lwL2ogNgMiKnlVbPcj3IESE9CPXQb45ORh3TcJxvUVcG7e/MDyrN0eHWC7zUO/v/i7 Ij+1vqR+jHvGKECRzEQuj52oBJT1LIAwfndUs2KQ1Q5WsMrygDMyGf143+Prp8hbESqD qeRGPLzxytufsITMeO/l97qYKY9jvoJcKK8H9njxPdU9dzqGeFwcItPyBmlhuszKIlOw i+xQ== X-Gm-Message-State: APjAAAXkfi0PKXfGCpn6TiJjI/WkiNDNvuR8/IB/eUgmiAIp5eE8q0kA 0e4aE9HyhHmloW1Zg/UXPBA= X-Google-Smtp-Source: APXvYqx2sf/5G6XEAQLPnYoP3aPIJx/DdisWe9aIAfjwrw/I3/Pkcxkq001SeB6WnP6uvcONdYmUUA== X-Received: by 2002:a1c:e007:: with SMTP id x7mr33818108wmg.3.1575467472795; Wed, 04 Dec 2019 05:51:12 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c17sm8092817wrr.87.2019.12.04.05.51.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 05:51:12 -0800 (PST) Message-ID: <86964b5e0299150975d6cf7b68e5a6347cc98ef6.camel@debian.org> From: Luca Boccassi To: Xiaolong Ye , Ferruh Yigit , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, iryzhov@nfware.com Date: Wed, 04 Dec 2019 13:51:11 +0000 In-Reply-To: <20191203155922.1565-1-xiaolong.ye@intel.com> References: <20191202061442.56964-1-xiaolong.ye@intel.com> <20191203155922.1565-1-xiaolong.ye@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] kernel/linux: fix kernel dir for meson X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, 2019-12-03 at 23:59 +0800, Xiaolong Ye wrote: > kernel_dir option in meson build is equivalent to RTE_KERNELDIR in > make > system, for cross-compilation case, users would specify it as local > kernel src dir like >=20 > //target-arm_glibc/linux-arm/linux-4.19.81/ >=20 > Current meson build would fail to compile kernel module if user > specify > kernel_dir as above, this patch fixes this issue. >=20 > After this change, for normal build case, user can specify > /lib/modules/ or /lib/modules//build > as > kernel_dir. For cross compilation case, user can specify any > directory > that contains kernel source code as the kernel_dir. >=20 > Fixes: 317832f97c16 ("kernel/linux: fix modules install path") > Cc:=20 > stable@dpdk.org >=20 > Cc:=20 > iryzhov@nfware.com >=20 >=20 > Signed-off-by: Xiaolong Ye < > xiaolong.ye@intel.com The convention used by upstream and all distros is that kernel headers are in /build. Why can't the cross compilation case also follow this convention, rather than adding complications to the downstream build system? --=20 Kind regards, Luca Boccassi