From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 011B642AF1 for ; Thu, 18 May 2023 16:43:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D1E0240E25; Thu, 18 May 2023 16:43:43 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2078.outbound.protection.outlook.com [40.107.223.78]) by mails.dpdk.org (Postfix) with ESMTP id E57B54014F; Thu, 18 May 2023 16:43:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPJ8qi09Ntac7M9V0rNAa+y4QTdvNYuAhbJ738oLJO63UBH554Vu3b/jMepEKyX0JTe2UZA2BJ1jmk6dBjDmN12Q2XB0ELrSmnhvS5GT4HxJIIr/wqrCqRj00ZfXJipznR2hFg24vLMo8bTvseLpWIKhbGukHnRAfnUeBq9VNmRF6mTpoQ1c8vN27sLij75k5G7sDGwSfqVv+yO+m8KKLP4SMo6O72EmoEMe4HgrHPqDjh5uE2BnhdYMQhMuYsV8CMVzJOgmMzM7WzOnGZNnbgs6pbs/EsDdGKL93lc4MpswAtM32VxCTW4AJ6duzuyRER3Ru2eLhR9YZTb5BGSLQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7C8tG+aApbfiCmiFcWMxXzOfozoLj/Yo0Je2J4tfEjg=; b=EbRH3LYUxRMS8pRsaq7ovLWaJBuGrtt66e0EGQdFCW+eJ5Dw1NfPH7on14ztptSn5CejmYTM0nKfwY0m7O6tZakfohnTJeIZDjvcgLMFdMXiK54YHcsb3fEsSj26wA7wZwt3sHV61OhQH0aRi/HDKIjAO0UOm30j4QJCsufLm2JyMkvzT1jbeEax+5NTIYfac06NTrhtTssdA9YxueceX/+kPZK2+MfG9B3J8pxMk+jHGxEuwzFNXzkdVHC6YojII6SfGM/AgXkJlGkjm+fqDlEitvUEd6vpUhoHadhAfHCHkeS7l7RKs9WA3/pBrD81lfqHVU3RSyXLesfdI6EsuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7C8tG+aApbfiCmiFcWMxXzOfozoLj/Yo0Je2J4tfEjg=; b=qzqkysdLottQVWRdNii35SB6CMe9P3FeilI+TKbbHJGU/F1gLUX7z8M9eAiAL+4UFqAJN6E8qdDt2X5iDyp8SGqsWWPeZvjkSv3Uxss80fY4gISERzsqQ3P2d3th3pMcRETv/MplWYwODOWgF2bXNT04CbAeLWVdyy0qNWEV8Ko= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4972.namprd12.prod.outlook.com (2603:10b6:610:69::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Thu, 18 May 2023 14:43:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Thu, 18 May 2023 14:43:38 +0000 Message-ID: <8722f87a-d068-6334-1231-173394332064@amd.com> Date: Thu, 18 May 2023 15:43:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2] net/nfp: fix the Tx descriptor free logic of nfd3 Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com, stable@dpdk.org References: <20230512020712.616206-1-chaoyong.he@corigine.com> <20230518110247.1559733-1-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <20230518110247.1559733-1-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0443.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4972:EE_ X-MS-Office365-Filtering-Correlation-Id: a200edbb-a5a8-44b8-90e9-08db57ae4454 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1hWQy6qhYFth5Zvc5FRcvmeXXEzghrYKSIa5xGT/+P3ay6W1ZQ6519QAPQhNgFgpM9qGtpdfssDAb7zhgbW6GwhTvWa9HNmI36iarLxL9Wlu8M1ICnnjXNCIeW/+Ab45zhTKNPdeIzBGBBZx4XTLdEKbc6+s5ydbw5o4lmKAoXwjABI48mRGSdmp1J5KTrIxjjrD1/oHLUR30fNKeZr6cMVJutf5qoo8XNaFiw9pp1/SAyLHCq7AwyfOGn+n95QeMwj6da5KEb0gDcArSb2rF2gBJNqz13Zpxjq6Qb2rC5IlrJhkowDGGW+PEsEW5aJE408aJlg0o4eKeAZg/+45erlMMniWnPNur03AACp0KUIIPUc+1G0WI+io0DveffSnX83gJ1lCNhwXARJkFUFzKreVRvphvNWhBYKpQrOPS+i8onmruvr4V3ubDAHqBn+mwfYpqYfmeX+gKfXzfJlA8XBpph4KkYmxL3pfsA+kYFTmz1ZmfhJARuXPjFz4bqONEdPhCxXVkwU7kSZyWzYnLzHL4MbT/m5nIC4KTwAkfZpTTMYf2mz7CUB0US+b5pVRTK2BTDcUL+zx0m69OEwAxdwWInHYmyKIx9Vsj51ACgfzsmxY0TU+ED2G8qi7yeHuiB7Z0ZdFhbemRrKNHqxeeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(346002)(39860400002)(396003)(376002)(136003)(451199021)(31686004)(8676002)(8936002)(2906002)(4744005)(53546011)(316002)(38100700002)(41300700001)(66476007)(66556008)(31696002)(4326008)(86362001)(2616005)(66946007)(6486002)(6512007)(6506007)(5660300002)(26005)(6666004)(44832011)(36756003)(478600001)(186003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXJZSFo1SUdnRE4yUktyZytLYy9qbkVjN3pVK2JMaGFsQ2tWMXRhMFE3dVJu?= =?utf-8?B?eDFqR2lNL0t6aWl4UmFxQlI0R1hJSTZYeng0cFJnVWZlY0VTditsUDFVYzhk?= =?utf-8?B?U2ZxMkh5NFlrcTVaY04zWW9Kc2Zwa3FZYVpRSzE2THB2em1Mc0UveTVjakY3?= =?utf-8?B?L3FGcWdqWXJxaHdDUk9SNWpITnUwakh1cUoydUs2dmIwaU9rTS9LbmV2OTlx?= =?utf-8?B?bW9vZCtMOFBjUEV0NWdUWG83bXhIdkR3enVRV2k3OWVGYWUxaVdKRERvODdO?= =?utf-8?B?VWVBdmt5bDJsL2o0OFBtWkVaSnM1eThNT0RjTnZBYXdZRG05WXQrUHNlWXUv?= =?utf-8?B?cUd0Z1NhdWxvdTRpWEM3UHhiNldJSDBtdVp4UHlMWmx0UEpFb3dwTU1BMWFj?= =?utf-8?B?ZjdLdXBXK20wT2pyYzFXcjJFQUFkb0FNYWx4aTdZZVJIVjVPYjNQbGFZOHEr?= =?utf-8?B?cnE4WHh0WFJpbDFaMmRZUEIwaVlhazNKbjRVeUF2bVpjbjJsR0NjV0l1ajMw?= =?utf-8?B?RmZUQm1ibXJqNUNyZnBVV05nZ0lVVjBMWk13QWt1OS9LYUpvK0lPS0NNVGdN?= =?utf-8?B?Z0UzM3BhcU9JRjlaeTdJQklaWStVY3ZHOEt2aVQrVVJKM1BUdHhPVTR5S1V1?= =?utf-8?B?eU1LaGNLVzRQU2gxYk1DdkhYRzJicUN3YlIvdnllbmZGZ0F3Z21YcHRYamFR?= =?utf-8?B?WTV6OTFwTWxoNnJmVGpubFhPNXZjZmFJN3ExOTNrMXdSSkdGK0dzNnBVbnEv?= =?utf-8?B?blBWNlV4ZEFMWldTQjdCanRmMFZad2puT0RqK0VvWEJ1TlpDWjQ4T0tncS81?= =?utf-8?B?SWhQVVNYT2tJd2dUbVp4eDR4SU4zMm52eGxXcThVTVpvb3RiT21YYWJRcTlT?= =?utf-8?B?K21HR3B1VTFiejh1UnlxRGFqMFQwNlpkQm1PZTN4K1J5Tlh3aURnSUtPY1BH?= =?utf-8?B?dzdWS1g3OGNIQXNDbzZkNlBVdnlLeVRXUWFaT1BJOUgybUZVSEg0V1pmdDRI?= =?utf-8?B?RnN6Q3VrVkl1dzFZdC84V2tIRm9GQWV1bDdXejh6RWpLNWJWR1RTM1BmOWlh?= =?utf-8?B?OVRmaHpjNEZtWll1N2RIcDIzR1N6YU5rMmJyZmNrdzFhdHBRYmJnQm1TOW1u?= =?utf-8?B?MTlHQ1BGMmpCWXQxcUxVOTMrSG1pN09tRitHTmQzMml5SGZOaEpYRCtTc2p0?= =?utf-8?B?dWFGbHV4OE1nT2JBcHdQdVh0bkptVldCS0JhdkU1MERvbUlnSGpYMHJpWGNx?= =?utf-8?B?OTV4THBnMEJYUWhNcWxZTUJIcWRZMk1VZnJlNFNDNS9XQ2J6TkNzTDVIdi91?= =?utf-8?B?MUk1NE5IalNVeWRWRWlHVERrdEd0Ny9kWXBHYlpGQjZKYUtwalVxWlVKeGJP?= =?utf-8?B?UEpqamtBaXR6MlRCZVVrK09tbTVBSFdEUHlQSFdnTjlIeU8zOFZpdjJSOW5a?= =?utf-8?B?MkJOZWFHSTk3d294UG82cXh4emcrNnF1dDR5UW9lcm9OT0JUckhCTFJuSExF?= =?utf-8?B?WStmc3Y5RlRsS1NoN1krU3hqTTAxdjVpR2lLdjY2NFZ0a281eTNBaTYzYVBj?= =?utf-8?B?aWcyNGhaWmJpZWxxZ1dGb2cyQjN4dmpDMDhqeGl5aTZUa1RnR0J5SXZpUmh5?= =?utf-8?B?YTJ2MDlJTTgxVWxKNGpETVFQc1RFU1lrUmc1SGI3bmNWUUpBeDNWanE2ZFZV?= =?utf-8?B?dEt2cndOb2ZvTHJVOVh5WHQzRmxHaFMyT0t4a1ZGLzRiaVJBQlFqMGREUzUz?= =?utf-8?B?NU05TXQ5Tk9SbGtFM0s5TTRRa2N0YlEvSHNjbThMOTJ3b3hZeDNnWmxobEIy?= =?utf-8?B?dFI4ZGJNUjBJRWh4aU9zOEwyTWZINEdFZE03a2s4bjd4K1pickZ2YVl2T2pX?= =?utf-8?B?Mkt1V0NzWklWeUdDS3U3MC8zU1BqS2FObVJmbFpxUm8za0RFZzNncnYwVE1z?= =?utf-8?B?MzhqZDJtVUtaclZQYzdzTFU2RmpwcGE5bGZ0YU44bWRKTUdkTjJyNEY2NkJo?= =?utf-8?B?R09DaEcvRFNiSmJLS1REUE91K0lSRk95S2tzcU5mK2xDa1dKOUY0clNZbzMz?= =?utf-8?B?V2sxQk1zUVZjcE96TE1ENTB4VTYxUWhnTysrTEZKb0hGVEVkaTNBSXgvVlAv?= =?utf-8?Q?II1bPl/OliBgFCa9qELmSy7pY?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a200edbb-a5a8-44b8-90e9-08db57ae4454 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2023 14:43:38.8173 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xZ3vB+rx5n/44Mz8Vw54IvZvj9JJdcg+Ewh63vHXKGX9alOC8Ly6CAX61pWPIY6o X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4972 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/18/2023 12:02 PM, Chaoyong He wrote: > In the Tx descriptor free logic of nfd3, the former logic might force > cast a negative number into a very big unsigned number, and which will > cause potential problem in the xmit loop. > > The xmit loop will continue in the place where it should break, and will > overwrite the Tx descriptor which is not free to use by the PMD. > > Fixes: 74a640dac864 ("net/nfp: avoid modulo operations for handling ring wrapping") > Cc: stable@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Niklas Söderlund > Applied to dpdk-next-net/main, thanks.