patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: John Daley <johndale@cisco.com>
Cc: "johnda888@gmail.com" <johnda888@gmail.com>,
	dpdk stable <stable@dpdk.org>, Hyong Youb Kim <hyonkim@cisco.com>
Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak
Date: Thu, 4 Oct 2018 21:35:40 +0000	[thread overview]
Message-ID: <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> (raw)
In-Reply-To: <20180928015105.14831-1-johndale@cisco.com>


> On Sep 27, 2018, at 6:51 PM, John Daley <johndale@cisco.com> wrote:
> 
> rte_flow structures were not being freed when destroyed or flushed.
> 
> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
> ---

Hi,

Is this patch only for stable releases? If so, which one? Or was dev@
absent by mistake?


Thanks,
Yongseok

> drivers/net/enic/enic_flow.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c
> index 0cf04aefd..9b612f1d5 100644
> --- a/drivers/net/enic/enic_flow.c
> +++ b/drivers/net/enic/enic_flow.c
> @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct rte_flow *flow,
> 	enic_flow_del_filter(enic, flow->enic_filter_id, error);
> 	LIST_REMOVE(flow, next);
> 	rte_spinlock_unlock(&enic->flows_lock);
> +	rte_free(flow);
> 	return 0;
> }
> 
> @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
> 		flow = LIST_FIRST(&enic->flows);
> 		enic_flow_del_filter(enic, flow->enic_filter_id, error);
> 		LIST_REMOVE(flow, next);
> +		rte_free(flow);
> 	}
> 	rte_spinlock_unlock(&enic->flows_lock);
> 	return 0;
> -- 
> 2.16.2
> 

  reply	other threads:[~2018-10-04 21:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  1:51 John Daley
2018-10-04 21:35 ` Yongseok Koh [this message]
2018-10-04 22:03   ` John Daley (johndale)
2018-10-04 23:40     ` Yongseok Koh
2018-10-04 23:45       ` John Daley (johndale)
2018-09-28  1:58 John Daley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=hyonkim@cisco.com \
    --cc=johnda888@gmail.com \
    --cc=johndale@cisco.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).