From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10049.outbound.protection.outlook.com [40.107.1.49]) by dpdk.org (Postfix) with ESMTP id 992F95B3C for ; Thu, 4 Oct 2018 23:35:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nY32WW+UAMO0YPrb9E6tA1GNIXyfK0QEFTBhyy6TYuM=; b=yQYWpk0VlAKE0Ml4nV9Xay9BX6YQcf07yjAR10WaJvATCNeM688xpiI0bjawvcvkYcYicZuCEp+y/ZyUp5oowX2DXcigKzwBoQizGdXkf0JFL28WJlNBH63N4JOT1vGrmRfbx7MMZM/8vq2zwi9/D0zV5/08ZhWvqdqgkTCDsv4= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3994.eurprd05.prod.outlook.com (52.134.67.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1207.18; Thu, 4 Oct 2018 21:35:40 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::1cb0:661b:ecab:6045%2]) with mapi id 15.20.1185.024; Thu, 4 Oct 2018 21:35:40 +0000 From: Yongseok Koh To: John Daley CC: "johnda888@gmail.com" , dpdk stable , Hyong Youb Kim Thread-Topic: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak Thread-Index: AQHUVs28u8F07/UK4USepZTxZWA0wqUPpseA Date: Thu, 4 Oct 2018 21:35:40 +0000 Message-ID: <87F2CBFF-E31E-4C6A-B64A-D94030B1B258@mellanox.com> References: <20180928015105.14831-1-johndale@cisco.com> In-Reply-To: <20180928015105.14831-1-johndale@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [69.181.245.183] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3994; 6:lN1NBvXimjhwGHiKxaWSVXePHS7AnVx88bspPTJh7GkBkhAfmtO6pxFB9ia8wP7iaaNd5EpXVJjDsZVtLNMXO5dLsC8fnIptPrK9lCUYAJkeQEB7PmCGgX4+L51mcMFG7ztmqz3IPozrzKit7lQonBQs2tDU4MlfSOBA8wMaMOnk0rxQQuU9NS/nsHQf1cm9WmqURWy4RQdEhv13+893Wf7LD57mLocyGVDwsh1QmV74xdD8iixIi96nLdNCJo/u4+x2zNMZ0HH6xoqbZVsAj809pzeIGF9/66zQ4emlg60VxoLZSHLh00vRRoDhCUo0dx1rR0OXs7VVRa8dNPz1YiIeHGAyJFb4wMip4XHe1QwzlVvYRbyFaI2X7EOPnazRRNBy729AV387QzjJL0eAqmsM0LbYTOmf3Lk/qu6aRqST6CDyQYBTnlDn9vJW3fxfaqUZpxKu0OmtVng55cvAHA==; 5:R7KoZlEe8RvyS3FGOprUtlh5v61iSurHgUeZB9VuyA/P7tSu8ggtqJ98T/2WhLVJV8xt4CFPfFmQqen0G+Y9CGZxFY7MoMbJVr8i961JXudvaau3FTfBlC8TvJFzebsYYtCPfHz3khZXTbccxi9MP3fyOoY0oynXgvnVQ/aotLQ=; 7:457W1c8EHpUDo7fYYUUsy53qO0H4Xwa3PKdnPaVRwirBZwQ5VaSAPfG3kK6gozWeQPdlkgiXm8cbbU2bFd+glihtHqBkBmfwfUAtQ8VPzOWdfcNKnEUqj4NFtXShxU3Z0/2Ri+adg6VECxYYog5deLnrZTEcZEBZZqJOJDsncW+1XWUZ0YOw6XpgKz86hbmRf4rIJZQ8xhw5bBWADK2NmfTL4Q5SXtUs8WEt/dxYMCB5y48AGOrgI2UpT1CKamoN x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 4ecede4c-4b54-488d-c612-08d62a4154d6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3994; x-ms-traffictypediagnostic: DB3PR0502MB3994: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(95692535739014); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(10201501046)(6055026)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(201708071742011)(7699051); SRVR:DB3PR0502MB3994; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3994; x-forefront-prvs: 0815F8251E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(136003)(39860400002)(366004)(189003)(199004)(86362001)(71200400001)(2616005)(71190400001)(11346002)(8936002)(53936002)(102836004)(81156014)(8676002)(26005)(446003)(186003)(476003)(68736007)(81166006)(54906003)(7736002)(478600001)(5250100002)(33656002)(316002)(3846002)(83716004)(14454004)(486006)(305945005)(97736004)(25786009)(229853002)(6436002)(2906002)(4326008)(5660300001)(82746002)(6506007)(6486002)(6116002)(105586002)(6916009)(39060400002)(6512007)(106356001)(2900100001)(256004)(14444005)(99286004)(66066001)(6246003)(53546011)(76176011)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3994; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: /sm/jjXYgqXkoWhde3jVjxM7lY8gl2owVSL5VB2s5fzrHOFdA8GUmAg82QMCIX8NfFj0/knvt/MAfLOYcHOY5RE9KqZgUYd0sHakylhHm22zt9JVk2war2etwhKX/+WoN+MpEmfDlIngfEbtWGxMoOLCaLBX4XH22kHpm3a5Khk0AX/jp3QVUsj9fzTD4eyIhBFwYx6f6Qb3SJ3PaXKHbi4gjMD52e2EDDD8jLprJUJDAFIyKUD6sQW8viS3U275cn28bC/vSj3dyeIKyophSHtOK59WCVeh+vFO+vh9/VKpSbjRj3mEbPJEvuWrX2nG6ZjyJqc9F4tVAhTT3pEsZxfHTzhzzEXC7Q/FFjezpHI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ecede4c-4b54-488d-c612-08d62a4154d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2018 21:35:40.2064 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3994 Subject: Re: [dpdk-stable] [PATCH 1/3] net/enic: fix flow API memory leak X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 21:35:43 -0000 > On Sep 27, 2018, at 6:51 PM, John Daley wrote: >=20 > rte_flow structures were not being freed when destroyed or flushed. >=20 > Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters e= nabled") > Cc: stable@dpdk.org >=20 > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > --- Hi, Is this patch only for stable releases? If so, which one? Or was dev@ absent by mistake? Thanks, Yongseok > drivers/net/enic/enic_flow.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/enic/enic_flow.c b/drivers/net/enic/enic_flow.c > index 0cf04aefd..9b612f1d5 100644 > --- a/drivers/net/enic/enic_flow.c > +++ b/drivers/net/enic/enic_flow.c > @@ -1532,6 +1532,7 @@ enic_flow_destroy(struct rte_eth_dev *dev, struct r= te_flow *flow, > enic_flow_del_filter(enic, flow->enic_filter_id, error); > LIST_REMOVE(flow, next); > rte_spinlock_unlock(&enic->flows_lock); > + rte_free(flow); > return 0; > } >=20 > @@ -1555,6 +1556,7 @@ enic_flow_flush(struct rte_eth_dev *dev, struct rte= _flow_error *error) > flow =3D LIST_FIRST(&enic->flows); > enic_flow_del_filter(enic, flow->enic_filter_id, error); > LIST_REMOVE(flow, next); > + rte_free(flow); > } > rte_spinlock_unlock(&enic->flows_lock); > return 0; > --=20 > 2.16.2 >=20