From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F029A04FF for ; Tue, 22 Mar 2022 10:18:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58E24427ED; Tue, 22 Mar 2022 10:18:38 +0100 (CET) Received: from mail-108-mta154.mxroute.com (mail-108-mta154.mxroute.com [136.175.108.154]) by mails.dpdk.org (Postfix) with ESMTP id 695C3427ED for ; Tue, 22 Mar 2022 10:18:36 +0100 (CET) Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta154.mxroute.com (ZoneMTA) with ESMTPSA id 17fb0ebbab3000fe85.002 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 22 Mar 2022 09:18:33 +0000 X-Zone-Loop: 2721e2433faa4356fad6c8eef5a0575c7c4c05662e2f X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Type:MIME-Version:Message-ID:Date:In-reply-to:Subject:Cc:To: From:References:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FVnT9t74D1Zj7Q5NCx5BItRyMzMl3zMTawtlFeNvZ+M=; b=ZQ8jiAd8tpOlwnJSQoltBmADeK 8S0AhP4hkael30F3zplFwnPzon911X4tFXtzTCttPI2djCrB7NaPCkOMksRYAGz6a0dgmb6qjrAle STg7QQAXf/U1PKyWGa8zi6YdwSeJysrr5Dci73DAQDeeMaFfwQJNpY0hV6uzUAEeqZSUN2TOgcLMm zS0FB493VXts7+V+zfnO0326HO5eD3GOb9Ix9iNW8YWTWaFYmJ8Iyzqi9m7m4qXqwyc+PjjeHEh4r xuswwB9Il49dwLVn+Q9aajt/fgaS6Qgk7V7RaZDZ4GoU4Y6KErusr1kTYeLJibrzKPuaZe/+ZQdzX 9Ltt2lWg==; References: <20220218123931.1749595-122-luca.boccassi@gmail.com> <20220228212047.3341966-1-luca.boccassi@gmail.com> <20220228212047.3341966-14-luca.boccassi@gmail.com> User-agent: mu4e 1.4.15; emacs 27.1 From: Ray Kinsella To: David Marchand Cc: Luca Boccassi , Kevin Traynor , Christian Ehrhardt , Arek Kusztal , Akhil Goyal , dpdk stable , Thomas Monjalon Subject: Re: patch 'cryptodev: fix RSA key type name' has been queued to stable release 20.11.5 In-reply-to: Date: Tue, 22 Mar 2022 05:18:29 -0400 Message-ID: <87sfraqra2.fsf@mdr78.vserver.site> MIME-Version: 1.0 Content-Type: text/plain X-AuthUser: mdr@ashroe.eu X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org David Marchand writes: > Hello Luca, Kevin, Christian, > > On Mon, Feb 28, 2022 at 10:21 PM wrote: >> Subject: [PATCH] cryptodev: fix RSA key type name >> >> [ upstream commit 3387912f5cacd934594f2c7a0c34eda7279419a8 ] >> >> This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, >> this will prevent checkpach from complaining wherever >> change to RSA is being made. >> >> Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") >> >> Signed-off-by: Arek Kusztal >> Acked-by: Akhil Goyal > > This patch triggers a warning from libabigail in UNH tests for 20.11 and 21.11: > > type of 'anonymous > data member union {rte_crypto_rsa_xform rsa; rte_crypto_modex_xform > modex; rte_crypto_modinv_xform modinv; rte_crypto_dh_xform dh; > rte_crypto_dsa_xform dsa; rte_crypto_ec_xform ec;}' changed: > type size hasn't changed > 1 data member change: > type of > 'rte_crypto_rsa_xform rsa' changed: > type size hasn't changed > 1 data member change: > type of > 'rte_crypto_rsa_priv_key_type key_type' changed: > type size > hasn't changed > 1 > enumerator deletion: > > 'rte_crypto_rsa_priv_key_type::RTE_RSA_KET_TYPE_QT' value '1' > 1 > enumerator insertion: > > 'rte_crypto_rsa_priv_key_type::RTE_RSA_KEY_TYPE_QT' value '1' > type size hasn't changed > > Error: ABI issue reported for 'abidiff --suppr > dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 > reference/include --headers-dir2 build_install/include > reference/dump/librte_ipsec.dump build_install/dump/librte_ipsec.dump' > > ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged > this as a potential issue). > > This API is experimental, so changes are acceptable, but we are > missing a suppression rule similar to what is in the main repo: > > ; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental > [suppress_type] > name = rte_crypto_asym_op > > > Note to Thomas and myself: the next time we clean those rules, the > suppression rule on asymmetric crypto should be kept if still > experimental. Might be worth adding a comment to that effect in libabigail, lest we forget. -- Regards, Ray K