From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9868941C31 for <public@inbox.dpdk.org>; Tue, 7 Feb 2023 15:49:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91C75410F6; Tue, 7 Feb 2023 15:49:02 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by mails.dpdk.org (Postfix) with ESMTP id C97B74021F; Tue, 7 Feb 2023 15:48:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oFG2ENW3C6Mx1YoX64rYkTZvXiT0wwI0S6xvkvekhJNWz2RXD7kolsp9zPhPbw4kxQosatcskz1Q9srcETmthgmrAF65LPz+5fmdGruhE6oWkD9F9Z2RDhph9BBxHJ72Xy6mfjtiB31pwrPGeNyi/91Uy1N7T7Fl7tSpuL+IKk+SIttsfB3Itbq5hofkeDI0FU/gsbz+WF36wRXyS3cvMzI7fPOfTez46NURF01OWOqM5uKf0K8Wau27R1AKLGU8cS3yA1s03Hwn1inlzrcpXbG34ZJVJHa4LPISCxYp7CJr1VAla2GYZisFRJLQDvHhwGQG3hkWLr28TWWyuvpaiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ix3QtjWZxdznVzoycvNJ0xW3FewQB4AjIIINtiMGogg=; b=BuQcthdhiuTcPBP6+L+DR4q4ONKdSz9kh7hDfnDx/wmJw7zDg6lTR6qXRLTA3PSKpTN/HVriNKWe34wWXTixlphkhmplw7wO0P1Sq2KtC/HQ1CIjkDRSIWMXfAYN1Vco1IGG/IMf9kacHcx6/6enXV14YBwNd07sL3Lc66k+mhnkh0DdWlze+4DG5fkFgXtvf+Koxl7sJqUmKyBufhDBnosU25CKoM5cTe3Yo5RWrH5M/7p96TQtaAzPjWgWfVbV6TATD5xvUJiO9ZKyAaF3ouRlKwvPs8EehrGxC+GoLcEZ/E5IO8wSFfmhSxGL9j1O7tCCVGiegUXOzmJtZOJt2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ix3QtjWZxdznVzoycvNJ0xW3FewQB4AjIIINtiMGogg=; b=L2G2+0Xx+tfNhAENTe+F9347iFmDmTYVDNwuDUSmU4cf9Ag5QCfoqW2VXJ9NsprKmrS8eiiAxwfcL26jgIKaqftu9Y+YC1dqLIlYKUahSYfj2663zYU/jUnjgCvR7i/voGMtHIWYyrWtmHfrayV8R2lnhr0+RWkJrVqJq2lRbPk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB6728.namprd12.prod.outlook.com (2603:10b6:806:257::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36; Tue, 7 Feb 2023 14:48:58 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 14:48:57 +0000 Message-ID: <88a9871e-c202-b778-f2cc-2e755a3b3770@amd.com> Date: Tue, 7 Feb 2023 14:48:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v11 0/3] Fix cmdline_poll and testpmd signal handling Content-Language: en-US To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org Cc: stable@dpdk.org References: <20230130200914.22049-1-stephen@networkplumber.org> <20230203191409.97567-1-stephen@networkplumber.org> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <20230203191409.97567-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0024.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB6728:EE_ X-MS-Office365-Filtering-Correlation-Id: f73163e0-e1a4-4f84-a6e9-08db091a7117 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 956rqqjdD9GbDyXGXqWDVm5WWNX9dXaEKy4VmGyGnvdH6eq8JIkPwAb2+28Xu1s5lKr2VLKYx9QlufH5UoPPamgom72ePXqbQFviQNxl+LlonG0aCl8XYkM6VzJWHpe4ZyR38+tAiaJjs7Yai/b8q5F8PhcKqG3J5Q9oHrdf+KM5H7vpE8fSIAfaCjzwpvT3IVn4UB3BSahy9u2CTvAorU0D5/W5Yr5iCUojsdNfdVZuyRmPRkX9D6JoOVgGJWwjFP7j5s6AYbapmKCsFiWThYGa2rqFa70e342RgyG8nStkEp7uNVHBQFJ+3ug+0BQyii/+yANYBYJVLxS2m6emVUZwcPG/WogW2RxigxPpRakCZgrnNUE1RjTfVBJWcH7614PjeRNNldbVMHB+VBpeTiXQgRLpsGL8LQ6RCdRoROskYcZLFZ99soKL+aMwiDH+JY7OTCDapnsiVPhenyGQKQyS22T5FXiyg8fR2r38Je/41Spk2at9RAtyDSVRb8S8PdbLGlMR92AE/wIyUTLpRAdENfv2jeYDWSety2LmfvQq7YwZNSEuE21ZKlNNOTRvzj3D5ONfwfYdpwF476ykQ4/pbXuuvD96Ip4o1OF7C2E6FD1RHsyZ4h3rFzsqp7hZaNBtjzwBVIP6zpyktl77D9E20UJFCTKcTP6AFxH0QytxSAtkLxyhSPloK2UNgrmX1UNh9zcAF8ONxY+FSCBIHiXFi6iEG3TmQbhrELKIJjI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(451199018)(2906002)(38100700002)(316002)(4326008)(66476007)(8936002)(66556008)(41300700001)(8676002)(44832011)(4744005)(66946007)(5660300002)(2616005)(6666004)(53546011)(6506007)(6486002)(26005)(478600001)(186003)(6512007)(31696002)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QkpQWlpHc2NPRnIxS002eDhBUFh1cVNLWm9sU052a0MxL1k2THptbTRpSWxQ?= =?utf-8?B?bjA1M0FFOUFUYjBZNW1XUUI2ckdZZmh6RW9UYXA5eUdqZzZwMEo4ZFhBMmFE?= =?utf-8?B?bCtKZE14OEVXQVI3UThzYk9WMkt3YjIvbVlmSHhWVzg4QjMzRFdjK2JjQ28w?= =?utf-8?B?OTBzUW5EQlZQeCtpemF0TGVScDhrclNBanoyTGR3U2pEbEdKZWFlL3Z4S3Jw?= =?utf-8?B?c2RtUmJuZ1FLS3RDTnRIMGw4Y2E2aVFTc01NTmlyRnlnMzllTkxUNVJMVnB0?= =?utf-8?B?WjhReWxzMHRzQlNCOGEydXFIUWt0ZUFRckRsdlEwVFd2cm9LVldONUdtVkRt?= =?utf-8?B?Y1k1Nk9XYVBHQ1pVejFwWWlGUnM0VGVYMVFKTkNPNFBnZnM5R3c1Q0ZIYkI5?= =?utf-8?B?RVFFclVHNCtvWXRtNnVIYkJaSDdiemhHc3dDSjlpajZhT1pOTms3SWxNRVY3?= =?utf-8?B?NmhJQkFrWU5JUXhkdWJDRkpxSXFaK3ZxNGxScisyY3B1Uy94ZVk0aFpKaXlY?= =?utf-8?B?ZkhheEZlS3I4emJEbUU5c1FoWjE5Z0IxUWMrSm5CU3RFVklMM0hsT2QwWFNx?= =?utf-8?B?MC9Nc2d4dTg0Q3FYZHZ1Vys3N3pQK0xzMXpXcHVaeGcvVzZxbThBVFJMaFVa?= =?utf-8?B?SmFhT3lXTiswa1FKYkZJd2RoUC9nY3U0VklXdUY2TG1RdG1YMTFwU3p4ODNF?= =?utf-8?B?bGF4OUJuQkRBYVR1WjNjaEp3ZzBWbHUvSkpMcmZCOGhYaEpKTCtUd1NqVktT?= =?utf-8?B?SGVmOHY0c3FjaERwTG1mbFJ3MnJnZ05JMGFzWnQ4L3pPN1VSTjBXRHoxbGFC?= =?utf-8?B?a3g2N0g4NE01U3ZnRFVxd3R4UWFkbTdwMWtKS0hUUGErOVFmZDhFdmdkRnRD?= =?utf-8?B?RmNrMktTdG13VDJpVklBalBCSERFYlJJY0xtclNNQzgvWno2M2FnbEtucWVD?= =?utf-8?B?bEVnS1M5YlhvN3ZXM29KeDV4aGxEZG8wTXRnSWxOdjdWelZrQTlXNEpYZUZJ?= =?utf-8?B?U3IyU3VrcmNGUEdpQjh0M2MwRi91TkJMb3J3ci9kRjFYMDRpRks0SVdlb1VL?= =?utf-8?B?MHRLQXk0L0dlYUk4dkNpbmxUYmxzT3BFMGEydUJxVnFCTjF3MjcxVlh4bDNu?= =?utf-8?B?blRsTGVQYjhiN1EyczQ3NHQrRFdvWEg1Rzh2U0tWc3R0NlRCbTdieW9jYUl5?= =?utf-8?B?clBkMkNIZmJ3UDZaVVNlN25EUzQyVmpqVnVna1JiaU9YNUtibjk0VGgrY2ly?= =?utf-8?B?dE9UYXd5UlY2aUtPRFAycUtkUFBXNmJVZ3MyTEpEbUFPZHZ0NXNuMzZpUndM?= =?utf-8?B?VmFNNjJGajN2MWFqSEhhZkc2NWVaUC9pS3oyWUl4ZFpNdHhoUzVVSExBam1n?= =?utf-8?B?ckR6WjAvVW1xdjkySklxempEYU1mTjZOVGh6b1dUUWUxNCt6UFAzaFNHclFl?= =?utf-8?B?VWdmWkI0clFGeEdkUndodlNCL1dEMHlGSXFWSFB0bjMrYjhWcStWcDZYSktQ?= =?utf-8?B?Y24zMHVKaWs1WmNrdHZXdmMwMldUeHZkOUxsZkxURnR2bzVqcjBOMUhUNHZn?= =?utf-8?B?dC90SXo5TXBlVDhuTUowcXU4eUV6Y3IweFY5bE5va0x6NDFtSWgxaTAwSXl0?= =?utf-8?B?TjJmQ0gzTXZ6MnpzWGxoM0NlOVoyYVVsUzV5amFVa1dKd3F0ZmhJWXRBYXdm?= =?utf-8?B?S01jUVRNVzZON2xYczIyNXNZckFHaEp0Um1QaXk4SkFBQk4rTGsxMHV4aERC?= =?utf-8?B?Qy8rUzRRTVNidHZ3cXRWL0ZqNjhuOXgvWDMraEJGZmJNWkZ4WStIVEVHWjBp?= =?utf-8?B?b3I4S0VyVlEyQ2RYbGxVT2o1RFN3RDI1QmVMZUtQdU5VS1NiaXpqWVJ5YTl3?= =?utf-8?B?YjluTkVYb0pzUEo2eWlrR2NobVRKMWgrS1gyUjhaVk96aVIrUG9GL1BZKzdM?= =?utf-8?B?NDdNWHo2NkV1SDh5cVFpWVVPckg2RkNhbDhyeGVwOEZNUHViZFNieCtxaWRx?= =?utf-8?B?OVJTeE0zdlBrWG9aSnV0MHdaK1ExSjN5ZmVYUUIrNzVhNk1SMXQweEtlSEVX?= =?utf-8?B?S2t0d0VZbXJ2N1hEbUdjN3JBM1JnNWpOa2xNYzBMajVua2JGRGsrZ21SekRx?= =?utf-8?Q?+LBYEdsy0cP4zMhNy8PJ7U1Q9?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f73163e0-e1a4-4f84-a6e9-08db091a7117 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 14:48:57.8775 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wZK8bjSC7qZTYA4nYC91qkdaYEJS2u+EkXqz1eOf1HPkPzV6Q8XXyO7v9on6J9xl X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6728 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org On 2/3/2023 7:14 PM, Stephen Hemminger wrote: > This patchset keeps uncovering bad practices in the cmdline library > around end of file and signal handling. > > Stephen Hemminger (3): > cmdline: make rdline status not private > cmdline: handle EOF in cmdline_poll > testpmd: cleanup cleanly from signal Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>