From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D06C6A0350 for ; Mon, 10 Jan 2022 15:51:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C12E40041; Mon, 10 Jan 2022 15:51:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id EA15540041 for ; Mon, 10 Jan 2022 15:50:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641826259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YItwCvwRw3Cq7aINO8+9eugk1XQ78TihzPFL4IwvCJ4=; b=bEUJI2XSzTlgVwE3E4GsoBp7V2h1ssFwJRMg9AMXgJPmHGgCvkUONe5q3aUXu4yMd+rFcg AAGkzkimYRe4RMv6hsZxcAo2qvrDIU283SDz5Wvsc3nWqvzy/+y8xXQA7NVaZ7dX2Sk4Xl qhLDD28Uf9c7IhZEVlhe91VUo4hwpfc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-645-NmuqBVxBNQi-Xz_045kf3A-1; Mon, 10 Jan 2022 09:50:57 -0500 X-MC-Unique: NmuqBVxBNQi-Xz_045kf3A-1 Received: by mail-wm1-f71.google.com with SMTP id o18-20020a05600c511200b00345c1603997so2211100wms.1 for ; Mon, 10 Jan 2022 06:50:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=YItwCvwRw3Cq7aINO8+9eugk1XQ78TihzPFL4IwvCJ4=; b=KQPXckR4J8/QyDffoRxoiG6+wzcSwOgwYNbdM6OutdEIspJ12p79yRAO1UlHq6dbgk Hqm9xpkWSVFoUpQ5R/Hv+wleyTLR1+AMWIXf4XugeavBM0j2V5JkWLCzudiVMcw9tJhT QyrStePmu3YoKN8h5x63Rq8r61IrfYlEGUtyYiSCV5M+t3DDjUqYwAraRRrPZnsd0ji3 IKYssED8kY0RlCqz/QTECOmAlVGuLF3Ovm65VEzCathPffRk9TexbiLSzYs1XQUq9dwY MqzAqsSehLZ6oOy09TVyDt3EjqhAa36kiIBsien8LFt709uFsFvlNTaiIyRlOBjv9Gl/ 4nhg== X-Gm-Message-State: AOAM5311yLNY8uh8YppcSIRD1pJ3iq7oJmB5Ot4zrVu8EjndHDivUGls 5KFKFvWBJehMbZiCiKmfuX3TaASDU8Mm2/jBaysDigUjJV/Xp4RTtgc1N3riqQKnZsl+HzXpXcP VAew6rkA= X-Received: by 2002:a05:600c:4f08:: with SMTP id l8mr22994913wmq.59.1641826256753; Mon, 10 Jan 2022 06:50:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJy4qmjT/Nxqj2GL08EwmpVOr7m/O2FCeEhUJMr30DIyjFq5DHsYBzUOXaoDw7xrsv8J05oFZw== X-Received: by 2002:a05:600c:4f08:: with SMTP id l8mr22994896wmq.59.1641826256550; Mon, 10 Jan 2022 06:50:56 -0800 (PST) Received: from [192.168.0.36] ([78.19.108.41]) by smtp.gmail.com with ESMTPSA id r1sm7734287wrz.30.2022.01.10.06.50.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Jan 2022 06:50:56 -0800 (PST) Message-ID: <8984b5be-e87d-cb65-17fe-4ac248d5933c@redhat.com> Date: Mon, 10 Jan 2022 14:50:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] 5-make-release-commit: fix rstheader To: christian.ehrhardt@canonical.com, stable@dpdk.org, Thomas Monjalon , Luca Boccassi , Xueming Li , David Marchand References: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> From: Kevin Traynor In-Reply-To: <20220107095002.1253288-1-christian.ehrhardt@canonical.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 07/01/2022 09:50, christian.ehrhardt@canonical.com wrote: > From: Christian Ehrhardt > > The printf magic fails trying to interpret "-" as option and thereby breaking > the top level headers. > printf: -%: invalid option > printf: usage: printf [-v var] format [arguments] > > Instead of relying printf expansion, fall back to the more trivial > printf n times which works with any char. > > Signed-off-by: Christian Ehrhardt > --- > 5-make-release-commit | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/5-make-release-commit b/5-make-release-commit > index 374154f..00acf92 100755 > --- a/5-make-release-commit > +++ b/5-make-release-commit > @@ -29,7 +29,7 @@ function rstheader() > > echo > echo "${msg}" > - printf "${rchar}%.0s" $(seq 1 ${#msg}) > + for i in $(seq 1 ${#msg}); do printf "${rchar}"; done > # break after line plus one empty line > echo > echo > Acked-by: Kevin Traynor