From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50083.outbound.protection.outlook.com [40.107.5.83]) by dpdk.org (Postfix) with ESMTP id 3209D4CC0 for ; Mon, 3 Sep 2018 01:59:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XL08Toii8+HRiBXtXR5dJ/KtDGmfs0+gWLCmAkzPVI=; b=CJODc8gQT8QuO/R+8RjVXyIlhYlxjqSKUb6batpucsYbPZeUNTOuYiwFL4Ae94lDoHpZXpUOQUrjXFj2VqW2Wr2FvQkPH+dvqLWPVIcrpfbk4XtvT63vCdVFNeVfWERYSHS1o83kBGrR29DHLb1AmlulFOuD1HLGq8eUHIy1SCM= Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by DB3PR0502MB3995.eurprd05.prod.outlook.com (52.134.72.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1101.16; Sun, 2 Sep 2018 23:59:30 +0000 Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c]) by DB3PR0502MB3980.eurprd05.prod.outlook.com ([fe80::d45:8e84:6d63:c57c%2]) with mapi id 15.20.1101.016; Sun, 2 Sep 2018 23:59:30 +0000 From: Yongseok Koh To: Honnappa Nagarahalli CC: "stable@dpdk.org" , nd Thread-Topic: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined Thread-Index: AQHUQutHksvtrTRwPEy6+Zaj0UhVC6TdYOGAgAAHzUCAAENzgA== Date: Sun, 2 Sep 2018 23:59:30 +0000 Message-ID: <8BD04EEF-AF53-4990-9273-A0F737EF8F4D@mellanox.com> References: <1535913120-22426-1-git-send-email-honnappa.nagarahalli@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [73.222.116.174] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DB3PR0502MB3995; 6:M21AwOMwDI8O9tz2AbfwQWIy8Ogqij2A/mmGerNstUu8wJTYX6K1ElqizexAhnqFrAIVMRFsLAfjTg3ScoD5L4AOrg+05XLgMTgY0J0Ex5i7hyU5lG5wglbPiKQzcOvKyuShbF1tdUBCFO4a3qggeqtiMmAWD6tDBFyOdLVzPtcE4b3sVWRo0m8crBoW8RZTPesVEYhB8h+O/xiLX4sWaXDrHooSBeXwl8L9pcE9PHBZNI+CxooknNGWJfsywos38mrIaar70L3Yynyrg4FriQvWpj+k0wxPUO5WtwgrG1rAY6ds6X/m8uzyZpegQOe0YXSYBxL/HOWdSHFBybFEHiEvQwSOLZ91nvQcmovqWEd+Jkh62EVJ6smsC9NNep1E99BXnjI5ErpRAvosGjVLbfSPGTlIDn7thY/TsUVDVPE1wjh92TmB01PsCxNeTWoShYxwM6At/oHBXAseedNrIw==; 5:0CH/NYGnAoIN+vWjaG0ve0eDGnu99Uch29rsPvxi1DLa+ql8SaPpiUUq4IBHBfIl2R17JfVbfu7b1HQhvqYEqkQjBCIHZ8/Vd2wD8SmVNdYiJiVHlk4fCHYJr7YKxORBsAyix8kR5pBzzRU+w96amNMyNNznG2HTB/KOYyxQoxI=; 7:yPDhC7ZW9bG0WOzw9hksXztkAgaSFqki0dL5Dw9d8D0Q2aV7OFT7OenUPhNO0gMZq2/lrxvMHSVLeqXeWCl6LwSqOg/xrGUhHv0Y0RukwQucbTn+Amc4PGJtaHeut7U+CJ9pRDp0S2A4171rNZpdUR0nwZ3MViKA+GSnfPLFJaS5R4YWuirGysfq6/gt7k+yNjB+J84dPpx7+v7jClE2+TPHjpCV2VAQOgp6xLPMz1K/X5dlmFyogH0m1QuW2Nc4 x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: cdac32ad-863f-4708-751e-08d611301fd5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3995; x-ms-traffictypediagnostic: DB3PR0502MB3995: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(180628864354917); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201708071742011)(7699016); SRVR:DB3PR0502MB3995; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3995; x-forefront-prvs: 078310077C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(366004)(396003)(39860400002)(13464003)(199004)(189003)(76176011)(66066001)(99286004)(6506007)(14454004)(8936002)(53546011)(81156014)(81166006)(6512007)(53936002)(102836004)(2906002)(33656002)(83716003)(478600001)(25786009)(36756003)(6246003)(3846002)(6116002)(4326008)(105586002)(6916009)(5250100002)(14444005)(6436002)(106356001)(256004)(68736007)(7736002)(86362001)(6486002)(5660300001)(486006)(11346002)(446003)(229853002)(186003)(2616005)(476003)(54906003)(26005)(316002)(305945005)(2900100001)(97736004)(82746002); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3995; H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: S0NbwPcYOuUsyPya5Czxf/83RdU+Xs/SSNWeYMormqmi5/yLFtIWuUEuUFn88MSN1woGh6r0NI/1wCjQM3iGGE6cMXFefZGsaAJVHPnE+9/fCOCWMqoFHGIU9nGU6ZDeXZ2DQ7eKaGe196LJ/JXW4l6F+fAlGM3IPOgi9c/0ZMAJiXJlNXkVL/74nieisjqcBC7sd5EJZT8Qk23TAGj5naeGhVkhsYfeO9ZvUN5epKoID/3XRrouDlvEWmWNKQn0WVyByV4RlYnfTRNbV3m6C5MJTiByc//+gSfRdDknerLZjThrNENScm+CQPrGmN2lKzbxlDdjbsc2asuHpT34WNWCgz2Ys3zHYggL2JAGCyQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdac32ad-863f-4708-751e-08d611301fd5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2018 23:59:30.8478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3995 Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when __aarch64__ is defined X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2018 23:59:33 -0000 > On Sep 2, 2018, at 12:59 PM, Honnappa Nagarahalli wrote: >=20 > -----Original Message----- > From: Yongseok Koh =20 > Sent: Sunday, September 2, 2018 2:30 PM > To: Honnappa Nagarahalli > Cc: stable@dpdk.org > Subject: Re: [dpdk-stable] [PATCH v2] build: enable Arm NEON flags when _= _aarch64__ is defined >=20 >> On Sep 2, 2018, at 11:32 AM, Honnappa Nagarahalli wrote: >>=20 >> GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional=20 >> for ArmV8. Hence NEON related code can be enabled when __aarch64__ is=20 >> defined. >>=20 >> Bugzilla ID: 82 >> Cc: stable@dpdk.org >>=20 >> Reported-by: Raslan Darawsheh >> Reported-by: Thomas F Herbert >> Signed-off-by: Honnappa Nagarahalli >> Reviewed-by: Phil Yang >> Reviewed-by: Gavin Hu >> Acked-by: Gavin Hu >> Acked-by: Jerin Jacob >> --- >> V2: >> * Corrected the order of contribution tags >> * Added Jerin's Ack >=20 > I didn't check out the details yet but a quick question. > Do you want me to include this patch in 17.11.4? >=20 > Yes, please include. I didn't realized that this is fixing the meson build. 17.11 doesn't have that. Thanks, Yongseok >> config/arm/meson.build | 3 ++- >> mk/rte.cpuflags.mk | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >>=20 >> diff --git a/config/arm/meson.build b/config/arm/meson.build index=20 >> 40dbc87..94cca49 100644 >> --- a/config/arm/meson.build >> +++ b/config/arm/meson.build >> @@ -157,7 +157,8 @@ else >> endif >> message(machine_args) >>=20 >> -if cc.get_define('__ARM_NEON', args: machine_args) !=3D '' >> +if (cc.get_define('__ARM_NEON', args: machine_args) !=3D '' or >> + cc.get_define('__aarch64__', args: machine_args) !=3D '') >> dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) >> compile_time_cpuflags +=3D ['RTE_CPUFLAG_NEON'] endif diff --git=20 >> a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 6071313..43ed841=20 >> 100644 >> --- a/mk/rte.cpuflags.mk >> +++ b/mk/rte.cpuflags.mk >> @@ -89,7 +89,7 @@ CPUFLAGS +=3D VSX >> endif >>=20 >> # ARM flags >> -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) >> +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) >> CPUFLAGS +=3D NEON >> endif >>=20 >> -- >> 2.7.4 >>=20 >=20