From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D2793F60C; Wed, 11 Jan 2017 17:32:38 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 11 Jan 2017 08:32:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="1092786856" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 11 Jan 2017 08:32:35 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.173]) by IRSMSX152.ger.corp.intel.com ([169.254.6.191]) with mapi id 14.03.0248.002; Wed, 11 Jan 2017 16:29:47 +0000 From: "Iremonger, Bernard" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Wu, Jingjing" , "stable@dpdk.org" Thread-Topic: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling Thread-Index: AQHSa7UsMXEj69zzjU+lJx9SAm44+qEzEejQgABR6jCAAAMGgIAAAyaggAALcoCAAAFqcA== Date: Wed, 11 Jan 2017 16:29:47 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D1CDBD@IRSMSX108.ger.corp.intel.com> References: <1484102853-53205-1-git-send-email-wenzhuo.lu@intel.com> <8CEF83825BEC744B83065625E567D7C224D1CB14@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D1CCE7@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D1CD35@IRSMSX108.ger.corp.intel.com> <727ff859-107b-74c3-1110-7ed8bdbc70f6@intel.com> In-Reply-To: <727ff859-107b-74c3-1110-7ed8bdbc70f6@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGI0ZjA1ZDAtMjg5Mi00MTUyLTk1OTYtMzFmMGJlOGZjYjAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjIuMTEuMCIsIlRydXN0ZWRMYWJlbEhhc2giOiJpUG9yU2piUFhsQ1BxeVRUNHRoU1ZERjc4R2RHeE5ac3JqUTdibFRYOTBVPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API calling X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2017 16:32:39 -0000 Hi Ferruh, > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, January 11, 2017 4:19 PM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Wu, Jingjing ; stable@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe > private API calling >=20 > On 1/11/2017 3:47 PM, Iremonger, Bernard wrote: > > Hi Ferruh, > > > >> -----Original Message----- > >> From: Yigit, Ferruh > >> Sent: Wednesday, January 11, 2017 3:27 PM > >> To: Iremonger, Bernard ; Lu, Wenzhuo > >> ; dev@dpdk.org > >> Cc: Wu, Jingjing ; stable@dpdk.org > >> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix ixgbe > >> private API calling > >> > >> On 1/11/2017 3:20 PM, Iremonger, Bernard wrote: > >>> Hi Wenzhuo, > >>> > >>> > >>>>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix ixgbe private API > >>>>> calling > >>>>> > >>>>> Some ixgbe private APIs are added to expose ixgbe specific function= s. > >>>>> When they're used by testpmd, there's no check for if the NICs are > >> ixgbe. > >>>>> Other NICs also have chance to call these APIs. > >>>>> This patch add the check and the feedback print. > >>>> > >>>> I am not sure that testpmd is the right place to do this. > >>>> The rte_pmd_ixgbe_* functions are public API's which can be called > >>>> by other applications. > >>>> The checks should be in the rte_pmd_ixgbe_* API's > >>> > >>> It is useful to handle the return code -ENOTSUP in testpmd. > >>> > >> > >> Makes sense, and I think it is good idea to add them in your patch, > >> since it introduces returning -ENOTSUP, would you mind sending a new > >> version of your patch with this update? > >> So we can drop this patch completely. > >> > >> Thanks, > >> ferruh > >> > > I don't think this patch should be dropped. > > Testpmd is already handling -EINVAL and -ENODEV. > > It makes sense for it to handle -ENOTSUP for the cases in the patch. >=20 > This patch adds driver check [1] before ixgbe APIs, since now that check = is > done within ixgbe APIs by your patch. Why do we need this patch at all? >=20 > [1] > if (strstr(dev_info.driver_name, "ixgbe") !=3D NULL) =20 I think our lines have got slightly crossed. This patch is doing two things, the check [1] above which is not needed now= (after my ixgbe patch). Secondly it is handling the ret code of the rte_pmd_ixgbe_* API's, I think = this is useful. Regards, Bernard. =20