From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Qi" <qi.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup
Date: Tue, 25 Apr 2017 15:50:18 +0000 [thread overview]
Message-ID: <8CEF83825BEC744B83065625E567D7C224D57899@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D4D1BD@SHSMSX103.ccr.corp.intel.com>
Hi Jingjing,
> -----Original Message-----
> From: Wu, Jingjing
> Sent: Tuesday, April 25, 2017 9:55 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi <qi.zhang@intel.com>;
> Iremonger, Bernard <bernard.iremonger@intel.com>; stable@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
> QinQ setup
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard
> Iremonger
> > Sent: Monday, April 24, 2017 6:25 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi
> > <qi.zhang@intel.com>; Iremonger, Bernard
> > <bernard.iremonger@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for
> > QinQ setup
> >
> > Check port is stopped before configuring it for QinQ, with the "vlan
> > set qinq on <port_id>" command.
> >
> > The above command sets the hw_vlan_extend flag.
> > When the port is started it calls the
> > i40e_rx_vec_dev_conf_condition_check_default function to decide
> > whether or not to select the vector mode driver depending on the state
> > of the hw_vlan_extend flag.
> >
> The command vlan set qinq on <port_id> is an common command, but not
> only For i40e. I think it's better to doc it somewhere instead of changing the
> default Behavior of this command.
There is a doc patch in flight:
http://dpdk.org/dev/patchwork/patch/23704/
Is this enough or should I send a v3 of this patch for the i40e PMD only?
Regards,
Bernard.
next prev parent reply other threads:[~2017-04-25 15:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1492701258-7968-1-git-send-email-bernard.iremonger@intel.com>
2017-04-24 10:24 ` [dpdk-stable] " Bernard Iremonger
2017-04-25 8:55 ` [dpdk-stable] [dpdk-dev] " Wu, Jingjing
2017-04-25 15:50 ` Iremonger, Bernard [this message]
2017-04-27 5:28 ` Wu, Jingjing
2017-04-27 8:11 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CEF83825BEC744B83065625E567D7C224D57899@IRSMSX108.ger.corp.intel.com \
--to=bernard.iremonger@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).