From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1A3B147CD; Tue, 25 Apr 2017 17:50:22 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2017 08:50:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,250,1488873600"; d="scan'208";a="80713939" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga004.jf.intel.com with ESMTP; 25 Apr 2017 08:50:19 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by irsmsx110.ger.corp.intel.com ([169.254.15.151]) with mapi id 14.03.0319.002; Tue, 25 Apr 2017 16:50:18 +0100 From: "Iremonger, Bernard" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup Thread-Index: AQHSvaGwwIzfI7wM50OQ1PzATB0wVaHWOsgQ Date: Tue, 25 Apr 2017 15:50:18 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D57899@IRSMSX108.ger.corp.intel.com> References: <1492701258-7968-1-git-send-email-bernard.iremonger@intel.com> <1493029477-27106-1-git-send-email-bernard.iremonger@intel.com> <9BB6961774997848B5B42BEC655768F810D4D1BD@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D4D1BD@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDI1MDk3N2EtZDY5My00ZWQzLWE4NjMtYzdmNDZlMjFlMTg0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFkSkV4dG1uNStkTUl3XC9aV1VaYzlBdW5Za0xNQURyMlFVQ1NycWpYeGtNPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 15:50:23 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Tuesday, April 25, 2017 9:55 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi ; > Iremonger, Bernard ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > QinQ setup >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard > Iremonger > > Sent: Monday, April 24, 2017 6:25 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Zhang, Qi > > ; Iremonger, Bernard > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > > QinQ setup > > > > Check port is stopped before configuring it for QinQ, with the "vlan > > set qinq on " command. > > > > The above command sets the hw_vlan_extend flag. > > When the port is started it calls the > > i40e_rx_vec_dev_conf_condition_check_default function to decide > > whether or not to select the vector mode driver depending on the state > > of the hw_vlan_extend flag. > > > The command vlan set qinq on is an common command, but not > only For i40e. I think it's better to doc it somewhere instead of changin= g the > default Behavior of this command. There is a doc patch in flight: http://dpdk.org/dev/patchwork/patch/23704/ Is this enough or should I send a v3 of this patch for the i40e PMD only? Regards, Bernard.