From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 76181D090; Thu, 27 Apr 2017 10:11:23 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Apr 2017 01:11:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,257,1488873600"; d="scan'208";a="1140753188" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by fmsmga001.fm.intel.com with ESMTP; 27 Apr 2017 01:11:22 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.239]) by IRSMSX151.ger.corp.intel.com ([169.254.4.123]) with mapi id 14.03.0319.002; Thu, 27 Apr 2017 09:11:21 +0100 From: "Iremonger, Bernard" To: "Wu, Jingjing" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Qi" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup Thread-Index: AQHSvaGwwIzfI7wM50OQ1PzATB0wVaHWOsgQgAJnQgCAAD4L0A== Date: Thu, 27 Apr 2017 08:11:20 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C224D580FF@IRSMSX108.ger.corp.intel.com> References: <1492701258-7968-1-git-send-email-bernard.iremonger@intel.com> <1493029477-27106-1-git-send-email-bernard.iremonger@intel.com> <9BB6961774997848B5B42BEC655768F810D4D1BD@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D57899@IRSMSX108.ger.corp.intel.com> <9BB6961774997848B5B42BEC655768F810D58AF1@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810D58AF1@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk2MDc1MDQtMTI1Zi00MzgzLTg4YTMtMmRjNzQ0NzdmNzZjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6InR1NU1ScUhDblp0cnlWcFZHejRpQ2RUb1JkTlAyN2hYVzI2dnptd3A2TjQ9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2017 08:11:25 -0000 Hi Jingjing, > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, April 27, 2017 6:28 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi ; > stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > QinQ setup >=20 >=20 >=20 > > > The command vlan set qinq on is an common command, but > not > > > only For i40e. I think it's better to doc it somewhere instead of > > > changing the default Behavior of this command. > > > > There is a doc patch in flight: > > http://dpdk.org/dev/patchwork/patch/23704/ > > > > Is this enough or should I send a v3 of this patch for the i40e PMD onl= y? > > > Yes. I think doc it is enough. > We don't need this patch. >=20 > Thanks > Jingjing I will NAK this patch. Self NAK Regards, Bernard.