From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A73D1239; Tue, 24 Jul 2018 16:22:21 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jul 2018 07:22:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,398,1526367600"; d="scan'208";a="59402025" Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga008.jf.intel.com with ESMTP; 24 Jul 2018 07:22:18 -0700 Received: from irsmsx107.ger.corp.intel.com ([169.254.10.193]) by IRSMSX153.ger.corp.intel.com ([169.254.9.210]) with mapi id 14.03.0319.002; Tue, 24 Jul 2018 15:22:17 +0100 From: "Iremonger, Bernard" To: "Dai, Wei" , "Wu, Jingjing" , "Lu, Wenzhuo" , "dev@dpdk.org" CC: "Dai, Wei" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload Thread-Index: AQHUIwPdDfwVbpn8zUy6IKVf6SCoUaSeafkQ Date: Tue, 24 Jul 2018 14:22:17 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260CCEF21@IRSMSX107.ger.corp.intel.com> References: <1532403909-62194-1-git-send-email-wei.dai@intel.com> In-Reply-To: <1532403909-62194-1-git-send-email-wei.dai@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmM5NTFmYTUtODM3MC00MjZmLTk4NDYtM2QyYTdiMGFkMDQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1FHWjhwVmF0eDRVVnRaaldrSnFhU1kwMXlWWlZQOUhzY1BFWFFcL3hhYXZcL1hHVDhnYUxCMWhZTkpNZnlVRUVZIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: fix commands to config some offload X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jul 2018 14:22:22 -0000 Hi Wei, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Dai > Sent: Tuesday, July 24, 2018 4:45 AM > To: Wu, Jingjing ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: Dai, Wei ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: fix commands to config some > offload >=20 > Without this patch, testpmd command to config Rx offload keep_crc would > fail and report "Bad argument". > This patch aslo fix the command to config the Tx offload mbuf_fast_free. >=20 > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > Fixes: c73a9071877a ("app/testpmd: add commands to test new offload > API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Dai > --- > app/test-pmd/cmdline.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 5885289..a0ed3a0 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16665,7 +16665,7 @@ struct cmd_config_per_port_rx_offload_result { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" >=20 > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_port_rx_offload_result_on_off =3D > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_rx_offload_result, > @@ -16744,7 +16744,7 @@ struct cmd_config_per_port_rx_offload_result { > .help_str =3D "port config rx_offload > vlan_strip|ipv4_cksum|" >=20 > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens =3D { > (void *)&cmd_config_per_port_rx_offload_result_port, > @@ -16794,7 +16794,7 @@ struct cmd_config_per_queue_rx_offload_result > { > offload, > "vlan_strip#ipv4_cksum#udp_cksum#tcp_cksum#tcp_lro#" > "qinq_strip#outer_ipv4_cksum#macsec_strip#" >=20 > "header_split#vlan_filter#vlan_extend#jumbo_frame#" > - "crc_strip#scatter#timestamp#security"); > + "crc_strip#scatter#timestamp#security#keep_crc"); > cmdline_parse_token_string_t > cmd_config_per_queue_rx_offload_result_on_off =3D > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_rx_offload_result, > @@ -16846,7 +16846,7 @@ struct cmd_config_per_queue_rx_offload_result > { > "vlan_strip|ipv4_cksum|" >=20 > "udp_cksum|tcp_cksum|tcp_lro|qinq_strip|outer_ipv4_cksum|" > "macsec_strip|header_split|vlan_filter|vlan_extend|" > - "jumbo_frame|crc_strip|scatter|timestamp|security " > + > "jumbo_frame|crc_strip|scatter|timestamp|security|keep_crc " > "on|off", > .tokens =3D { > (void *)&cmd_config_per_queue_rx_offload_result_port, > @@ -17063,7 +17063,7 @@ struct cmd_config_per_port_tx_offload_result { >=20 > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_port_tx_offload_result_on_off =3D > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_port_tx_offload_result, > @@ -17144,7 +17144,7 @@ struct cmd_config_per_port_tx_offload_result { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens =3D { > (void *)&cmd_config_per_port_tx_offload_result_port, > @@ -17195,7 +17195,7 @@ struct cmd_config_per_queue_tx_offload_result > { >=20 > "sctp_cksum#tcp_tso#udp_tso#outer_ipv4_cksum#" > "qinq_insert#vxlan_tnl_tso#gre_tnl_tso#" > "ipip_tnl_tso#geneve_tnl_tso#macsec_insert#" > - "mt_lockfree#multi_segs#fast_free#security"); > + > "mt_lockfree#multi_segs#mbuf_fast_free#security"); > cmdline_parse_token_string_t > cmd_config_per_queue_tx_offload_result_on_off =3D > TOKEN_STRING_INITIALIZER > (struct cmd_config_per_queue_tx_offload_result, > @@ -17248,7 +17248,7 @@ struct cmd_config_per_queue_tx_offload_result > { > "sctp_cksum|tcp_tso|udp_tso|outer_ipv4_cksum|" > "qinq_insert|vxlan_tnl_tso|gre_tnl_tso|" > "ipip_tnl_tso|geneve_tnl_tso|macsec_insert|" > - "mt_lockfree|multi_segs|fast_free|security " > + "mt_lockfree|multi_segs|mbuf_fast_free|security " > "on|off", > .tokens =3D { > (void *)&cmd_config_per_queue_tx_offload_result_port, > -- > 1.8.3.1 Changes are also needed in dpdk/doc/guides/testpmd_app_guide/testpmd_funcs.= rst for mbuf_fast_free and keep_crc. Regards, Bernard