patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] app/testpmd: fix doubling of 'total TX dropped'
@ 2019-07-12  8:32 A.McLoughlin
  2019-07-12 13:33 ` Iremonger, Bernard
  2019-07-15 14:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  0 siblings, 2 replies; 9+ messages in thread
From: A.McLoughlin @ 2019-07-12  8:32 UTC (permalink / raw)
  To: Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
  Cc: dev, A.McLoughlin, david.marchand, stable

The 'Accumulated forward statistics for all ports' incorrectly displayed
double the actual value for 'total_tx_dropped'. This was because 2
lines in the same function both incremented total_tx_dropped every time
a packet was dropped.  I removed one of these lines to fix this issue.

Fixes: 53324971a14e ("app/testpmd: display/clear forwarding stats on demand")
Cc: david.marchand@redhat.com
Cc: stable@dpdk.org

Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
---
 app/test-pmd/testpmd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 3ed3523b7..c41bada50 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1555,7 +1555,6 @@ fwd_stats_display(void)
 		total_recv += stats.ipackets;
 		total_xmit += stats.opackets;
 		total_rx_dropped += stats.imissed;
-		total_tx_dropped += ports_stats[pt_id].tx_dropped;
 		total_tx_dropped += stats.oerrors;
 		total_rx_nombuf  += stats.rx_nombuf;
 
-- 
2.17.1

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2019-07-23 11:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12  8:32 [dpdk-stable] [PATCH] app/testpmd: fix doubling of 'total TX dropped' A.McLoughlin
2019-07-12 13:33 ` Iremonger, Bernard
2019-07-15 14:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-07-16 12:23   ` Andrew Rybchenko
2019-07-16 14:23     ` Ferruh Yigit
2019-07-16 14:28       ` Bruce Richardson
2019-07-16 15:00         ` Andrew Rybchenko
2019-07-16 15:29           ` Ferruh Yigit
2019-07-23 11:16             ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).