patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value
@ 2019-08-07 11:27 Bernard Iremonger
  2019-08-08  7:19 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bernard Iremonger @ 2019-08-07 11:27 UTC (permalink / raw)
  To: qabuild; +Cc: Bernard Iremonger, stable

Check the return value of the rte_eth_dev_rss_hash_conf_get function.

Coverity issue: 344970
Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
Cc: stable@dpdk.org

Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
 examples/ipsec-secgw/ipsec.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/examples/ipsec-secgw/ipsec.c b/examples/ipsec-secgw/ipsec.c
index dc85adf..5f9d560 100644
--- a/examples/ipsec-secgw/ipsec.c
+++ b/examples/ipsec-secgw/ipsec.c
@@ -248,7 +248,14 @@ create_inline_session(struct socket_ctx *skt_ctx, struct ipsec_sa *sa)
 			/* Try RSS. */
 			sa->action[1].type = RTE_FLOW_ACTION_TYPE_RSS;
 			sa->action[1].conf = &action_rss;
-			rte_eth_dev_rss_hash_conf_get(sa->portid, &rss_conf);
+			ret = rte_eth_dev_rss_hash_conf_get(sa->portid,
+					&rss_conf);
+			if (ret != 0) {
+				RTE_LOG(ERR, IPSEC,
+					"rte_eth_dev_rss_hash_conf_get:ret=%d\n",
+					ret);
+				return -1;
+			}
 			for (i = 0, j = 0; i < dev_info.nb_rx_queues; ++i)
 				queue[j++] = i;
 
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value
  2019-08-07 11:27 [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value Bernard Iremonger
@ 2019-08-08  7:19 ` Thomas Monjalon
  2019-08-08  8:19   ` Iremonger, Bernard
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2019-08-08  7:19 UTC (permalink / raw)
  To: Bernard Iremonger; +Cc: stable, qabuild

07/08/2019 13:27, Bernard Iremonger:
> Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> 
> Coverity issue: 344970
> Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline crypto")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>

Please don't Cc stable@dpdk.org for internal testing.




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value
  2019-08-08  7:19 ` Thomas Monjalon
@ 2019-08-08  8:19   ` Iremonger, Bernard
  0 siblings, 0 replies; 3+ messages in thread
From: Iremonger, Bernard @ 2019-08-08  8:19 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: stable, qabuild

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, August 8, 2019 8:19 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: stable@dpdk.org; qabuild <qabuild@intel.com>
> Subject: Re: [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked
> return value
> 
> 07/08/2019 13:27, Bernard Iremonger:
> > Check the return value of the rte_eth_dev_rss_hash_conf_get function.
> >
> > Coverity issue: 344970
> > Fixes: 3a690d5a65e2 ("examples/ipsec-secgw: fix first packet with inline
> crypto")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> 
> Please don't Cc stable@dpdk.org for internal testing.

Apologies, forgot that this was causing problems.

Regards,

Bernard.


 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-07 11:27 [dpdk-stable] [DPDK] examples/ipsec-secgw: fix unchecked return value Bernard Iremonger
2019-08-08  7:19 ` Thomas Monjalon
2019-08-08  8:19   ` Iremonger, Bernard

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox