Re: [dpdk-stable] patch 'flow_classify: fix out-of-bounds access' has been queued to LTS release 18.11.3

["Iremonger, Bernard" <bernard.iremonger@intel.com>]

Hi Kevin,

The following patch from Aaron Conole (aconole@redhat.com) should also be back ported to 18.11.3.
[dpdk-dev] [PATCH] test: fix undefined behavior in flow classify test
http://mails.dpdk.org/archives/dev/2019-July/140110.html

The fix below, exposed the above issue.

Regards,

Bernard.


> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Tuesday, August 27, 2019 10:30 AM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: dpdk stable <stable@dpdk.org>
> Subject: patch 'flow_classify: fix out-of-bounds access' has been queued to
> LTS release 18.11.3
> 
> Hi,
> 
> FYI, your patch has been queued to LTS release 18.11.3
> 
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 09/03/19. So please shout if
> anyone has objections.
> 
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for
> rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
> 
> Queued patches are on a temporary branch at:
> https://github.com/kevintraynor/dpdk-stable-queue
> 
> This queued commit can be viewed at:
> https://github.com/kevintraynor/dpdk-stable-
> queue/commit/5c0e9b1077b4c95d4a8b5612d603466dc23c620f
> 
> Thanks.
> 
> Kevin Traynor
> 
> ---
> From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00
> 2001
> From: Bernard Iremonger <bernard.iremonger@intel.com>
> Date: Tue, 9 Jul 2019 12:09:56 +0100
> Subject: [PATCH] flow_classify: fix out-of-bounds access
> 
> [ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ]
> 
> This patch fixes the out-of-bounds coverity issue by removing the offending
> line of code at line 107 in rte_flow_classify_parse.c which is never executed.
> 
> Coverity issue: 343454
> Fixes: be41ac2a330f ("flow_classify: introduce flow classify library")
> 
> Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>  lib/librte_flow_classify/rte_flow_classify_parse.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lib/librte_flow_classify/rte_flow_classify_parse.c
> b/lib/librte_flow_classify/rte_flow_classify_parse.c
> index f65ceaf7c..465330291 100644
> --- a/lib/librte_flow_classify/rte_flow_classify_parse.c
> +++ b/lib/librte_flow_classify/rte_flow_classify_parse.c
> @@ -104,6 +104,4 @@ classify_pattern_skip_void_item(struct
> rte_flow_item *items,
>  			break;
>  		}
> -
> -		pb = pe + 1;
>  	}
>  	/* Copy the END item. */
> --
> 2.20.1
> 
> ---
>   Diff of the applied patch vs upstream commit (please double-check if non-
> empty:
> ---
> --- -	2019-08-27 09:40:13.152936799 +0100
> +++ 0041-flow_classify-fix-out-of-bounds-access.patch	2019-08-27
> 09:40:10.936144000 +0100
> @@ -1 +1 @@
> -From 8d244bb3a32ee54364f8c0a7b7244a67ad407091 Mon Sep 17 00:00:00
> 2001
> +From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00
> 2001
> @@ -5,0 +6,2 @@
> +[ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ]
> +
> @@ -12 +13,0 @@
> -Cc: stable@dpdk.org