From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2889FA0613 for ; Tue, 27 Aug 2019 15:53:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0061C1C11D; Tue, 27 Aug 2019 15:53:01 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 1C06F1C11D for ; Tue, 27 Aug 2019 15:52:59 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2019 06:52:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,437,1559545200"; d="scan'208";a="180233326" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by fmsmga008.fm.intel.com with ESMTP; 27 Aug 2019 06:52:58 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.50]) by IRSMSX106.ger.corp.intel.com ([169.254.8.187]) with mapi id 14.03.0439.000; Tue, 27 Aug 2019 14:52:56 +0100 From: "Iremonger, Bernard" To: Kevin Traynor CC: dpdk stable , "aconole@redhat.com" Thread-Topic: patch 'flow_classify: fix out-of-bounds access' has been queued to LTS release 18.11.3 Thread-Index: AQHVXLo+YVV7qFdaZU2dlVCzSSVtHqcPAlKw Date: Tue, 27 Aug 2019 13:52:56 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260DE8E06@IRSMSX108.ger.corp.intel.com> References: <20190827093032.20423-1-ktraynor@redhat.com> <20190827093032.20423-41-ktraynor@redhat.com> In-Reply-To: <20190827093032.20423-41-ktraynor@redhat.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTk1ZmExNTAtNDI4Ni00YjkwLWJjOTEtNjJiOGM4OTQzMTY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTzhFQzJyQlBTNkV3Mkx2T3kzWk51Vml3YnpiMEgzUXkyUnBCM2dpMjd4cmtoQnZISFpKRlhmVmRNTlhxWjNmTCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] patch 'flow_classify: fix out-of-bounds access' has been queued to LTS release 18.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Kevin, The following patch from Aaron Conole (aconole@redhat.com) should also be b= ack ported to 18.11.3. [dpdk-dev] [PATCH] test: fix undefined behavior in flow classify test http://mails.dpdk.org/archives/dev/2019-July/140110.html The fix below, exposed the above issue. Regards, Bernard. > -----Original Message----- > From: Kevin Traynor [mailto:ktraynor@redhat.com] > Sent: Tuesday, August 27, 2019 10:30 AM > To: Iremonger, Bernard > Cc: dpdk stable > Subject: patch 'flow_classify: fix out-of-bounds access' has been queued = to > LTS release 18.11.3 >=20 > Hi, >=20 > FYI, your patch has been queued to LTS release 18.11.3 >=20 > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 09/03/19. So please shout= if > anyone has objections. >=20 > Also note that after the patch there's a diff of the upstream commit vs t= he > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for > rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. >=20 > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable-queue >=20 > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk-stable- > queue/commit/5c0e9b1077b4c95d4a8b5612d603466dc23c620f >=20 > Thanks. >=20 > Kevin Traynor >=20 > --- > From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00 > 2001 > From: Bernard Iremonger > Date: Tue, 9 Jul 2019 12:09:56 +0100 > Subject: [PATCH] flow_classify: fix out-of-bounds access >=20 > [ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ] >=20 > This patch fixes the out-of-bounds coverity issue by removing the offendi= ng > line of code at line 107 in rte_flow_classify_parse.c which is never exec= uted. >=20 > Coverity issue: 343454 > Fixes: be41ac2a330f ("flow_classify: introduce flow classify library") >=20 > Signed-off-by: Bernard Iremonger > --- > lib/librte_flow_classify/rte_flow_classify_parse.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/lib/librte_flow_classify/rte_flow_classify_parse.c > b/lib/librte_flow_classify/rte_flow_classify_parse.c > index f65ceaf7c..465330291 100644 > --- a/lib/librte_flow_classify/rte_flow_classify_parse.c > +++ b/lib/librte_flow_classify/rte_flow_classify_parse.c > @@ -104,6 +104,4 @@ classify_pattern_skip_void_item(struct > rte_flow_item *items, > break; > } > - > - pb =3D pe + 1; > } > /* Copy the END item. */ > -- > 2.20.1 >=20 > --- > Diff of the applied patch vs upstream commit (please double-check if no= n- > empty: > --- > --- - 2019-08-27 09:40:13.152936799 +0100 > +++ 0041-flow_classify-fix-out-of-bounds-access.patch 2019-08-27 > 09:40:10.936144000 +0100 > @@ -1 +1 @@ > -From 8d244bb3a32ee54364f8c0a7b7244a67ad407091 Mon Sep 17 00:00:00 > 2001 > +From 5c0e9b1077b4c95d4a8b5612d603466dc23c620f Mon Sep 17 00:00:00 > 2001 > @@ -5,0 +6,2 @@ > +[ upstream commit 8d244bb3a32ee54364f8c0a7b7244a67ad407091 ] > + > @@ -12 +13,0 @@ > -Cc: stable@dpdk.org