From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>
Cc: stable@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] ethdev: fix errno to have positive value
Date: Wed, 23 Jan 2019 11:49:11 +0000 [thread overview]
Message-ID: <8a15117c-9cf4-2736-655b-7852538d265e@intel.com> (raw)
In-Reply-To: <5358053.gQHV9Io9Z3@xps>
On 22-Jan-19 4:03 PM, Thomas Monjalon wrote:
> 21/01/2019 17:18, Andrew Rybchenko:
>> rte_errno should be set to positive value from errno.h plus
>> few RTE-specific values.
>>
>> Fixes: 4fb7e803eb1a ("ethdev: add Tx preparation")
>> Fixes: 439a90b5f2a7 ("ethdev: reorder inline functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Applied, thanks
>
> There are other occurrences in drivers:
> git grep 'rte_errno = -E'
>
There could also possibly be rte_errno = -value; type assignments. I
imagine most of them are correct (since the value itself was negative in
the first place, so additional '-' flips the sign again), but it doesn't
hurt to check :)
--
Thanks,
Anatoly
prev parent reply other threads:[~2019-01-23 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 16:18 [dpdk-stable] " Andrew Rybchenko
2019-01-22 16:03 ` Thomas Monjalon
2019-01-23 11:49 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a15117c-9cf4-2736-655b-7852538d265e@intel.com \
--to=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).