From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dongdong Liu <liudongdong3@huawei.com>,
dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru
Cc: stable@dpdk.org,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [PATCH 3/5] net/hns3: optimize free mbuf code for SVE Tx
Date: Mon, 25 Sep 2023 15:21:16 +0100 [thread overview]
Message-ID: <8a469b5d-6047-4123-ad47-6416385b0de9@amd.com> (raw)
In-Reply-To: <20230711102448.11627-4-liudongdong3@huawei.com>
On 7/11/2023 11:24 AM, Dongdong Liu wrote:
> From: Huisong Li <lihuisong@huawei.com>
>
> Currently, hns3 SVE Tx checks the valid bits of all descriptors
> in a batch and then determines whether to release the corresponding
> mbufs. Actually, once the valid bit of any descriptor in a batch
> isn't cleared, driver does not need to scan the rest of descriptors.
>
> If we optimize SVE codes algorithm about this function, the performance
> of a single queue for 64B packet is improved by ~2% on txonly forwarding
> mode. And if use C code to scan all descriptors, the performance is
> improved by ~8%.
>
> So this patch selects C code to optimize this code to improve the SVE
> Tx performance.
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>
SVE Tx optimized by removing SVE implementation :)
Do you have any insight why generic vector implementation is faster?
next prev parent reply other threads:[~2023-09-25 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 10:24 [PATCH 0/5] net/hns3: some performance optimizations Dongdong Liu
2023-07-11 10:24 ` [PATCH 1/5] net/hns3: fix incorrect index to look up table in NEON Rx Dongdong Liu
2023-07-11 12:58 ` Ferruh Yigit
2023-07-11 10:24 ` [PATCH 2/5] net/hns3: fix the order of NEON Rx code Dongdong Liu
2023-07-11 10:24 ` [PATCH 3/5] net/hns3: optimize free mbuf code for SVE Tx Dongdong Liu
2023-09-25 14:21 ` Ferruh Yigit [this message]
2023-07-11 10:24 ` [PATCH 4/5] net/hns3: optimize the rearm mbuf function for SVE Rx Dongdong Liu
2023-07-11 10:24 ` [PATCH 5/5] net/hns3: optimize SVE Rx performance Dongdong Liu
2023-07-11 10:48 ` [PATCH 0/5] net/hns3: some performance optimizations Ferruh Yigit
2023-07-11 11:27 ` Dongdong Liu
2023-07-11 12:26 ` Ferruh Yigit
2023-09-25 14:26 ` Ferruh Yigit
2023-09-25 2:33 ` Jie Hai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a469b5d-6047-4123-ad47-6416385b0de9@amd.com \
--to=ferruh.yigit@amd.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=liudongdong3@huawei.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).