From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3E1CA0C41 for ; Tue, 16 Nov 2021 18:06:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD21B426E1; Tue, 16 Nov 2021 18:06:48 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id AAEE141165; Tue, 16 Nov 2021 18:06:45 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="297157857" X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="297157857" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 09:01:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,239,1631602800"; d="scan'208";a="735405723" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 16 Nov 2021 09:01:34 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 09:01:34 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 16 Nov 2021 09:01:34 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 16 Nov 2021 09:01:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfUINhrdoR2zuVoi2rTqg0/1esbSpciKsW+sj4qUHKcFlEMRFnG5mBrhxHKG5QVAubNK1gFOSr9FemVmB7t/+vLyciprb+blE64sZ1RczTZRNDK0PbmDnpE1XK04WSHzZbfYxpDBoOJUEjxfaUVmR6nm4IpU7SPWpu0hMA3+2V1Ok9lOvoU28yBXpBzq4uq1f1j9TdIPZXukJ0qwkTw5nNAyd/oB9DnphransFLarHn3NKj5hdkSDaj/hf9bZP0mqLc8w1e5kfKJBXpv7VhxmJDF/LvrNnNJWpd9OvWGheUF0MchpyFLqatLgJIl/jz0fv+sUHzqjkAIKKzIxq0MJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4cLmV5vsGJq/DVH5jh84u+QXOwytyhAtV4BPtFHSaAs=; b=MCOO1f1GzlMv/UoZoEdEeXeBFwqdhRbG3cglPhPkKpwhIyXw0g2kmFPTXCPI+tipoYoDiir11pOkgrANgt5c9PIonE63DS1LTBfunPi24bRIXn6pGlyQLXQw4RIbZVXlqysmCyPIAyjUJJG+lrvOChGANoxyhsNmCWisMkrYQGlrsoBimwIS+YUHETof1lbUSxVYvwGN9sUpv33kjTvF4uvkIXO1kyQmn51fu7XYg9JVsv2EXkZKaus/BIW2ymJSXDX5zjT5ZPibBdJPEHwWfnndCY6cPqk57mWpg84I6ObVZwbIYRA8vaNLpup5HfKyD0OpQYBsT8RXqlo/dOx4Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4cLmV5vsGJq/DVH5jh84u+QXOwytyhAtV4BPtFHSaAs=; b=DkEtbIa1z6la6KiJb1jgrWMY+9H2Xk3gIfwtxpSJfYUexd4YXmUYWGOXd47GIrxMQKJ/Qzy/+qgwnIoS9Z3uQY5+iVGCwpVU0uANRh3x5rWD+43aPM8gztVkbwOy0GvMCq12ooFCTsfcDCH2nedNKZLfDecYBt/H0/QM1YjfShE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4774.namprd11.prod.outlook.com (2603:10b6:510:40::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 16 Nov 2021 17:01:33 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 17:01:32 +0000 Message-ID: <8a70eb46-fe9c-e63e-e5f4-f5a490468e22@intel.com> Date: Tue, 16 Nov 2021 17:01:26 +0000 Subject: Re: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup Content-Language: en-US To: Slava Ovsiienko , Chengfeng Ye , Matan Azrad , Tzahi Oved , Raslan Darawsheh CC: "dev@dpdk.org" , "stable@dpdk.org" References: <20211116144923.7342-1-cyeaa@connect.ust.hk> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::6) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15 via Frontend Transport; Tue, 16 Nov 2021 17:01:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4936a61c-886e-415e-6ebc-08d9a922bda9 X-MS-TrafficTypeDiagnostic: PH0PR11MB4774: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O9jmo9NKBQDY/SkZkmVEQJK3rEQ4J7WglM6aWNUYn7O/OgDzxlJWkBiI4RZvprNuGsdM+KvR3zvA56zp3etgeMzGeqObQqJzLOs9uvoK7ybZ0kJ/mJ2+lN1+2hD0nlwihF49RXGTS8I88NN4/32MqfSZsGFrKvMgp3fkbZU1slHqRuR9g4zJIAVg/CN/jcIpG2lA/03iUBqj7Miz2yoUa97ISOb+XBPAAP0tgkE8gTtseyzj9ygigEWUg6AGgpx/4tTaQk+w/IbRG9dWwXZ+ZydhhJVpBxZBzNHmyihvrs7xH32S3lDD5GtNjw8ZbAJejHDU8t450rUZg0dOIOiErYhJLfn/DsJXgAz2ldP6Y/Rv1LAenSH5ADxntznVYFaZicVwMO4mM1+Jcq2F1lI9oFTSmYV6Ct/KTrkNTDWV3cYdyrFbwt0gxoVDEEEiKNhAuiXz+Sa33Mf3NKUWxDEiIxGd4QdiqGQ9L3R1ZXg/Mk70fvGpUFvSY87gIN6JKaoZLNlogrBVcj5jOFOQkULbth9FJR8NKyV9OoS5sUh7L0sI+sDR/iIgOlqmVktamjNqxtTCH/UIaiJIbvYp8mMaM6UXsfTvEiQt8qHytdhf0eAopZkHzarX13EKabG01oBqisIjLpGJwJDLZLK8WdIRilMLNPgbvw4ZaFWUxAW5Y5JHgniuEya9W75mzNPPZPIRqz4N0+ff1epCyM6zjm+/Dw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(6486002)(186003)(83380400001)(4744005)(36756003)(31696002)(54906003)(26005)(53546011)(4326008)(2906002)(5660300002)(86362001)(8676002)(82960400001)(66556008)(66946007)(66476007)(2616005)(508600001)(44832011)(110136005)(38100700002)(956004)(16576012)(6666004)(8936002)(31686004)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlpMRkhRN3RTdDVyRkRLUWdnZUQ4Y1Q4SWQ0WFgzTkdMSTg1Y1p1eCtkL21S?= =?utf-8?B?Tk9BYlRLMDZFOHp4dlFZc3cxajFteUZpYkVVcmZ5ZW1WVENFWEQ4N2xwUkZi?= =?utf-8?B?b1FLbDl5U09Qcmd3QW5vMUJ4VDNXZHJmR040YlUxSy9teUl3a0pVL0o1NHF1?= =?utf-8?B?eEV2YjhpbVE3OFA5c2I2ZjIyMi9GT2FHVVFzdWtNVFZHTXVkWDhUaDN3NGIw?= =?utf-8?B?dlVIT3lLa2pkMlE3cVVmSURvbGtNVGoxWkkyMklsRDZqNWN6T0o1M1JGeFFs?= =?utf-8?B?V255NFJSalVzQ05EZUJKK2lkYUR1cGJDN1VqMDd0WmM5V0QwZ1VFVkI0V1pS?= =?utf-8?B?VjMwaVp2clIxNXdxc3R5RDFpV1dyYThQbkdaa3hEazdOTnVWbVE3dm5rL3BC?= =?utf-8?B?UXY1TFhZbkVOQjF4QWRGU051bnJtSnYrMWpISVV4elhLcllia21WL1l4Y2FM?= =?utf-8?B?Z2NoRTF1dHdmOGVSdnE1RmxsMnpUUGp6cklCNnhNSm40OFJ1c1FFaWEyN2ZW?= =?utf-8?B?RXk1SEdkMWlmMlhENWgyc1JSeUJ2dUNQNDVRalZuZ01wWkNrcVJJZXB6NEph?= =?utf-8?B?UWFJS0pMdU05ZG1meFpOMk1uTEIwWk5ES0xrbjAzY0RDc1dzVzJUWnM1UVFy?= =?utf-8?B?QjZGYXRzQVVibTcvbjZRZ3I5QkhvQ1hTM2dVNkdibkI2NXUxZlN6eFhEQlo2?= =?utf-8?B?clp4NFlzVVNjTjAyZmRhLzN1SFJQZk9YWTFKcVNNUjFqaUlRMUZuOW44bE41?= =?utf-8?B?YTJKMXpablZOODh3VE5teW5mQlFKVkNDakU1UjJrNzkrS2FPTmRhbXFYeXVG?= =?utf-8?B?QmhjTXRDaGUxTDgxSDJoZXgxK3YwNXhjY2lrQVFrQXNGTFBUTU9sMnhRc3NX?= =?utf-8?B?N3Q5VzYzbUpFY2ZJOVpuL1N3T0tCV01iZFpLaFBpVFA3SU9RTExjTU5Wdk1D?= =?utf-8?B?b29ZUmlzV3ZvM0dVWUVVSmttZkhWUG9yZGp1WTR0MlZ5enBRMTExd1oybXRZ?= =?utf-8?B?ZW9ETUZXcmRIOTBZWG5ML3FTS2RWRnZUcnlIaVdEYjhDcDJQdTJRRnM2VVRO?= =?utf-8?B?VENlTUcvY2xTemlFRVdWMmloYmxJZVc3TVpPZ3ZmR3NhNENyYXZka2NRSFJh?= =?utf-8?B?dlRCR1RLVUFNZjZTWlZRS2l1N0RCQWd0OUJ4WWhEL21RRTBnbjBuS05sVmZT?= =?utf-8?B?UVQ0RGdOZE0wYTV5YmdsQnQ3VWR4aUU4UTVFenBMMXUrQW5qa0tUNzJNVUtj?= =?utf-8?B?Y1lZdGNRU2hRVVl1WFEyZFhtcDRRWW9MNHFiekpEVFhmRDVsNWFMYjQya2NJ?= =?utf-8?B?ZFhOTHFvQVNZTms3R0hJTC9lNVZJOWNEUFdBYWdUVjYxcUs3d1drT2VRSXJv?= =?utf-8?B?Q0NZRFhoMzZkMUZSVkluRks0UlF0Mk1xdHJqbTRwdUNqdCtwM2VPK21BaXh0?= =?utf-8?B?ZDBWZVRuVEp0d04wbC9PMU9STzMrZ0FycXdYa2ljTEJnUVV4d3c1b1JWYWEr?= =?utf-8?B?REJJSTBSWkFwblNzcE45ZHhxZkFGU1BZejZ2UnozK2taTlNhMFZzdjl2eGdM?= =?utf-8?B?R21aS2xRYTRqU1ZDT25reXo4bjFYcy9PV29SY2xNN3FGNUlCUXA0dllXdlpV?= =?utf-8?B?UFVhWTVGVHlzdDViTTVsMDUzT0d5bWVnRXpvUjE1ZG13K1FGWm5selRYRXJj?= =?utf-8?B?VllZMm45eEV1cXRUOHpEczZIQldiTmlqOU5zYVdyU3ZxQ0kyYVBtVWdtMExy?= =?utf-8?B?UlcvSitzTjZiZ1FoR2RkaXNXZ3ZNcERaWS80QnE4SURzUTZ0OEtmd1MzR2Vh?= =?utf-8?B?YVFvTlBYeFU5MGdabGIrOENUSHRqTmk2ZHFqdDdrTTRHb2gvV3BkNkxTdDNv?= =?utf-8?B?RkhEZ3dFYStmc0IveHRpZFppK1BHeEpHeWkzYTNvKzlFazRzc0YrQ1Q4S3h4?= =?utf-8?B?YkNvYU9vNDkzakFNN0tYZFJoZExnVW5VWktjUXQySXRZZEdWZmdFdFloZGNj?= =?utf-8?B?VXoraEtjQU0xdnY0blMrNlZEaXpsMWhRZmNUMTVGb0NDWU82VXV6RHZKWWFp?= =?utf-8?B?VGpCSEo0UjRyb1kzbHN3NTNsY3UxbEI4N256bHlEcnlqeURmcE9tc1Zqd1JL?= =?utf-8?B?Y1I0RGdmUzBKV2ZEcHVFT3dWZXpjOXgrVFRvNDBpbjFQZUVYRXY5cnBHa3Z6?= =?utf-8?Q?7ppkY2Dv57wA3itUW4muexQ=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4936a61c-886e-415e-6ebc-08d9a922bda9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2021 17:01:32.8363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uGrQm6oeGDQeangwjIn3tiPqMMe68fV4FKeJ4IloE59aTv+KrHB35rNVqPO7EAr2suIX1JhUWaFpHf58XSif2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4774 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 11/16/2021 3:04 PM, Slava Ovsiienko wrote: >> -----Original Message----- >> From: Chengfeng Ye >> Sent: Tuesday, November 16, 2021 16:49 >> To: Matan Azrad ; Slava Ovsiienko >> ; Tzahi Oved ; >> ferruh.yigit@intel.com; Raslan Darawsheh >> Cc: dev@dpdk.org; Chengfeng Ye ; stable@dpdk.org >> Subject: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup >> >> The lock sh->txpp.mutex was not correctly released on one path of cleanup >> function return, potentially causing the deadlock. >> >> Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") >> Cc: stable@dpdk.org >> >> Signed-off-by: Chengfeng Ye > Acked-by: Viacheslav Ovsiienko > Applied to dpdk-next-net/main, thanks.