From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C69241D3E for ; Thu, 2 Mar 2023 11:23:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96C764282D; Thu, 2 Mar 2023 11:23:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id DBF1940E09 for ; Thu, 2 Mar 2023 11:23:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677752599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FlB832C8hl6fW77dUmsPx3uH6s/C3WBffSDwBHjfU3s=; b=CEbgAAAIMuI05qkLvhYakHAcfrDhGCvjKmS5KWKtrqnkifw/41KYao7ThpWwxPPE2APhb4 n6z+5IL9JxYXEaas3bwsBRJ6lCBZfs6kA+JG9Atftf8Xa3uY10yDUUw3Tn/E6nPCgthJB4 jM1ziSk5R3a0NW2JuLL9E4aklnon1u0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-588-_RcXTIU_OuWR0XLy9gxlTg-1; Thu, 02 Mar 2023 05:23:14 -0500 X-MC-Unique: _RcXTIU_OuWR0XLy9gxlTg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E5A4101A55E; Thu, 2 Mar 2023 10:23:13 +0000 (UTC) Received: from [10.39.208.28] (unknown [10.39.208.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6C7B492C18; Thu, 2 Mar 2023 10:23:10 +0000 (UTC) Message-ID: <8aa9b4a1-a994-2c7c-7048-22c2f7b9f82f@redhat.com> Date: Thu, 2 Mar 2023 11:23:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] vhost: fix slot index in async split virtqueue Tx To: Cheng Jiang , chenbo.xia@intel.com Cc: dev@dpdk.org, wangzhihong.wzh@bytedance.com, jiayu.hu@intel.com, xuan.ding@intel.com, wenwux.ma@intel.com, yuanx.wang@intel.com, xingguang.he@intel.com, stable@dpdk.org References: <20230223023032.681-1-cheng1.jiang@intel.com> From: Maxime Coquelin In-Reply-To: <20230223023032.681-1-cheng1.jiang@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/23/23 03:30, Cheng Jiang wrote: > The slot_idx in the asynchronous Vhost split virtqueue dequeue data path > is supposed to be decreased by 1 when desc_to_mbuf() fails. > > Fixes: 84d5204310d7 ("vhost: support async dequeue for split ring") > Cc: stable@dpdk.org > > Signed-off-by: Cheng Jiang > --- > lib/vhost/virtio_net.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c > index 8caf05319e..374007a61a 100644 > --- a/lib/vhost/virtio_net.c > +++ b/lib/vhost/virtio_net.c > @@ -3720,6 +3720,7 @@ virtio_dev_tx_async_split(struct virtio_net *dev, struct vhost_virtqueue *vq, > allocerr_warned = true; > } > dropped = true; > + slot_idx--; > break; > } > > -- > 2.35.1 > Reviewed-by: Maxime Coquelin Thanks, Maxime