From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-9.cisco.com (rcdn-iport-9.cisco.com [173.37.86.80]) by dpdk.org (Postfix) with ESMTP id E242C234; Wed, 10 May 2017 14:20:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1475; q=dns/txt; s=iport; t=1494418822; x=1495628422; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=blTqh6HMV3KLFgu1U6C/8jrmYRcKWdT+C0B4VkKMYBA=; b=WUlttU4nWTXiHgBmhoMZHXKbBOj4z709YXaDpv6rOG1ZIS3WSftUVE9L VYXsOqt+3lXk1trK1iM5IMf+7aGKCV6Y5JNZyR+dIMe2YbE3fJ9oOHjjw iS10vxWuhycR6ly1ocNd4NgT0xDW2enmuAfSbFhmmSMpsPOMkXAPG+Y/U 4=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BNAgAhBBNZ/5JdJa1dGQEBAQEBAQEBA?= =?us-ascii?q?QEBBwEBAQEBg1WBboNpm26VcoIPhiQChHxAFwECAQEBAQEBAWsohRYBBSMEEUE?= =?us-ascii?q?QCxgCAiYCAlcGAQwGAgEBih2yV4FsOop1AQEBAQEBAQEBAQEBAQEBAQEBIIELh?= =?us-ascii?q?VSBXiuCcIQygz+CYAEEngoBkxqCBIU7g0OGaZRDIAE2gQpwFYdXJDaGXII9AQE?= =?us-ascii?q?B?= X-IronPort-AV: E=Sophos;i="5.38,319,1491264000"; d="scan'208";a="241380484" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-9.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2017 12:20:20 +0000 Received: from [10.150.214.135] ([10.150.214.135]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id v4ACKKnQ015037; Wed, 10 May 2017 12:20:20 GMT To: Ferruh Yigit , Wei Dai , wenzhuo.lu@intel.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org, stable@dpdk.org, Laurent Hardy References: <1494399602-33955-1-git-send-email-wei.dai@intel.com> From: "Roger B. Melton" Message-ID: <8ad4912d-05d5-fdad-8bb5-a3e414c45738@cisco.com> Date: Wed, 10 May 2017 08:20:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 12:20:22 -0000 On 5/10/17 5:50 AM, Ferruh Yigit wrote: > On 5/10/2017 8:00 AM, Wei Dai wrote: >> hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not >> be called directly. It had better be replaced by calling >> ixgbe_get_media_type( ) to avoid crash. >> >> Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") >> Cc: stable@dpdk.org >> >> Signed-off-by: Wei Dai > Hi Roger and Laurent, > > This is very close the release, can you please support verifying this > defect? > > An explicit Acked-by and/or Tested-by would help a lot. > > Thanks, > ferruh Hi Ferruh, Happy to test it. I'll get back to you shortly. Regards, Roger > > >> --- >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >> index ec667d8..ed2baec 100644 >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> @@ -3799,7 +3799,7 @@ ixgbe_dev_link_update(struct rte_eth_dev *dev, int wait_to_complete) >> hw->mac.get_link_status = true; >> >> if ((intr->flags & IXGBE_FLAG_NEED_LINK_CONFIG) && >> - hw->mac.ops.get_media_type(hw) == ixgbe_media_type_fiber) { >> + ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >> speed = hw->phy.autoneg_advertised; >> if (!speed) >> ixgbe_get_link_capabilities(hw, &speed, &autoneg); >> > . >