From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C88684282E for ; Fri, 24 Mar 2023 10:40:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC65F4114A; Fri, 24 Mar 2023 10:40:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7720C406B8 for ; Fri, 24 Mar 2023 10:40:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679650821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L+LjObSPQKgu4YnXUA/wW2Al6rCVxwmYxUJ9MzwGang=; b=F5FheA/v6wbrZ2Sf4MESJpaxCmHdQ3Zc5x+9fF3ONvHTgfkHt4Exy2+C4IvJpMQdE2lU+J qlPh7dkkP0AxaslSeZeaJj3w1wFAsMZYjI/9PclOjnS4M9btgSSMI0M1quA5sYWPS4zVBT qB2sd0uAivcXPZaprpLYdEu1XglUW6U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-GCaqBPgkPtqhM7qMEIwv7w-1; Fri, 24 Mar 2023 05:40:20 -0400 X-MC-Unique: GCaqBPgkPtqhM7qMEIwv7w-1 Received: by mail-wm1-f69.google.com with SMTP id m27-20020a05600c3b1b00b003ee502f1b16so762502wms.9 for ; Fri, 24 Mar 2023 02:40:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679650819; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L+LjObSPQKgu4YnXUA/wW2Al6rCVxwmYxUJ9MzwGang=; b=2CFtK6hfIPHnjCBrxSa/lRF+j7sv0Wygwtikquj0S4z4k6K3ivu9PfctyLj8bpDNyf 4r/80yBosOnF3GNr3L2hEqPgXWiAZI5Cwbbfl4xSr2IrDIW9bhynaiP1QQCVgALUlQjN UcseHe68yLk2+fe4DaPbWyHo1srEXNlo2i05u5RDyXqXiuEWmsRBlArlsMc6IY6ZCwMc 38H1lkCGtx39+Od8ZgwE6z98pWDc+dQiJpGuHSZgEm/uWgzd7D1rvaqy36QZuO6LZtIq uPv1J3DrTyGcXWBT/oPQgMbcQqZ9jGmYIhW5fYtEcqB2PISjzPUWmKM5YK+UME3+ENka irhg== X-Gm-Message-State: AAQBX9epRS617RzROdF9VY/ukxxb5T5MZ8MUXGwafsmyzVe0WsKvMzHS K3RZLJF9Z1ml22+crIllJupwY+ZCUXRD1h8sI5Xxm2sBkNT5XsFi9grqdH9XEqw6eCizsShFnIF X1UlwH9U= X-Received: by 2002:a5d:5257:0:b0:2dc:c45:faf6 with SMTP id k23-20020a5d5257000000b002dc0c45faf6mr1541277wrc.51.1679650819549; Fri, 24 Mar 2023 02:40:19 -0700 (PDT) X-Google-Smtp-Source: AKy350YEjxKb9rWzZBbjrR2JLiLcMcXJ2/Iu2ovyc59dQGh9nzQTOVJWN7JZUg00GtpigCYk6AinUA== X-Received: by 2002:a5d:5257:0:b0:2dc:c45:faf6 with SMTP id k23-20020a5d5257000000b002dc0c45faf6mr1541258wrc.51.1679650819296; Fri, 24 Mar 2023 02:40:19 -0700 (PDT) Received: from [192.168.0.36] ([78.19.103.115]) by smtp.gmail.com with ESMTPSA id t14-20020a05600001ce00b002da76acfee1sm5673178wrx.28.2023.03.24.02.40.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 02:40:18 -0700 (PDT) Message-ID: <8c07a9b9-033e-8069-dcd2-52b41d4b036a@redhat.com> Date: Fri, 24 Mar 2023 09:40:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 To: "Jiang, YuX" , "Zhang, Qi Z" , "Su, Simei" , "Xing, Beilei" , "Zhang, Yuying" , "david.marchand@redhat.com" Cc: "dev@dpdk.org" , "Yang, Qiming" , "stable@dpdk.org" , Luca Boccassi , "Mcnamara, John" References: <20230202123632.56730-1-simei.su@intel.com> <20230220075952.444153-1-simei.su@intel.com> <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com> <9aa3b88a-5e2f-d857-b554-d88a572b46b2@redhat.com> From: Kevin Traynor Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 24/03/2023 06:32, Jiang, YuX wrote: >> -----Original Message----- >> From: Kevin Traynor >> Sent: Thursday, March 23, 2023 10:51 PM >> To: Zhang, Qi Z ; Su, Simei ; Xing, >> Beilei ; Zhang, Yuying ; >> david.marchand@redhat.com; Jiang, YuX >> Cc: dev@dpdk.org; Yang, Qiming ; stable@dpdk.org; >> Luca Boccassi ; Mcnamara, John >> >> Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration >> >> On 22/03/2023 16:50, Kevin Traynor wrote: >>> On 27/02/2023 00:35, Zhang, Qi Z wrote: >>>> >>> >>> Hi Simei/Qi/Yu >>> >> >> Hi Yu, >> >>>> >>>>> -----Original Message----- >>>>> From: Su, Simei >>>>> Sent: Monday, February 20, 2023 4:00 PM >>>>> To: Xing, Beilei ; Zhang, Yuying >>>>> ; Zhang, Qi Z ; >>>>> david.marchand@redhat.com >>>>> Cc: dev@dpdk.org; Yang, Qiming ; Su, Simei >>>>> ; stable@dpdk.org >>>>> Subject: [PATCH v6] net/i40e: rework maximum frame size >>>>> configuration >>>>> >>>>> One issue is reported by David Marchand that error occurs in OVS due >>>>> to the fix patch in mentioned changes below. The detailed reproduce >>>>> step and result are in >>>>> https://patchwork.dpdk.org/project/dpdk/patch/ >>>>> 20211207085946.121032-1-dapengx.yu@intel.com/. >>>>> >>>>> This patch removes unnecessary link status check and directly sets >>>>> mac config in dev_start. Also, it sets the parameter "wait to >>>>> complete" true to wait for more time to make sure adminq command >> execute completed. >>>>> >>> >>>>> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port >>>>> level") >>>>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port >>>>> level") >>>>> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") >>>>> Cc: stable@dpdk.org >>> >>> These patches caused an observable regression in multiple 20.11 and >>> 21.11 LTS releases that was only caught a long time after releases. >>> >>> Is there anything being added to LTS validation for regression testing >>> this issue, so we don't get caught again? >>> >> >> This is the issue I was talking about earlier during the release meeting. Not sure >> if we were talking about the same patch. >> >> I was asking if there are some regression tests added/can be added to LTS >> validation that will be run during each LTS validation cycle so we don't have any >> more regressions on it. >> > Hi Kevin, > Thanks for your comments. > Yes. We are adding additional case to cover more testing. For main branch, we have done the regression testing (including the additional case testing), they both work well. That's good to hear. Will the additional regression tests also be added to the LTS validation tests when they are run? > We hope the two related patches can be backported to LTS branch, and the second patch just reworks for previous bug's fix. > Patch1: https://patchwork.dpdk.org/project/dpdk/patch/20221213091837.87953-1-david.marchand@redhat.com/ a8ca8ed net/i40e: revert link status check on device start I have already reverted those 3 backports on 21.11 branch so this is not needed. > Pathc2: https://patchwork.dpdk.org/project/dpdk/patch/20230306121853.27547-1-simei.su@intel.com/ 82fcf20 net/i40e: fix maximum frame size configuration > That is the v7 of this v6 with revert and fix split, so same one being discussed above. > Best regards, > Yu Jiang > >> thanks, >> Kevin. >> >>> After reverting the original patch and 2 fixes, I'm a bit reluctant to >>> take more fixes without some form of regression testing in place. >>> >>> thanks, >>> Kevin. >>> >>>>> >>>>> Reported-by: David Marchand >>>>> Signed-off-by: Simei Su >>>> >>>> Acked-by: Qi Zhang >>>> >>>> Applied to dpdk-next-net-intel. >>>> >>>> Thanks >>>> Qi >>>> >>> >